[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
authorwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Aug 2017 04:13:36 +0000 (04:13 +0000)
committerwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Aug 2017 04:13:36 +0000 (04:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175703

Reviewed by Ryosuke Niwa.

Source/WebCore:

Renames an inputType value to match the spec. There is no other change in behavior.
Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.

* editing/EditCommand.cpp:
(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Rebaselines two LayoutTests that check for the "formatForeColor" inputType.

* fast/events/input-events-forecolor-data-expected.txt:
* fast/events/input-events-selection-forecolor-data.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/input-events-forecolor-data-expected.txt
LayoutTests/fast/events/input-events-selection-forecolor-data.html
Source/WebCore/ChangeLog
Source/WebCore/editing/EditCommand.cpp

index 6202fa551c372014e48c51b966fd3b263ed926e2..b7ae2bcea2f3ea80279198d9a2aab2fd79ebcb39 100644 (file)
@@ -1,3 +1,15 @@
+2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+        https://bugs.webkit.org/show_bug.cgi?id=175703
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaselines two LayoutTests that check for the "formatForeColor" inputType.
+
+        * fast/events/input-events-forecolor-data-expected.txt:
+        * fast/events/input-events-selection-forecolor-data.html:
+
 2017-08-17  Ryan Haddad  <ryanhaddad@apple.com>
 
         Mark media/video-controls-rendering.html as flaky.
index 7d81391045598730a872425461c6475b80a9cc1d..dc32d5b3a46293a47f59ec33b3323a92b21fddb0 100644 (file)
@@ -4,28 +4,28 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 255, 255)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 255, 255)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(100, 255, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(100, 255, 0)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(0, 0, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(0, 0, 0)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 0, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 0, 0)
 PASS successfullyParsed is true
 
index 3ec9f2f181c5211379a1f4550584e05596fe0306..00a84f805ea3a438550d9cdd6478df9ec783d979 100644 (file)
@@ -29,7 +29,7 @@
 
         function handleInput(event)
         {
-            if (event.inputType === "formatForeColor")
+            if (event.inputType === "formatFontColor")
                 write(`Received ${event.type} event with data: "${event.data}"`);
         }
     </script>
index a4601e2e02252762cbb3f1599433228c235ace65..8d24cf2991302fc545fbda1e554cb9eedc47e97f 100644 (file)
@@ -1,3 +1,16 @@
+2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+        https://bugs.webkit.org/show_bug.cgi?id=175703
+
+        Reviewed by Ryosuke Niwa.
+
+        Renames an inputType value to match the spec. There is no other change in behavior.
+        Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.
+
+        * editing/EditCommand.cpp:
+        (WebCore::inputTypeNameForEditingAction):
+
 2017-08-17  Daewoong Jang  <daewoong.jang@navercorp.com>
 
         [Curl] Improve multi-threaded networking
index d04f5bb2cb28288934a833490c5baf3f7ebcc744..8cc10c7cb3ad41fe85c6d2a7bbe9ca87984d46c3 100644 (file)
@@ -56,7 +56,7 @@ String inputTypeNameForEditingAction(EditAction action)
     case EditActionUnderline:
         return ASCIILiteral("formatUnderline");
     case EditActionSetColor:
-        return ASCIILiteral("formatForeColor");
+        return ASCIILiteral("formatFontColor");
     case EditActionDeleteByDrag:
         return ASCIILiteral("deleteByDrag");
     case EditActionCut: