2007-10-14 Eric Seidel <eric@webkit.org>

        Reviewed by aroben.

        Remove senseless malloc from paintOutline
        No tests needed, no functional change.

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintOutline): remove unneeded malloc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 49ea6dd4932641cb9748738bb96ff3b5121726d4..a57ffeb2f3d5b3b079d93dc010e53e0b0c47b574 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2007-10-14  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by aroben.
+
+        Remove senseless malloc from paintOutline
+        No tests needed, no functional change.
+
+        * rendering/RenderFlow.cpp:
+        (WebCore::RenderFlow::paintOutline): remove unneeded malloc
+
 2007-10-13  Eric Seidel  <eric@webkit.org>
 
         Reviewed by Mark Rowe.

diff --git a/WebCore/rendering/RenderFlow.cpp b/WebCore/rendering/RenderFlow.cpp
index 7e60112605c384b38aef9494c701d5180b64797f..ebb107f9202385f572e2c22dfc59f3e0d611c6a7 100644 (file)
--- a/WebCore/rendering/RenderFlow.cpp
+++ b/WebCore/rendering/RenderFlow.cpp
@@ -759,17 +759,16 @@ void RenderFlow::paintOutline(GraphicsContext* graphicsContext, int tx, int ty)
     if (style()->outlineStyleIsAuto() || style()->outlineStyle() <= BHIDDEN)
         return;
 
-    Vector<IntRect*> rects;
+    Vector<IntRect> rects;
 
-    rects.append(new IntRect);
+    rects.append(IntRect());
     for (InlineRunBox* curr = firstLineBox(); curr; curr = curr->nextLineBox())
-        rects.append(new IntRect(curr->xPos(), curr->yPos(), curr->width(), curr->height()));
+        rects.append(IntRect(curr->xPos(), curr->yPos(), curr->width(), curr->height()));
 
-    rects.append(new IntRect);
+    rects.append(IntRect());
 
     for (unsigned i = 1; i < rects.size() - 1; i++)
-        paintOutlineForLine(graphicsContext, tx, ty, *rects.at(i - 1), *rects.at(i), *rects.at(i + 1));
-    deleteAllValues(rects);
+        paintOutlineForLine(graphicsContext, tx, ty, rects.at(i - 1), rects.at(i), rects.at(i + 1));
 }
 
 void RenderFlow::paintOutlineForLine(GraphicsContext* graphicsContext, int tx, int ty,