Reviewed by Maciej.

        - fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange
        when composing a reply

        * khtml/editing/htmlediting.cpp:
        (khtml::StyleChange::checkForLegacyHTMLStyleChange):
        Added missing nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 34b03b379b8686938a229859ffbda2f66d25be1f..259c0ee6c4d5a2184c22cac1889f5fcc9bd38039 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2005-03-05  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Maciej.
+        
+        - fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange 
+        when composing a reply
+
+        * khtml/editing/htmlediting.cpp:
+        (khtml::StyleChange::checkForLegacyHTMLStyleChange):
+        Added missing nil check.
+
 2005-03-05  Darin Adler  <darin@apple.com>
 
         Reviewed by Don.

diff --git a/WebCore/khtml/editing/htmlediting.cpp b/WebCore/khtml/editing/htmlediting.cpp
index 598b04e3fbefdb910eaee77c3d226c18e6283f95..64f132953c53e9d562ad5350c6daed12eab0d13d 100644 (file)
--- a/WebCore/khtml/editing/htmlediting.cpp
+++ b/WebCore/khtml/editing/htmlediting.cpp
@@ -458,6 +458,10 @@ StyleChange::ELegacyHTMLStyles StyleChange::styleModeForParseMode(bool isQuirksM
 
 bool StyleChange::checkForLegacyHTMLStyleChange(const CSSProperty *property)
 {
+    if (!property || !property->value()) {
+        return false;
+    }
+    
     DOMString valueText(property->value()->cssText());
     switch (property->id()) {
         case CSS_PROP_FONT_WEIGHT: