Remove an inaccurate comment in WKActionMenuController
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Oct 2014 17:37:12 +0000 (17:37 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Oct 2014 17:37:12 +0000 (17:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138135

Reviewed by Anders Carlsson.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForLink]):
The comment is wrong; the separator is there for spacing, not just as a workaround.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/mac/WKActionMenuController.mm

index f7f45a9bc74b633b3c81f2bffec239e2b33ef889..5794cec62a8392f1a2251703d4cc475969ca1507 100644 (file)
@@ -1,3 +1,14 @@
+2014-10-28  Tim Horton  <timothy_horton@apple.com>
+
+        Remove an inaccurate comment in WKActionMenuController
+        https://bugs.webkit.org/show_bug.cgi?id=138135
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController _defaultMenuItemsForLink]):
+        The comment is wrong; the separator is there for spacing, not just as a workaround.
+
 2014-10-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.
index ff4a38e32c7055d87b149cd6366fefe48b8fd304..46d234887331211d86c5e76a3dbfce03fad25f82 100644 (file)
@@ -149,7 +149,6 @@ using namespace WebKit;
     RetainPtr<NSMenuItem> previewLinkItem = [self _createActionMenuItemForTag:kWKContextActionItemTagPreviewLink];
     RetainPtr<NSMenuItem> readingListItem = [self _createActionMenuItemForTag:kWKContextActionItemTagAddLinkToSafariReadingList];
 
-    // FIXME: The separator item is required to work around <rdar://18684207>.
     return @[ openLinkItem.get(), previewLinkItem.get(), [NSMenuItem separatorItem], readingListItem.get() ];
 }