Remove WKContentView _setFindIndicator:fadeOut:animate:
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jun 2014 19:04:40 +0000 (19:04 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jun 2014 19:04:40 +0000 (19:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=133976

Reviewed by Anders Carlsson.

Find indicators are totally internal to FindController on iOS,
we don't need to push them to the content view via PageClient,
so this code was unused.

* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
Source/WebKit2/UIProcess/ios/WKContentView.h
Source/WebKit2/UIProcess/ios/WKContentView.mm

index a16343ca890aef672e350b969e9fc16c86e8d0ef..59e7c6fc6298f407e3e25d694368fd17bc70ed4b 100644 (file)
@@ -1,3 +1,20 @@
+2014-06-17  Tim Horton  <timothy_horton@apple.com>
+
+        Remove WKContentView _setFindIndicator:fadeOut:animate:
+        https://bugs.webkit.org/show_bug.cgi?id=133976
+
+        Reviewed by Anders Carlsson.
+
+        Find indicators are totally internal to FindController on iOS,
+        we don't need to push them to the content view via PageClient,
+        so this code was unused.
+
+        * UIProcess/ios/PageClientImplIOS.mm:
+        (WebKit::PageClientImpl::setFindIndicator):
+        * UIProcess/ios/WKContentView.h:
+        * UIProcess/ios/WKContentView.mm:
+        (-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.
+
 2014-06-17  Andreas Kling  <akling@apple.com>
 
         Web process main thread priority is lower than some network process threads.
index ddef0cca78df594ea8e703fc05247aed7cb5f382..36829ddf62b89c955a41a6f438889ad00685ee70 100644 (file)
@@ -372,7 +372,6 @@ PassRefPtr<WebContextMenuProxy> PageClientImpl::createContextMenuProxy(WebPagePr
 
 void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator> findIndicator, bool fadeOut, bool animate)
 {
-    [m_contentView _setFindIndicator:findIndicator fadeOut:fadeOut animate:animate];
 }
 
 void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext& layerTreeContext)
index 5da4de8cba71ee29391938d45c3e2fa061188b36..6b368162f3f5d28f8cae001ad8b52e43e4862fc5 100644 (file)
@@ -86,6 +86,4 @@ struct WebPageConfiguration;
 - (BOOL)_zoomToRect:(CGRect)targetRect withOrigin:(CGPoint)origin fitEntireRect:(BOOL)fitEntireRect minimumScale:(double)minimumScale maximumScale:(double)maximumScale minimumScrollDistance:(CGFloat)minimumScrollDistance;
 - (void)_zoomOutWithOrigin:(CGPoint)origin;
 
-- (void)_setFindIndicator:(PassRefPtr<WebKit::FindIndicator>)findIndicator fadeOut:(BOOL)fadeOut animate:(BOOL)animate;
-
 @end
index 355180c2474551b7ef6f4f1ec414e2907686cdd6..369887e7078193dcc33f5cccd4eea6c60120dbde 100644 (file)
@@ -465,11 +465,6 @@ private:
     _page->applicationDidBecomeActive();
 }
 
-- (void)_setFindIndicator:(PassRefPtr<WebKit::FindIndicator>)findIndicator fadeOut:(BOOL)fadeOut animate:(BOOL)animate
-{
-    notImplemented();
-}
-
 @end
 
 #endif // PLATFORM(IOS)