Turn SourceBufferChangeTypeEnabled on by default
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Sep 2018 17:03:35 +0000 (17:03 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Sep 2018 17:03:35 +0000 (17:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189527

Reviewed by Eric Carlson.

Source/WebCore:

* page/Settings.yaml:

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Settings.yaml
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebView/WebPreferences.mm

index a59cd8c..99eb5ec 100644 (file)
@@ -1,3 +1,12 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * page/Settings.yaml:
+
 2018-09-14  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: Record actions performed on ImageBitmapRenderingContext
 2018-09-14  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: Record actions performed on ImageBitmapRenderingContext
index 4743e64..77df063 100644 (file)
@@ -431,7 +431,7 @@ mediaSourceEnabled:
   conditional: MEDIA_SOURCE
 
 sourceBufferChangeTypeEnabled:
   conditional: MEDIA_SOURCE
 
 sourceBufferChangeTypeEnabled:
-  initial: false
+  initial: true
   conditional: MEDIA_SOURCE
 
 # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
   conditional: MEDIA_SOURCE
 
 # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
index 4af5810..666db69 100644 (file)
@@ -1,3 +1,13 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferences.yaml:
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
 2018-09-14  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         Unreviewed, speculative WPE build fix after r236004
 2018-09-14  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         Unreviewed, speculative WPE build fix after r236004
index 9db338e..3f83115 100644 (file)
@@ -1125,6 +1125,11 @@ IsSecureContextAttributeEnabled:
   defaultValue: true
   webcoreBinding: RuntimeEnabledFeatures
 
   defaultValue: true
   webcoreBinding: RuntimeEnabledFeatures
 
+SourceBufferChangeTypeEnabled:
+  type: bool
+  defaultValue: true
+  condition: ENABLE(MEDIA_SOURCE)
+
 # For experimental features:
 # The type should be boolean.
 # You must provide a humanReadableName and humanReadableDescription for all experimental features. They
 # For experimental features:
 # The type should be boolean.
 # You must provide a humanReadableName and humanReadableDescription for all experimental features. They
@@ -1270,14 +1275,6 @@ ProcessSwapOnCrossSiteNavigationEnabled:
   category: internal
   webcoreBinding: none
 
   category: internal
   webcoreBinding: none
 
-SourceBufferChangeTypeEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Media Source Codec Switching Support"
-  humanReadableDescription: "Media Source Codec Switching through changeType()"
-  category: internal
-  condition: ENABLE(MEDIA_SOURCE)
-
 ResourceLoadStatisticsDebugMode:
   type: bool
   defaultValue: false
 ResourceLoadStatisticsDebugMode:
   type: bool
   defaultValue: false
index 9a86f39..31606a0 100644 (file)
@@ -380,7 +380,7 @@ WK_EXPORT bool WKPreferencesUseLegacyTextAlignPositionedElementBehavior(WKPrefer
 WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
 
 WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
 
-// Defaults to false;
+// Defaults to true;
 WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);
 
 WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);
 
index cd2c1b2..7c96424 100644 (file)
@@ -1,3 +1,13 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+
 2018-09-12  Alex Christensen  <achristensen@webkit.org>
 
         Fix an internal build after r235935
 2018-09-12  Alex Christensen  <achristensen@webkit.org>
 
         Fix an internal build after r235935
index 2d1a9d7..2221732 100644 (file)
@@ -605,7 +605,7 @@ public:
         [NSNumber numberWithBool:NO], WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
 #if ENABLE(MEDIA_SOURCE)
         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
 #if ENABLE(MEDIA_SOURCE)
         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
-        @NO, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
+        @YES, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
 #endif
 #if ENABLE(SERVICE_CONTROLS)
         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,
 #endif
 #if ENABLE(SERVICE_CONTROLS)
         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,