window.HTMLDetailsElement should exist

https://bugs.webkit.org/show_bug.cgi?id=149139

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C tests now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

window.HTMLDetailsElement should exist:
https://html.spec.whatwg.org/multipage/forms.html#the-details-element

Drop the [NoInterfaceObject] IDL extended attribute in WebKit to
address the problem.

No new tests, already covered by existing tests.

* html/HTMLDetailsElement.idl:

LayoutTests:

Rebaseline test now that HTMLDetailsElement is exposed on the global
Window object.

* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index e4cb2b2c604b8abefbf3fd63ebf7fbf6078f292a..0f9ec5db4c34c090308a167fa4b19f937d3adc83 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,20 @@
+2015-09-14  Chris Dumez  <cdumez@apple.com>
+
+        window.HTMLDetailsElement should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149139
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline test now that HTMLDetailsElement is exposed on the global
+        Window object.
+
+        * platform/efl/js/dom/global-constructors-attributes-expected.txt:
+        * platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+        * platform/win/js/dom/global-constructors-attributes-expected.txt:
+
 2015-09-14  Brian Burg  <bburg@apple.com>
 
         Web Inspector: backend command promises are not rejected when a protocol error occurs

diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
index 621f379611c46bed860d71d024c509e589ceebc2..7bff58d4f296fd3a3dcb075dd376c120ebdf103c 100644 (file)
--- a/LayoutTests/imported/w3c/ChangeLog
+++ b/LayoutTests/imported/w3c/ChangeLog
@@ -1,3 +1,16 @@
+2015-09-14  Chris Dumez  <cdumez@apple.com>
+
+        window.HTMLDetailsElement should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149139
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C tests now that more checks are passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+        * web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt:
+        * web-platform-tests/html/semantics/interfaces-expected.txt:
+
 2015-09-13  Chris Dumez  <cdumez@apple.com>
 
         Improve Node pre-insertion validation when the parent is a Document

diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
index e4dc04948fa749bb962bfeb52ef1ebe6f89ad76d..a162bb314f00085ae1be98babe6c3e9128f275e2 100644 (file)
--- a/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
+++ b/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
@@ -560,6 +560,7 @@ CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'validity' on a
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'validationMessage' on a non-HTMLFieldSetElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'form' on a non-HTMLLegendElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'align' on a non-HTMLLegendElement object.
+CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'open' on a non-HTMLDetailsElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'compact' on a non-HTMLMenuElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'src' on a non-HTMLScriptElement object.
 CONSOLE MESSAGE: line 583: Deprecated attempt to access property 'type' on a non-HTMLScriptElement object.
@@ -5112,12 +5113,16 @@ PASS ValidityState interface: document.createElement("input").validity must inhe
 PASS ValidityState interface: document.createElement("input").validity must inherit property "badInput" with the proper type (8) 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "customError" with the proper type (9) 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "valid" with the proper type (10) 
-FAIL HTMLDetailsElement interface: existence and properties of interface object assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface object length assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: existence and properties of interface prototype object assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement interface: attribute open assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
-FAIL HTMLDetailsElement must be primary interface of document.createElement("details") assert_own_property: self does not have own property "HTMLDetailsElement" expected property "HTMLDetailsElement" missing
+FAIL HTMLDetailsElement interface: existence and properties of interface object assert_equals: prototype of self's property "HTMLDetailsElement" is not Function.prototype expected (function) function "function () {
+    [native code]
+}" but got (object) object "[object Object]"
+PASS HTMLDetailsElement interface object length 
+PASS HTMLDetailsElement interface: existence and properties of interface prototype object 
+FAIL HTMLDetailsElement interface: existence and properties of interface prototype object's "constructor" property assert_true: HTMLDetailsElement.prototype.constructor is not writable expected true got false
+FAIL HTMLDetailsElement interface: attribute open assert_throws: getting property on prototype object must throw TypeError function "function () {
+    [native code]
+}" did not throw
+PASS HTMLDetailsElement must be primary interface of document.createElement("details") 
 PASS Stringification of document.createElement("details") 
 PASS HTMLDetailsElement interface: document.createElement("details") must inherit property "open" with the proper type (0) 
 FAIL HTMLMenuElement interface: existence and properties of interface object assert_equals: prototype of self's property "HTMLMenuElement" is not Function.prototype expected (function) function "function () {

diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt
index 892eacf402d7117adf1db3fbb2043338c54c0e95..5ffdbae6fe1e69f4511bbc3b2823b1b2a0bfadad 100644 (file)
--- a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt
+++ b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-expected.txt
@@ -1,7 +1,7 @@
 
 PASS HTML parsing should locate 2 details elements in this document 
 PASS HTML parsing should close an unclosed <p> before <details> 
-FAIL HTMLDetailsElement should be exposed for prototyping assert_true: expected true got false
-FAIL a dynamically created details element should be instanceof HTMLDetailsElement window.HTMLDetailsElement is not a function. (evaluating 'makeDetails() instanceof window.HTMLDetailsElement')
-FAIL a details element from the parser should be instanceof HTMLDetailsElement window.HTMLDetailsElement is not a function. (evaluating 'document.getElementById('one').getElementsByTagName('details')[0] instanceof window.HTMLDetailsElement')
+PASS HTMLDetailsElement should be exposed for prototyping 
+PASS a dynamically created details element should be instanceof HTMLDetailsElement 
+PASS a details element from the parser should be instanceof HTMLDetailsElement 
 

diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt
index fd7bf84394978f69a192dfcba5bd0dc2ce93c7e4..18ccbe6c00d83b5ba8b667dae74a9a152f326415 100644 (file)
--- a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt
+++ b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt
@@ -247,8 +247,8 @@ FAIL Interfaces for datalist assert_equals: Element datalist should have HTMLDat
 FAIL Interfaces for DATALIST assert_equals: Element DATALIST should have HTMLDataListElement as its primary interface. expected "[object HTMLDataListElement]" but got "[object HTMLUnknownElement]"
 PASS Interfaces for output 
 PASS Interfaces for OUTPUT 
-FAIL Interfaces for details window[i] is not a function. (evaluating 'e instanceof window[i]')
-FAIL Interfaces for DETAILS window[i] is not a function. (evaluating 'e instanceof window[i]')
+PASS Interfaces for details 
+PASS Interfaces for DETAILS 
 FAIL Interfaces for command assert_equals: Element command should have HTMLCommandElement as its primary interface. expected "[object HTMLCommandElement]" but got "[object HTMLElement]"
 FAIL Interfaces for COMMAND assert_equals: Element COMMAND should have HTMLCommandElement as its primary interface. expected "[object HTMLCommandElement]" but got "[object HTMLElement]"
 PASS Interfaces for nextid 

diff --git a/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
index b881ea0645a1718ba984eca77b2e52aaa0fb561c..d7ff25e6ac82766ec63fb545dc82ba78a0d6e03e 100644 (file)
--- a/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
@@ -453,6 +453,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDataListElement').hasOwnProper
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDataListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDataListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDataListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
index b93202c61d292041d9a6a0e78ffaf86089c9b88d..2c6d7b54e3ac913de6cfadc33bc1ccd22d4b1f29 100644 (file)
--- a/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
@@ -453,6 +453,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty(
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
index 65696e3cfbf9a567c9d62b206f1110d00bb472d4..da58a5431f6337e118cc96f75e11a070544ee484 100644 (file)
--- a/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
@@ -448,6 +448,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty(
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
index 8a000ea7e30cb7ec571339904061d506e6c3098f..12099e382c1607c2ef22bcd59743af2ce40188d1 100644 (file)
--- a/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
@@ -448,6 +448,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty(
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
index 27ad007593a61a66d7aa49f44b8ef6e611daa094..366439a9b5eeb99ca8c8cbaf93cb5332ec880d76 100644 (file)
--- a/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
@@ -448,6 +448,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty(
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt b/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
index 0e7ac3abff6da2525e557777c43b423de6b4cca1..25e00bec3ca94c7d3e63fb3f9af275fdd1294f59 100644 (file)
--- a/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
+++ b/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
@@ -373,6 +373,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty(
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDListElement').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').value is HTMLDetailsElement
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'HTMLDetailsElement').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').value is HTMLDirectoryElement
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'HTMLDirectoryElement').hasOwnProperty('set') is false

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 6f771f5201c2f87e02682b11832e89310c4f1881..2715890cd9a120e9c7a2ebfa4d210ba7b2a7649b 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2015-09-14  Chris Dumez  <cdumez@apple.com>
+
+        window.HTMLDetailsElement should exist
+        https://bugs.webkit.org/show_bug.cgi?id=149139
+
+        Reviewed by Ryosuke Niwa.
+
+        window.HTMLDetailsElement should exist:
+        https://html.spec.whatwg.org/multipage/forms.html#the-details-element
+
+        Drop the [NoInterfaceObject] IDL extended attribute in WebKit to
+        address the problem.
+
+        No new tests, already covered by existing tests.
+
+        * html/HTMLDetailsElement.idl:
+
 2015-09-14  Alex Christensen  <achristensen@webkit.org>
 
         Fix AppleWin CMake build

diff --git a/Source/WebCore/html/HTMLDetailsElement.idl b/Source/WebCore/html/HTMLDetailsElement.idl
index 011f9e1badd766c295974195731d9a644ac8c5e8..ca3894e2fe62def6f34d1fc722e65b8da8057ef2 100644 (file)
--- a/Source/WebCore/html/HTMLDetailsElement.idl
+++ b/Source/WebCore/html/HTMLDetailsElement.idl
@@ -18,7 +18,6 @@
  */
 
 [
-    NoInterfaceObject,
     Conditional=DETAILS_ELEMENT
 ] interface HTMLDetailsElement : HTMLElement {
     [Reflect] attribute boolean open;