Reviewed by Harrison.

        - fixed <rdar://problem/4049776> Seed: Mail: Disable spellcheck leaves red artifacts

        * WebView.subproj/WebFrameInternal.h: Added _unmarkAllMisspellings.
        * WebView.subproj/WebFrame.m: (-[WebFrame _unmarkAllMisspellings]): Added.
        Calls unmarkAllMisspellings on the bridge and self and all subframes.

        * WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]):
        Call _unmarkAllMisspellings on the main frame when turning continuous spell checking off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 0fbdd256e59a1eb6ac2eeb37facb839c0cfaab14..f96d454bbc55f1c4f92d5643a65adc8a3326480b 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,16 @@
+2005-03-14  Darin Adler  <darin@apple.com>
+
+        Reviewed by Harrison.
+
+        - fixed <rdar://problem/4049776> Seed: Mail: Disable spellcheck leaves red artifacts
+
+        * WebView.subproj/WebFrameInternal.h: Added _unmarkAllMisspellings.
+        * WebView.subproj/WebFrame.m: (-[WebFrame _unmarkAllMisspellings]): Added.
+        Calls unmarkAllMisspellings on the bridge and self and all subframes.
+
+        * WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]):
+        Call _unmarkAllMisspellings on the main frame when turning continuous spell checking off.
+
 2005-03-14  Richard Williamson   <rjw@apple.com>
 
        Fixed <rdar://problem/4027928> Tiger_8A394:Acrobat crashes while tried to remove the subscription errors by clicking on "Would you like to remove the subscription" from Tracker details view pane
@@ -485,7 +498,6 @@
 
 === Safari-401 ===
 
->>>>>>> 1.3057
 2005-03-01  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Darin.

diff --git a/WebKit/WebView.subproj/WebFrame.m b/WebKit/WebView.subproj/WebFrame.m
index 30b8e8815c6ca4c1851079901eeee281c3c26ae5..93452fac2711743ceb581b078f0c121da4586563 100644 (file)
--- a/WebKit/WebView.subproj/WebFrame.m
+++ b/WebKit/WebView.subproj/WebFrame.m
@@ -2587,6 +2587,12 @@ static CFAbsoluteTime _timeOfLastCompletedLoad;
     [request release];
 }
 
+- (void)_unmarkAllMisspellings
+{
+    [[self _bridge] unmarkAllMisspellings];
+    [_private->children makeObjectsPerformSelector:@selector(_unmarkAllMisspellings)];
+}
+
 @end
 
 @implementation WebFormState : NSObject

diff --git a/WebKit/WebView.subproj/WebFrameInternal.h b/WebKit/WebView.subproj/WebFrameInternal.h
index 6b7188ff0383b48f72d03a9a54b6e52394680a36..d71301f838b71a13a6351525a51078b67dad3e73 100644 (file)
--- a/WebKit/WebView.subproj/WebFrameInternal.h
+++ b/WebKit/WebView.subproj/WebFrameInternal.h
@@ -8,6 +8,7 @@
 - (void)_setInternalLoadDelegate:(id)internalLoadDelegate;
 - (id)_internalLoadDelegate;
 - (void)_sendResourceLoadDelegateMessagesForURL:(NSURL *)URL response:(NSURLResponse *)response length:(unsigned)length;
+- (void)_unmarkAllMisspellings;
 
 @end
 

diff --git a/WebKit/WebView.subproj/WebView.m b/WebKit/WebView.subproj/WebView.m
index ec0ad5a30b4fb901788027a7a3440d8e8bff397c..53a8d8b212709d454753af1baeec1fe3dbb56d93 100644 (file)
--- a/WebKit/WebView.subproj/WebView.m
+++ b/WebKit/WebView.subproj/WebView.m
@@ -2766,7 +2766,7 @@ static WebFrame *incrementFrame(WebFrame *curr, BOOL forward, BOOL wrapFlag)
     if ([self isContinuousSpellCheckingEnabled]) {
         [self _preflightSpellChecker];
     } else {
-        // FIXME: Put code here to remove underlines for misspelled words.
+        [[self mainFrame] _unmarkAllMisspellings];
     }
 }