2010-12-17 Ojan Vafai <ojan@chromium.org>

        Speculative fix for the code review tool in Firefox.
        Fixes a JS error and makes the status bubble mostly work
        if postMessage is not supported.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/BugsSite/ChangeLog b/BugsSite/ChangeLog
index 75e4d4933fbd9dd6fa58349dafde41529e33d45e..d4627de1bfbb80322f954723fbbc7c223a731468 100644 (file)
--- a/BugsSite/ChangeLog
+++ b/BugsSite/ChangeLog
@@ -1,3 +1,12 @@
+2010-12-17  Ojan Vafai  <ojan@chromium.org>
+
+        Speculative fix for the code review tool in Firefox.
+        Fixes a JS error and makes the status bubble mostly work
+        if postMessage is not supported.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-12-15  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/BugsSite/PrettyPatch/PrettyPatch.rb b/BugsSite/PrettyPatch/PrettyPatch.rb
index 1dd16811c67d344d894898095752c0a111087cd6..d7f2d58cdcda9967e3d261d779dc7827178fc2c5 100644 (file)
--- a/BugsSite/PrettyPatch/PrettyPatch.rb
+++ b/BugsSite/PrettyPatch/PrettyPatch.rb
@@ -349,6 +349,9 @@ body {
 }
 
 .statusBubble {
+  /* The width/height get set to the bubble contents via postMessage on browsers that support it. */
+  width: 450px;
+  height: 20px;
   margin: 2px 2px 0 0;
   border: none;
   vertical-align: middle;

diff --git a/BugsSite/code-review.js b/BugsSite/code-review.js
index c8872208d7da116dd743bf6c7a113f4f0d64d8be..2a3b2c96c7179b47766cf5d7b1934ca70baaa6dd 100644 (file)
--- a/BugsSite/code-review.js
+++ b/BugsSite/code-review.js
@@ -255,9 +255,11 @@
     if (e.origin != 'https://webkit-commit-queue.appspot.com')
       return;
 
-    $('.statusBubble')[0].style.height = e.data.height;
-    $('.statusBubble')[0].style.width = e.data.width;
-  });
+    if (e.data.height) {
+      $('.statusBubble')[0].style.height = e.data.height;
+      $('.statusBubble')[0].style.width = e.data.width;
+    }
+  }, false);
 
   function handleStatusBubbleLoad(e) {
     e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');