2010-10-29 Ojan Vafai <ojan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] add debug logging to help diagnose flakiness dashboard issues
        https://bugs.webkit.org/show_bug.cgi?id=48657

        The appengine app thinks it's getting empty files uploaded. Add some logging
        to see if new-run-webkit-tests agrees.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 49dd05c4825c7323f8c11fade883571733650a32..d194c3792fcebe35bc8fbc9d2c5fd0202e42130f 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,14 @@
+2010-10-29  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        [chromium] add debug logging to help diagnose flakiness dashboard issues
+        https://bugs.webkit.org/show_bug.cgi?id=48657
+
+        The appengine app thinks it's getting empty files uploaded. Add some logging
+        to see if new-run-webkit-tests agrees.
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
 
         Reviewed by Ojan Vafai.

diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 39d342bb681b6848c35b3ac6ca4ba559befb9fa5..1350ced1e6501a9ac3d6d7d683b29cb16825fa5d 100755 (executable)
--- a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -965,6 +965,13 @@ class TestRunner:
         files = [(file, os.path.join(self._options.results_directory, file))
             for file in json_files]
 
+        # FIXME: Remove this. This is temporary debug logging.
+        if self._options.builder_name.startswith("Webkit Linux"):
+            for filename in files:
+                _log.debug(filename[1])
+                with codecs.open(filename[1], "r") as results_file:
+                    _log.debug("%s:\n%s" % (filename[0], results_file.read()))
+
         uploader = test_results_uploader.TestResultsUploader(
             self._options.test_results_server)
         try: