Remove ChromeClient::hasOpenedPopup
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Aug 2017 17:38:14 +0000 (17:38 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Aug 2017 17:38:14 +0000 (17:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175804

Reviewed by Sam Weinig.

Source/WebCore:

No change in behavior.  All implementations just returned false.

* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::hasOpenedPopup const): Deleted.
* page/Chrome.h:
* page/ChromeClient.h:
* rendering/RenderMenuList.cpp:
(RenderMenuList::showPopup):

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::hasOpenedPopup const): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::hasOpenedPopup const): Deleted.

Source/WebKitLegacy/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::hasOpenedPopup const): Deleted.
* WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 files changed:
Source/WebCore/ChangeLog
Source/WebCore/loader/EmptyClients.h
Source/WebCore/page/Chrome.cpp
Source/WebCore/page/Chrome.h
Source/WebCore/page/ChromeClient.h
Source/WebCore/rendering/RenderMenuList.cpp
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
Source/WebKitLegacy/win/ChangeLog
Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp
Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h

index 9fc694ea04264a53482cebb53814610cc03b7a07..5de1c35d5d5f6640fb90dcb591de335528cdc6c4 100644 (file)
@@ -1,3 +1,20 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::hasOpenedPopup
+        https://bugs.webkit.org/show_bug.cgi?id=175804
+
+        Reviewed by Sam Weinig.
+
+        No change in behavior.  All implementations just returned false.
+
+        * loader/EmptyClients.h:
+        * page/Chrome.cpp:
+        (WebCore::Chrome::hasOpenedPopup const): Deleted.
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        * rendering/RenderMenuList.cpp:
+        (RenderMenuList::showPopup):
+
 2017-08-22  Andy Estes  <aestes@apple.com>
 
         [Payment Request] Implement error checking for show(), abort(), and canMakePayment()
index 0aa5830488d3966e5862c6c3bd60fa07c684c9d7..1dd6b5a74e7448690d0cd1d944a53c7ed4a23101 100644 (file)
@@ -94,7 +94,6 @@ class EmptyChromeClient : public ChromeClient {
 
     bool selectItemWritingDirectionIsNatural() final { return false; }
     bool selectItemAlignmentFollowsMenuWritingDirection() final { return false; }
-    bool hasOpenedPopup() const final { return false; }
     RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const final;
     RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const final;
 
index f7aced78815cf494a38ccc21c4c296c96bfe9746..f4e72ff89ac87f21cd9c7ae2617cf5444532974b 100644 (file)
@@ -521,11 +521,6 @@ bool Chrome::selectItemAlignmentFollowsMenuWritingDirection()
     return m_client.selectItemAlignmentFollowsMenuWritingDirection();
 }
 
-bool Chrome::hasOpenedPopup() const
-{
-    return m_client.hasOpenedPopup();
-}
-
 RefPtr<PopupMenu> Chrome::createPopupMenu(PopupMenuClient& client) const
 {
     notifyPopupOpeningObservers();
index 9d763b95b05ab623fc08a889166d2000c547dfcf..7a59a516e308edd45dd13589281d3706c3bb1ba0 100644 (file)
@@ -167,7 +167,6 @@ public:
 
     bool selectItemWritingDirectionIsNatural();
     bool selectItemAlignmentFollowsMenuWritingDirection();
-    bool hasOpenedPopup() const;
     RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const;
     RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const;
 
index 83090ae7af9193748df9022667a5a8a7b01f3d5c..9a4c58a58b9b17639fb5e72a1c97a2f6c051fbea 100644 (file)
@@ -381,7 +381,6 @@ public:
     virtual bool selectItemWritingDirectionIsNatural() = 0;
     virtual bool selectItemAlignmentFollowsMenuWritingDirection() = 0;
     // Checks if there is an opened popup, called by RenderMenuList::showPopup().
-    virtual bool hasOpenedPopup() const = 0;
     virtual RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const = 0;
     virtual RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const = 0;
 
index de5fbc47047226c40287bd33016ba1ccd84a3b82..f292b5797ac791c4056f6fdf9ad976317c2c773b 100644 (file)
@@ -370,9 +370,6 @@ void RenderMenuList::showPopup()
     if (m_popupIsVisible)
         return;
 
-    if (document().page()->chrome().hasOpenedPopup())
-        return;
-
     // Create m_innerBlock here so it ends up as the first child.
     // This is important because otherwise we might try to create m_innerBlock
     // inside the showPopup call and it would fail.
index 860eb39c483f25e7fd644a9c9dad3a604f51796a..9e22cb2bafaa5b1921de60a9c62d393bd03e442b 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::hasOpenedPopup
+        https://bugs.webkit.org/show_bug.cgi?id=175804
+
+        Reviewed by Sam Weinig.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::hasOpenedPopup const): Deleted.
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
 
         Disable access to secure cookies if an HTTPS site loads mixed content
index fee0d28677d000a5a7970dad49a5190f4d28ada0..da73c3f2041921574d18c331d22b7e61605ace6f 100644 (file)
@@ -828,12 +828,6 @@ bool WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection()
     return true;
 }
 
-bool WebChromeClient::hasOpenedPopup() const
-{
-    notImplemented();
-    return false;
-}
-
 RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
 {
     return WebPopupMenu::create(&m_page, &client);
index 0288f8bc724958e95895bc82caa40e1a2554233d..368328840b20fa863893f9a248570585dda65aca 100644 (file)
@@ -199,7 +199,6 @@ private:
 
     bool selectItemWritingDirectionIsNatural() final;
     bool selectItemAlignmentFollowsMenuWritingDirection() final;
-    bool hasOpenedPopup() const final;
     RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
     RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;
 
index 087d1dd5f4df2d4f52b3f2a7bad70a6368eec122..b53a1cfe54f588bc88b26c663137fbe214c9f6fa 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::hasOpenedPopup
+        https://bugs.webkit.org/show_bug.cgi?id=175804
+
+        Reviewed by Sam Weinig.
+
+        * WebCoreSupport/WebChromeClient.h:
+        * WebCoreSupport/WebChromeClient.mm:
+        (WebChromeClient::hasOpenedPopup const): Deleted.
+
 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
 
         Disable access to secure cookies if an HTTPS site loads mixed content
index fb21b378bfd18e03f9d60ff71d786a41f7647328..7c68d98464787a2b5e49dfaf096731c8efd05c09 100644 (file)
@@ -198,7 +198,6 @@ private:
 
     bool selectItemWritingDirectionIsNatural() override;
     bool selectItemAlignmentFollowsMenuWritingDirection() override;
-    bool hasOpenedPopup() const final;
     RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const override;
     RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const override;
 
index 2175752cfd9451d66420486005f470cec42c5ce8..b170ab934518ab8aa6a09e0850b799ba08cce3a7 100644 (file)
@@ -876,12 +876,6 @@ bool WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection()
     return true;
 }
 
-bool WebChromeClient::hasOpenedPopup() const
-{
-    notImplemented();
-    return false;
-}
-
 RefPtr<WebCore::PopupMenu> WebChromeClient::createPopupMenu(WebCore::PopupMenuClient& client) const
 {
 #if !PLATFORM(IOS)
index fad0a13052c54276f5e76433cf44377bf9645efb..65ba772a57a2e52059dc98a6857c754992491a89 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::hasOpenedPopup
+        https://bugs.webkit.org/show_bug.cgi?id=175804
+
+        Reviewed by Sam Weinig.
+
+        * WebCoreSupport/WebChromeClient.cpp:
+        (WebChromeClient::hasOpenedPopup const): Deleted.
+        * WebCoreSupport/WebChromeClient.h:
+
 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
 
         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
index 782a1367df0cb228c22c7d4d03adedcdf70192d9..59f89823afa8960e6e445b2661b9fce4c55eb368 100644 (file)
@@ -780,12 +780,6 @@ bool WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection()
     return true;
 }
 
-bool WebChromeClient::hasOpenedPopup() const
-{
-    notImplemented();
-    return false;
-}
-
 RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
 {
     return adoptRef(new PopupMenuWin(&client));
index 866787c070f4be838570a0fd7dfe6bd6121d83bb..a88dc227aad27f302dbce6fe2c6cb57b9ed0a428 100644 (file)
@@ -150,7 +150,6 @@ public:
 
     bool selectItemWritingDirectionIsNatural() final;
     bool selectItemAlignmentFollowsMenuWritingDirection() final;
-    bool hasOpenedPopup() const final;
     RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
     RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;