ChangeLog
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Aug 2004 15:57:09 +0000 (15:57 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Aug 2004 15:57:09 +0000 (15:57 +0000)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/htmlediting_impl.cpp

index 008110a229fe675da7cd5a126719d23f082adc4f..6cecddd5fdf6d1aab2bc83e5268c19ac2573e909 100644 (file)
@@ -1,11 +1,11 @@
 2004-08-31  Ken Kocienda  <kocienda@apple.com>
 
-        Reviewed by NOBODY (OOPS!).
+        Reviewed by me
 
-        * khtml/editing/htmlediting_impl.cpp:
-        (khtml::InputNewlineCommandImpl::doApply):
-        * layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
-        * layout-tests/editing/selection/move-by-line-001-expected.txt:
+        Checked in incorrect results for these tests. There are the right ones.
+
+        * layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt
+        * layout-tests/editing/selection/move-by-line-001-expected.txt
 
 2004-08-31  Ken Kocienda  <kocienda@apple.com>
 
index 682c60f863a50882def755b8b19a3cce0fed772f..cfba1ca603c044341ad1edc5f81b4da076f16dcb 100644 (file)
@@ -1388,8 +1388,9 @@ void InputNewlineCommandImpl::doApply()
         // Insert node, but place the caret into index 0 of the downstream
         // position. This will make the caret appear after the break, and as we know
         // there is content at that location, this is OK.
-        insertNodeBeforePosition(nodeToInsert, pos);
-        setEndingSelection(Position(pos.node(), pos.node()->caretMinOffset()));
+        Position endingPosition = pos.downstream(StayInBlock);
+        insertNodeBeforePosition(nodeToInsert, endingPosition);
+        setEndingSelection(endingPosition);
     }
     else if (atEnd) {
         LOG(Editing, "input newline case 3");