WebCore:
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Oct 2008 09:03:43 +0000 (09:03 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Oct 2008 09:03:43 +0000 (09:03 +0000)
2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/ChromeClientGtk.cpp:

WebKit/mac:

2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/ChromeClientQt.cpp:

WebKit/win:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

         Reviewed by Oliver Hunt

        * WebCoreSupport/WebChromeClient.cpp:

WebKit/wx:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

         Reviewed by Oliver Hunt

        * WebKitSupport/ChromeClientWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
WebCore/ChangeLog
WebCore/page/Chrome.cpp
WebCore/page/Chrome.h
WebCore/page/ChromeClient.h
WebCore/platform/ScrollView.h
WebCore/platform/gtk/ScrollViewGtk.cpp
WebCore/platform/qt/ScrollViewQt.cpp
WebCore/platform/win/ScrollViewWin.cpp
WebKit/gtk/ChangeLog
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
WebKit/mac/ChangeLog
WebKit/mac/WebCoreSupport/WebChromeClient.h
WebKit/mac/WebCoreSupport/WebChromeClient.mm
WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
WebKit/win/ChangeLog
WebKit/win/WebCoreSupport/WebChromeClient.cpp
WebKit/wx/ChangeLog
WebKit/wx/WebKitSupport/ChromeClientWx.cpp

index cb8629b4f585bb20746aca306db7db1ed207186a..68ccca4e72c7c89732ca4c96584356704571444d 100644 (file)
@@ -1,3 +1,17 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+        Remove addToDirtyRegion.
+        
+        Reviewed by Oliver Hunt
+
+        * page/Chrome.cpp:
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        * platform/ScrollView.h:
+        * platform/gtk/ScrollViewGtk.cpp:
+        * platform/qt/ScrollViewQt.cpp:
+        * platform/win/ScrollViewWin.cpp:
+
 2008-10-03  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by Maciej Stachowiak.
index 13b43a9826e0777116bc3f71b742351e19a686a1..2a8bb24faa402d00a9a9acd149953169f94b54ef 100644 (file)
@@ -314,11 +314,6 @@ IntRect Chrome::windowResizerRect() const
     return m_client->windowResizerRect();
 }
 
-void Chrome::addToDirtyRegion(const IntRect& rect)
-{
-    m_client->addToDirtyRegion(rect);
-}
-
 void Chrome::mouseDidMoveOverElement(const HitTestResult& result, unsigned modifierFlags)
 {
     if (result.innerNode()) {
index 50063c6d5d7bac6ec7ca2ee6acaa247a62e5ec85..826d3c180e39b504497552a2f3d9a3e5dca17680 100644 (file)
@@ -104,7 +104,6 @@ namespace WebCore {
         bool shouldInterruptJavaScript();
 
         IntRect windowResizerRect() const;
-        void addToDirtyRegion(const IntRect&);
 
         void mouseDidMoveOverElement(const HitTestResult&, unsigned modifierFlags);
 
index 41b6ba092d04c9c17169cb4f951fdf7a5f1521ec..daec7d7f0189e88cb8cb08d9b52e99b46f7973f9 100644 (file)
@@ -109,9 +109,6 @@ namespace WebCore {
 
         virtual IntRect windowResizerRect() const = 0;
 
-        // This method is deprecated and will be removed once all of the callers have been eliminated.
-        virtual void addToDirtyRegion(const IntRect&) = 0;
-
         // Methods used by HostWindow.
         virtual void repaint(const IntRect&, bool contentChanged, bool immediate = false, bool repaintContentOnly = false) = 0;
         virtual void scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect) = 0;
index fd2be6acc93b14f2aed0c631a2d9ec0cb54a1a87..238ef3c54e30f4e021fb31df9710e42c03f84c65 100644 (file)
@@ -277,11 +277,6 @@ private:
     NSScrollView<WebCoreFrameScrollView>* scrollView() const;
 #endif
 
-#if !PLATFORM(MAC) && !PLATFORM(WX)
-public:
-    void addToDirtyRegion(const IntRect&);
-#endif
-
 #if PLATFORM(QT)
 private:
     bool rootPreventsBlitting() const { return root()->m_widgetsThatPreventBlitting > 0; }
index 5d2da0659ac89d44750692a75bf6b7a53e8e1469..233e469d44ba67fad55a056e83e1686d1837f58b 100644 (file)
 #include "ScrollView.h"
 
 #include "FloatRect.h"
-#include "FocusController.h"
-#include "Frame.h"
-#include "FrameView.h"
 #include "GraphicsContext.h"
 #include "HostWindow.h"
 #include "IntRect.h"
 #include "NotImplemented.h"
 #include "PlatformMouseEvent.h"
 #include "PlatformWheelEvent.h"
-#include "Page.h"
-#include "RenderLayer.h"
 #include "ScrollbarGtk.h"
 #include "ScrollbarTheme.h"
 
@@ -190,14 +185,4 @@ bool ScrollView::platformHasVerticalAdjustment() const
     return m_verticalAdjustment != 0;
 }
 
-void ScrollView::addToDirtyRegion(const IntRect& containingWindowRect)
-{
-    ASSERT(isFrameView());
-    const FrameView* frameView = static_cast<const FrameView*>(this);
-    Page* page = frameView->frame() ? frameView->frame()->page() : 0;
-    if (!page)
-        return;
-    page->chrome()->addToDirtyRegion(containingWindowRect);
-}
-
 }
index af1e7629dfd3795f8a759110fef7041bf7de78ad..e18743d3369a661cd3945c39d5f1279298f8f642 100644 (file)
 #include "config.h"
 #include "ScrollView.h"
 
-#include "FrameView.h"
-#include "FloatRect.h"
-#include "FocusController.h"
-#include "IntPoint.h"
-#include "PlatformMouseEvent.h"
-#include "PlatformWheelEvent.h"
-#include "NotImplemented.h"
-#include "Frame.h"
-#include "Page.h"
-#include "GraphicsContext.h"
-#include "Scrollbar.h"
-#include "ScrollbarTheme.h"
-
-#include <QDebug>
-#include <QWidget>
-#include <QPainter>
-#include <QApplication>
-#include <QPalette>
-#include <QStyleOption>
-
-#ifdef Q_WS_MAC
-#include <Carbon/Carbon.h>
-#endif
-
-#include "qwebframe.h"
-#include "qwebpage.h"
-
-// #define DEBUG_SCROLLVIEW
-
 namespace WebCore {
 
 ScrollView::ScrollView()
@@ -88,16 +59,6 @@ void ScrollView::platformRemoveChild(Widget* child)
     child->hide();
 }
 
-void ScrollView::addToDirtyRegion(const IntRect& containingWindowRect)
-{
-    ASSERT(isFrameView());
-    const FrameView* frameView = static_cast<const FrameView*>(this);
-    Page* page = frameView->frame() ? frameView->frame()->page() : 0;
-    if (!page)
-        return;
-    page->chrome()->addToDirtyRegion(containingWindowRect);
-}
-
 }
 
 // vim: ts=4 sw=4 et
index c0f7c088863a8354eb21ffe6063a10691e49a864..83b8064cd0defcc7008926c97d47271afb85ae49 100644 (file)
 #include "config.h"
 #include "ScrollView.h"
 
-#include "Chrome.h"
-#include "ChromeClient.h"
-#include "FloatRect.h"
-#include "FocusController.h"
-#include "Frame.h"
-#include "FrameView.h"
-#include "GraphicsContext.h"
-#include "IntRect.h"
-#include "NotImplemented.h"
-#include "Page.h"
-#include "Scrollbar.h"
-#include "PlatformMouseEvent.h"
-#include "PlatformWheelEvent.h"
-#include "RenderTheme.h"
-#include "Scrollbar.h"
-#include "ScrollbarClient.h"
-#include "ScrollbarTheme.h"
-#include "Settings.h"
-#include <algorithm>
-#include <winsock2.h>
-#include <windows.h>
-#include <wtf/Assertions.h>
-#include <wtf/HashSet.h>
-
 using namespace std;
 
 namespace WebCore {
@@ -72,14 +48,4 @@ void ScrollView::platformRemoveChild(Widget*)
 {
 }
 
-void ScrollView::addToDirtyRegion(const IntRect& containingWindowRect)
-{
-    ASSERT(isFrameView());
-    const FrameView* frameView = static_cast<const FrameView*>(this);
-    Page* page = frameView->frame() ? frameView->frame()->page() : 0;
-    if (!page)
-        return;
-    page->chrome()->addToDirtyRegion(containingWindowRect);
-}
-
 } // namespace WebCore
index e997ef69c5468757c9434308dbae9038da561bfe..230ed19655f068c57e46c8015868bcfe0b9f1dad 100644 (file)
@@ -1,3 +1,11 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+         Remove addToDirtyRegion.
+        
+        Reviewed by Oliver Hunt
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+
 2008-10-02  David Hyatt  <hyatt@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=21314
index 7235e762c17d6c93a0c556c615ce2e45a8b43fab..11397f22954df935c01fa687196a08147cf0d936 100644 (file)
@@ -292,11 +292,6 @@ IntPoint ChromeClient::screenToWindow(const IntPoint& point) const
     return point;
 }
 
-void ChromeClient::addToDirtyRegion(const IntRect&)
-{
-    notImplemented();
-}
-
 void ChromeClient::mouseDidMoveOverElement(const HitTestResult& hit, unsigned modifierFlags)
 {
     // check if the element is a link...
index feeae0c69a1e4548d8a8702edf3defe1c52570f5..53f2dc61f56e9412ddd58659ce624615f68f4afe 100644 (file)
@@ -1,3 +1,12 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+        Remove addToDirtyRegion.
+        
+        Reviewed by Oliver Hunt
+        
+        * WebCoreSupport/WebChromeClient.h:
+        * WebCoreSupport/WebChromeClient.mm:
+
 2008-10-02  David Hyatt  <hyatt@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=21328
index b89d50d4e47b1134120453652d6db888c0da97c5..edb2adc1f0345fbf7bdb05aca0b1ebccc24e84f5 100644 (file)
@@ -88,7 +88,6 @@ public:
     virtual bool tabsToLinks() const;
     
     virtual WebCore::IntRect windowResizerRect() const;
-    virtual void addToDirtyRegion(const WebCore::IntRect&);
 
     virtual void repaint(const WebCore::IntRect&, bool contentChanged, bool immediate = false, bool repaintContentOnly = false);
     virtual void scroll(const WebCore::IntSize& scrollDelta, const WebCore::IntRect& rectToScroll, const WebCore::IntRect& clipRect);
index 24cd6e11b924a4123738723c612b45d9d1d788ac..9f930fd9cc210ee01cfe48fbc16c4faf73b3b2cb 100644 (file)
@@ -423,10 +423,6 @@ IntRect WebChromeClient::windowToScreen(const IntRect& r) const
 }
 // End host window methods.
 
-void WebChromeClient::addToDirtyRegion(const IntRect&)
-{
-}
-
 void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& result, unsigned modifierFlags)
 {
     WebElementDictionary *element = [[WebElementDictionary alloc] initWithHitTestResult:result];
index 6d37a49dca0f97635ccc7c9983a587e2c8942110..6634f97b2b2204f3957faa2e77bbcd54a14b5e07 100644 (file)
@@ -1,3 +1,11 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+        Remove addToDirtyRegion.
+        
+        Reviewed by Oliver Hunt
+
+        * WebCoreSupport/ChromeClientQt.cpp:
+
 2008-10-02  David Hyatt  <hyatt@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=21314
index bc509839ad18438f314021a18dd26a057147db9e..48590d611df2c6ef395e1b43a2b64966dcd54e8c 100644 (file)
@@ -335,18 +335,6 @@ IntPoint ChromeClientQt::screenToWindow(const IntPoint& point) const
     return point;
 }
 
-void ChromeClientQt::addToDirtyRegion(const IntRect& r)
-{
-    QWidget* view = m_webPage->view();
-    if (view) {
-        QRect rect(r);
-        rect = rect.intersected(QRect(QPoint(0, 0), m_webPage->viewportSize()));
-        if (!r.isEmpty())
-            view->update(r);
-    } else
-        emit m_webPage->repaintRequested(r);
-}
-
 void ChromeClientQt::updateBackingStore()
 {
 }
index 0cb9ecefa89e12384f7f66e96574d99ef4ca9d54..4bdb6a9b2f36960870b07605cfe350ee8a972001 100644 (file)
@@ -1,3 +1,11 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+         Remove addToDirtyRegion.
+        
+         Reviewed by Oliver Hunt
+
+        * WebCoreSupport/WebChromeClient.cpp:
+
 2008-10-02  David Hyatt  <hyatt@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=21328
index 6a9d008031f4be60d0d2c58bd399d0115974e0af..e50e4e4138ce2a0736e5e626051d10dd71d78109 100644 (file)
@@ -459,11 +459,6 @@ IntPoint WebChromeClient::screenToWindow(const IntPoint& point) const
     return result;
 }
 
-void WebChromeClient::addToDirtyRegion(const IntRect& dirtyRect)
-{
-    m_webView->addToDirtyRegion(dirtyRect);
-}
-
 void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& result, unsigned modifierFlags)
 {
     COMPtr<IWebUIDelegate> uiDelegate;
index f7d7a6321dabd138f017797a70b1643beb74f57e..2c727594b2f4c9e435f637eb214ccf0650d5d2bd 100644 (file)
@@ -1,3 +1,11 @@
+2008-10-03  David Hyatt  <hyatt@apple.com>
+
+         Remove addToDirtyRegion.
+        
+         Reviewed by Oliver Hunt
+
+        * WebKitSupport/ChromeClientWx.cpp:
+
 2008-10-02  Kevin Ollivier  <kevino@theolliviers.com>
 
         wx build fixes after Frame/ScrollView changes.
index af31901ffc0b33768f2d928b2ab173eac2234569..668a2f639f70ad6668ae728ea94959cc775f6f8d 100644 (file)
@@ -300,11 +300,6 @@ IntPoint ChromeClientWx::screenToWindow(const IntPoint& point) const
     return point;
 }
 
-void ChromeClientWx::addToDirtyRegion(const IntRect&)
-{
-    notImplemented();
-}
-
 void ChromeClientWx::scrollBackingStore(int dx, int dy, 
                     const IntRect& scrollViewRect, 
                     const IntRect& clipRect)