2009-07-05 Xan Lopez <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26960
        [Gtk] caret offset not updated when selecting text

        Report the caret offset from the end of the selection so it works
        correctly for multi-char selections too (ie, anything that is not
        the zero width caret).

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_text_get_caret_offset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 275fd2eb10e81d78718740ae1920bec44863b9e1..f72785aaceba5bec4f050e68b2fd95cd6f2ebfa5 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2009-07-05  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Jan Alonzo.
+
+        https://bugs.webkit.org/show_bug.cgi?id=26960
+        [Gtk] caret offset not updated when selecting text
+
+        Report the caret offset from the end of the selection so it works
+        correctly for multi-char selections too (ie, anything that is not
+        the zero width caret).
+
+        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+        (webkit_accessible_text_get_caret_offset):
+
 2009-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>
 
         Unreviewed link fix for Qt.

diff --git a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
index 5636d17dc20f356fda764325452638d2cb1d5301..a0613b092ea4d0bc7f9e6be3310b2525153d8c65 100644 (file)
--- a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
+++ b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
@@ -559,7 +559,7 @@ static gunichar webkit_accessible_text_get_character_at_offset(AtkText* text, gi
 static gint webkit_accessible_text_get_caret_offset(AtkText* text)
 {
     // TODO: Verify this for RTL text.
-    return core(text)->selection().start().offsetInContainerNode();
+    return core(text)->selection().end().offsetInContainerNode();
 }
 
 static AtkAttributeSet* webkit_accessible_text_get_run_attributes(AtkText* text, gint offset, gint* start_offset, gint* end_offset)