https://bugs.webkit.org/show_bug.cgi?id=148775
Reviewed by Alexey Proskuryakov.
This patch adds (or rewrites) tests to take advantage of our new ability to mock
the system language for testing (https://bugs.webkit.org/show_bug.cgi?id=148671).
It tests these patches:
https://bugs.webkit.org/show_bug.cgi?id=148164
https://bugs.webkit.org/show_bug.cgi?id=147504
https://bugs.webkit.org/show_bug.cgi?id=147862
https://bugs.webkit.org/show_bug.cgi?id=147964
* fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine-expected.html.
* fast/text/international/system-language/arabic-glyph-cache-fill-combine.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine.html.
* fast/text/international/system-language/han-quotes-expected-mismatch.html: Added.
* fast/text/international/system-language/han-quotes.html: Added.
* fast/text/international/system-language/hindi-system-font-punctuation-expected.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation-expected.html.
* fast/text/international/system-language/hindi-system-font-punctuation.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation.html.
* fast/text/international/system-language/system-font-punctuation.html: Renamed from LayoutTests/fast/text/system-font-punctuation.html.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/text/system-font-punctuation-expected.txt.
* platform/mac/TestExpectations:
* platform/mac/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/mac/fast/text/system-font-punctuation-expected.txt.
* platform/win/TestExpectations:
* platform/win/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/win/fast/text/system-font-punctuation-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
+
+ [Cocoa] Add system-language-specific tests
+ https://bugs.webkit.org/show_bug.cgi?id=148775
+
+ Reviewed by Alexey Proskuryakov.
+
+ This patch adds (or rewrites) tests to take advantage of our new ability to mock
+ the system language for testing (https://bugs.webkit.org/show_bug.cgi?id=148671).
+
+ It tests these patches:
+ https://bugs.webkit.org/show_bug.cgi?id=148164
+ https://bugs.webkit.org/show_bug.cgi?id=147504
+ https://bugs.webkit.org/show_bug.cgi?id=147862
+ https://bugs.webkit.org/show_bug.cgi?id=147964
+
+ * fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine-expected.html.
+ * fast/text/international/system-language/arabic-glyph-cache-fill-combine.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine.html.
+ * fast/text/international/system-language/han-quotes-expected-mismatch.html: Added.
+ * fast/text/international/system-language/han-quotes.html: Added.
+ * fast/text/international/system-language/hindi-system-font-punctuation-expected.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation-expected.html.
+ * fast/text/international/system-language/hindi-system-font-punctuation.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation.html.
+ * fast/text/international/system-language/system-font-punctuation.html: Renamed from LayoutTests/fast/text/system-font-punctuation.html.
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/ios-simulator/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/text/system-font-punctuation-expected.txt.
+ * platform/mac/TestExpectations:
+ * platform/mac/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/mac/fast/text/system-font-punctuation-expected.txt.
+ * platform/win/TestExpectations:
+ * platform/win/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/win/fast/text/system-font-punctuation-expected.txt.
+
2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
[Cocoa] Allow testing with the system language
-<!DOCTYPE>
+<!DOCTYPE html><!-- webkit-test-runner [ language=ar ] -->
<html>
<body>
This test hits a codepath where codepoints were being combined before they were being input into our glyph cache.
This character occurs just before combining marks in Unicode, and therefore was being erroneously combined. The test
passes if the glyph is drawn in a font other than LastResort (if the test fails, the character looks like a box or like
three horizontal lines).
-<div style="font: 50px 'Geeza Pro';">ي</div>
+<div style="font: 50px 'Geeza Pro';">ي<div style="display: inline-block; width: 1px; height: 200px;"></div></div>
</body>
</html>
-<!DOCTYPE>
+<!DOCTYPE html><!-- webkit-test-runner [ language=ar ] -->
<html>
<body>
This test hits a codepath where codepoints were being combined before they were being input into our glyph cache.
This character occurs just before combining marks in Unicode, and therefore was being erroneously combined. The test
passes if the glyph is drawn in a font other than LastResort (if the test fails, the character looks like a box or like
three horizontal lines).
-<div style="font: 50px UICTFontTextStyleBody;">ي</div>
+<div style="font: 50px UICTFontTextStyleBody;">ي<div style="display: inline-block; width: 1px; height: 200px;"></div></div>
</body>
</html>
--- /dev/null
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<div style="font: 200px -apple-system;">“</div>
+</body>
+</html>
--- /dev/null
+<!DOCTYPE html><!-- webkit-test-runner [ language=zh-Hans ] -->
+<html>
+<head>
+</head>
+<body>
+<div style="font: 200px -apple-system;">“</div>
+</body>
+</html>
+<!DOCTYPE html><!-- webkit-test-runner [ language=hi ] -->
<html>
<body style="font-family: -apple-system; text-rendering: optimizeSpeed;">
This test makes sure that punctuation next to Hindi characters are rendered as expected when the system language is set to Japanese.
+<!DOCTYPE html><!-- webkit-test-runner [ language=hi ] -->
<html>
<body style="font-family: -apple-system; text-rendering: optimizeSpeed;">
This test makes sure that punctuation next to Hindi characters are rendered as expected when the system language is set to Japanese.
-<!DOCTYPE>
+<!DOCTYPE html><!-- webkit-test-runner [ language=zh-Hans ] -->
<html>
<body>
This test makes sure punctuation laid out with the system font does not use vertical glyphs. The test passes if the semicolon below looks like a regular horizontal semicolon (;) and is not sideways.
fast/text/fallback-language-han.html [ Skip ]
# This test relies on iOS-specific font fallback.
-fast/text/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
+fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
# This test uses an MPEG-4 video
media/video-seek-to-current-time.html [ Skip ]
fast/text/fallback-language-han.html [ Skip ]
# This test relies on iOS-specific font fallback.
-fast/text/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
+fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
# This test uses an MPEG-4 video
media/video-seek-to-current-time.html [ Skip ]
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
+layer at (0,0) size 800x118
+ RenderBlock {HTML} at (0,0) size 800x118
+ RenderBody {BODY} at (8,8) size 784x102
RenderBlock (anonymous) at (0,0) size 784x40
RenderText {#text} at (0,0) size 720x39
text run at (0,0) width 720: "This test makes sure punctuation laid out with the system font does not use vertical glyphs. The test passes if the"
webkit.org/b/147390 [ Mavericks Yosemite ElCapitan ] fast/text/fallback-language-han.html [ ImageOnlyFailure ]
# This test relies on iOS-specific font fallback.
-[ Mavericks Yosemite ElCapitan ] fast/text/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
+[ Mavericks Yosemite ElCapitan ] fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
# Started to fail after r188390
webkit.org/b/148042 http/tests/media/video-buffered-range-contains-currentTime.html [ Pass Failure ]
# Mocking the system language relies on Bootstrap XPC messages, which are not supported in Mavericks.
[ Mavericks ] fast/text/international/system-language [ Failure ]
+# Han quotes are not different on Mavericks nor Yosemite.
+[ Mavericks Yosemite ] fast/text/international/system-language/han-quotes.html [ ImageOnlyFailure ]
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
+layer at (0,0) size 800x111
+ RenderBlock {HTML} at (0,0) size 800x111
+ RenderBody {BODY} at (8,8) size 784x95
RenderBlock (anonymous) at (0,0) size 784x36
RenderText {#text} at (0,0) size 720x36
text run at (0,0) width 720: "This test makes sure punctuation laid out with the system font does not use vertical glyphs. The test passes if the"
fast/text/fallback-language-han.html [ Skip ]
# This test relies on iOS-specific font fallback.
-fast/text/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
+fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ ImageOnlyFailure ]
fast/ruby/ruby-expansion-cjk.html [ ImageOnlyFailure ]
fast/ruby/ruby-expansion-cjk-2.html [ ImageOnlyFailure ]
git://git.webkit.org / WebKit-https.git / commitdiff