Remove ChromeClient::fullScreenRendererChanged().
authorakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Jan 2014 03:22:05 +0000 (03:22 +0000)
committerakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Jan 2014 03:22:05 +0000 (03:22 +0000)
<https://webkit.org/b/126370>

This hook was added in r75277 to notify WebFullScreenController when
the full screen renderer changed. In r110216 the code was refactored,
making this notification unnecessary.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/dom/Document.cpp
Source/WebCore/page/ChromeClient.h
Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
Source/WebKit/mac/WebView/WebViewInternal.h

index 49ffb96ffd275e3514a1bf7e9e652bcc69df1a6e..bd3922f4031e11140e6887fc49fe544b9d7c8246 100644 (file)
@@ -1,3 +1,14 @@
+2014-01-01  Andreas Kling  <akling@apple.com>
+
+        Remove ChromeClient::fullScreenRendererChanged().
+        <https://webkit.org/b/126370>
+
+        This hook was added in r75277 to notify WebFullScreenController when
+        the full screen renderer changed. In r110216 the code was refactored,
+        making this notification unnecessary.
+
+        Reviewed by Antti Koivisto.
+
 2014-01-01  Simon Fraser  <simon.fraser@apple.com>
 
         Fix the build by exposing some more scrolling state node headers
index 280977343ad55001af6c8f683d2448c2910b6677..a792443a74d31bf288efb314dc2d6b105532bbd0 100644 (file)
@@ -5465,18 +5465,11 @@ void Document::setFullScreenRenderer(RenderFullScreen* renderer)
     ASSERT(!m_fullScreenRenderer);
 
     m_fullScreenRenderer = renderer;
-    
-    // This notification can come in after the page has been destroyed.
-    if (page())
-        page()->chrome().client().fullScreenRendererChanged(m_fullScreenRenderer);
 }
 
 void Document::fullScreenRendererDestroyed()
 {
     m_fullScreenRenderer = nullptr;
-
-    if (page())
-        page()->chrome().client().fullScreenRendererChanged(nullptr);
 }
 
 void Document::fullScreenChangeDelayTimerFired(Timer<Document>*)
index ba87c70522d84f9978364e81fa5530b85abe25fa..95f6ef8279986631ed79568199d8201839745d52 100644 (file)
@@ -335,7 +335,6 @@ public:
     virtual bool supportsFullScreenForElement(const Element*, bool) { return false; }
     virtual void enterFullScreenForElement(Element*) { }
     virtual void exitFullScreenForElement(Element*) { }
-    virtual void fullScreenRendererChanged(RenderBox*) { }
     virtual void setRootFullScreenLayer(GraphicsLayer*) { }
 #endif
 
index 7066cdb6e5f6f51e5c4f523617e789b4c2a2935c..de778d46bb2ccc504b5719abe6198ed4248aee39 100644 (file)
@@ -191,7 +191,6 @@ public:
     virtual bool supportsFullScreenForElement(const WebCore::Element*, bool withKeyboard) OVERRIDE;
     virtual void enterFullScreenForElement(WebCore::Element*) OVERRIDE;
     virtual void exitFullScreenForElement(WebCore::Element*) OVERRIDE;
-    virtual void fullScreenRendererChanged(WebCore::RenderBox*) OVERRIDE;
 #endif
 
     virtual bool selectItemWritingDirectionIsNatural() OVERRIDE;
index 745072220d7a43bb64ffbfe490b8aae2e6c40631..bee876a1ec7081e65eacc718ec7701de143aa73a 100644 (file)
@@ -1032,11 +1032,4 @@ void WebChromeClient::exitFullScreenForElement(Element* element)
 #endif
 }
 
-void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer)
-{
-    SEL selector = @selector(webView:fullScreenRendererChanged:);
-    if ([[m_webView UIDelegate] respondsToSelector:selector])
-        CallUIDelegate(m_webView, selector, (id)renderer);
-}
-
 #endif
index 9e690555027439e86c89cf8c82f1a4ee197632b8..5fdf5df0fbfc4f673bd54b666886e9b3661b5462 100644 (file)
@@ -245,7 +245,6 @@ OBJC_CLASS NSTextAlternatives;
 - (BOOL)_supportsFullScreenForElement:(WebCore::Element*)element withKeyboard:(BOOL)withKeyboard;
 - (void)_enterFullScreenForElement:(WebCore::Element*)element;
 - (void)_exitFullScreenForElement:(WebCore::Element*)element;
-- (void)_fullScreenRendererChanged:(WebCore::RenderBox*)renderer;
 #endif
 
 // Conversion functions between WebCore root view coordinates and web view coordinates.