Add an option to run the MotionMark tests with classic tile size (512x512)
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Aug 2016 18:45:17 +0000 (18:45 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Aug 2016 18:45:17 +0000 (18:45 +0000)
https://bugs.webkit.org/show_bug.cgi?id=160371

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-01
Reviewed by Darin Adler.

Setting the body to large size (3000x3000) and overflow to scroll forces
the classic tile size (512x512). This option does not affect the canvas
tests because the canvas is displayed on one tile regardless of its size.

* Animometer/developer.html:
* Animometer/resources/debug-runner/animometer.css:
(body.showing-test-container.tiles-big):
(body.showing-test-container.tiles-classic):
* Animometer/resources/debug-runner/animometer.js:
* Animometer/resources/runner/animometer.js:
(window.benchmarkController.startBenchmark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/Animometer/developer.html
PerformanceTests/Animometer/resources/debug-runner/animometer.css
PerformanceTests/Animometer/resources/debug-runner/animometer.js
PerformanceTests/Animometer/resources/runner/animometer.js
PerformanceTests/ChangeLog

index 1a33c7980551113ec0492e82153aa6943fcc0fcf..d7387a0e48b7603f7a013495fad0a010d4f46852 100644 (file)
                                         <li><label><input name="display" type="radio" value="progress-bar"> Progress bar</label></li>
                                     </ul>
                                 </li>
+                                <li>
+                                    <h3>Tiles:</h3>
+                                    <ul>
+                                        <li><label><input name="tiles" type="radio" value="big" checked> Big tiles</label></li>
+                                        <li><label><input name="tiles" type="radio" value="classic"> Classic tiles (512x512)</label></li>
+                                    </ul>
+                                </li>
                                 <li>
                                     <h3>Adjusting the test complexity:</h3>
                                     <ul>
index 3f08d49eb25399f7109ae1119a3efd29f2f73db2..7fbf31ee7d60a25840a913eae450a7a9e549eb4f 100644 (file)
@@ -350,6 +350,16 @@ label.tree-label {
     background-color: rgb(235, 96, 32);
 }
 
+body.showing-test-container.tiles-big {
+    overflow: hidden;
+}
+
+body.showing-test-container.tiles-classic {
+    width: 3000px;
+    height: 3000px;
+    overflow: scroll;
+}
+
 /* -------------------------------------------------------------------------- */
 /*                           Results Section                                  */
 /* -------------------------------------------------------------------------- */
index 5bd3c247668a99acdac3800a38fe748df6e6591b..d4e9790ad08c8dd203e829e95c437d4c86842b36 100644 (file)
@@ -216,6 +216,14 @@ window.optionsManager =
         document.body.classList.remove("display-progress-bar");
 
         document.body.classList.add("display-" + optionsManager.valueForOption("display"));
+    },
+    
+    updateTiles: function()
+    {
+        document.body.classList.remove("tiles-big");
+        document.body.classList.remove("tiles-classic");
+
+        document.body.classList.add("tiles-" + optionsManager.valueForOption("tiles"));
     }
 };
 
@@ -503,6 +511,7 @@ Utilities.extendObject(window.benchmarkController, {
         document.forms["complexity-graph-options"].addEventListener("change", benchmarkController.onComplexityGraphOptionsChanged, true);
         optionsManager.updateUIFromLocalStorage();
         optionsManager.updateDisplay();
+        optionsManager.updateTiles();
 
         if (benchmarkController.startBenchmarkImmediatelyIfEncoded())
             return;
@@ -556,12 +565,16 @@ Utilities.extendObject(window.benchmarkController, {
 
     onBenchmarkOptionsChanged: function(event)
     {
-        if (event.target.name == "controller") {
+        switch (event.target.name) {
+        case "controller":
             suitesManager.updateEditsElementsState();
-            return;
-        }
-        if (event.target.name == "display") {
+            break;
+        case "display":
             optionsManager.updateDisplay();
+            break;
+        case "tiles":
+            optionsManager.updateTiles();
+            break;
         }
     },
 
index 03a6ce705c6c87b01f7e963691dd8090e23aa80e..65e8c5450d7dd4138c82b62dc743cab8e3afc41e 100644 (file)
@@ -506,6 +506,7 @@ window.benchmarkController = {
         var options = {
             "test-interval": 30,
             "display": "minimal",
+            "tiles": "big",
             "controller": "ramp",
             "kalman-process-error": 1,
             "kalman-measurement-error": 4,
index 091c66bf6a40bc5dcf64f9ce97487bfbce694cd8..c879108180b35f61e85275c08035d20d751bf9a5 100644 (file)
@@ -1,3 +1,22 @@
+2016-08-01  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Add an option to run the MotionMark tests with classic tile size (512x512)
+        https://bugs.webkit.org/show_bug.cgi?id=160371
+
+        Reviewed by Darin Adler.
+
+        Setting the body to large size (3000x3000) and overflow to scroll forces
+        the classic tile size (512x512). This option does not affect the canvas
+        tests because the canvas is displayed on one tile regardless of its size.
+
+        * Animometer/developer.html:
+        * Animometer/resources/debug-runner/animometer.css:
+        (body.showing-test-container.tiles-big):
+        (body.showing-test-container.tiles-classic):
+        * Animometer/resources/debug-runner/animometer.js:
+        * Animometer/resources/runner/animometer.js:
+        (window.benchmarkController.startBenchmark):
+
 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
 
         Generators violate bytecode liveness validation