https://bugs.webkit.org/show_bug.cgi?id=49638
Patch by James Robinson <jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.
Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.
Test: fast/text/font-size-zero.html
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753
Reviewed by Adam Roben.
* WebKitPrefix.h:
WebKit2: Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755
Patch by Anders Carlsson <andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.
Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Add stub.
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidFail message.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.
(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.
* WebProcess/Downloads/Download.h:
(WebKit::Download::destinationID):
Call downloadID().
(WebKit::Download::downloadID):
Return the download ID.
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.
* WebProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.
* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.
(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.
* WebProcess/WebProcess.h:
WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753
Reviewed by Adam Roben.
* win/tools/vsprops/debug.vsprops:
* win/tools/vsprops/debug_internal.vsprops:
WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503
Patch by Daniel Bates <dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.
Fall back to existing support libraries (if present) when there is
no internet connection.
Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.
* Scripts/update-webkit-support-libs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
(WebCore::loadFullScreenRulesIfNeeded):
(WebCore::CSSStyleSelector::styleForElement):
+2010-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Debug_Internal Windows configuration is unnecessary, should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=49753
+
+ * WebCorePrefix.h:
+
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
#undef try
#undef catch
#endif
+
+2010-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Debug_Internal Windows configuration is unnecessary, should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=49753
+
+ * WebKitPrefix.h:
+
2010-11-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
#include <CoreFoundation/CoreFoundation.h>
#include <WebKit/WebKit.h>
-
* WebProcess/WebProcess.h:
+2010-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Debug_Internal Windows configuration is unnecessary, should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=49753
+
+ * UIProcess/Launcher/win/ProcessLauncherWin.cpp:
+ * WebKit2Prefix.h:
+
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
#include <shlwapi.h>
#include <wtf/text/WTFString.h>
-#if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
+#ifdef DEBUG_ALL
const LPCWSTR webProcessName = L"WebKit2WebProcess_debug.exe";
#else
const LPCWSTR webProcessName = L"WebKit2WebProcess.exe";
#endif
#endif /* defined(WIN32) || defined(_WIN32) */
+
+2010-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Debug_Internal Windows configuration is unnecessary, should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=49753
+
+ * win/tools/vsprops/debug.vsprops:
+ * win/tools/vsprops/debug_internal.vsprops:
+
2010-11-17 Steve Falkenburg <sfalken@apple.com>
Rubber-stamped by Adam Roben.
/>
<UserMacro
Name="WebKitConfigSuffix"
- Value="_debug"
+ Value=""
PerformEnvironmentSet="true"
/>
<UserMacro
Version="8.00"
Name="debug_internal"
>
- <Tool
- Name="VCCLCompilerTool"
- PreprocessorDefinitions="DEBUG_INTERNAL"
- />
- <UserMacro
- Name="WebKitConfigSuffix"
- Value=""
- PerformEnvironmentSet="true"
- />
- <UserMacro
- Name="LibraryConfigSuffix"
- Value=""
- PerformEnvironmentSet="true"
- />
- <UserMacro
- Name="WebKitDLLConfigSuffix"
- Value=""
- />
</VisualStudioPropertySheet>
* Scripts/update-webkit-support-libs:
+2010-11-18 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Adam Roben.
+
+ Debug_Internal Windows configuration is unnecessary, should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=49753
+
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ * MiniBrowser/win/stdafx.h:
+ * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
+ * WebKitTestRunner/win/TestControllerWin.cpp:
+
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
using namespace std;
-#if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
+#ifdef DEBUG_ALL
const LPWSTR TestPluginDir = L"TestNetscapePlugin_Debug";
#else
const LPWSTR TestPluginDir = L"TestNetscapePlugin";
#include <tchar.h>
#include <windows.h>
+
namespace TestWebKitAPI {
namespace Util {
-#if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
+#ifdef DEBUG_ALL
const char* injectedBundleDLL = "\\InjectedBundle_debug.dll";
#else
const char* injectedBundleDLL = "\\InjectedBundle.dll";
namespace WTR {
-#if !defined(NDEBUG) && (!defined(DEBUG_INTERNAL) || defined(DEBUG_ALL))
+#ifdef DEBUG_ALL
const LPWSTR testPluginDirectoryName = L"TestNetscapePlugin_Debug";
const char* injectedBundleDLL = "\\InjectedBundle_debug.dll";
#else
git://git.webkit.org / WebKit-https.git / commitdiff