Reviewed by levi
<rdar://problem/
4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
* editing/deleting/delete-after-span-ws-001-expected.checksum:
* editing/deleting/delete-after-span-ws-001-expected.png:
* editing/deleting/delete-after-span-ws-002-expected.checksum:
* editing/deleting/delete-after-span-ws-002-expected.png:
* editing/deleting/delete-after-span-ws-003-expected.checksum:
* editing/deleting/delete-after-span-ws-003-expected.png:
* editing/deleting/delete-block-merge-contents-010-expected.checksum:
* editing/deleting/delete-block-merge-contents-010-expected.png:
* editing/deleting/merge-unrendered-space-expected.checksum:
* editing/deleting/merge-unrendered-space-expected.png:
WebCore:
Reviewed by levi
<rdar://problem/
4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords
even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-07-11 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by levi
+
+ <rdar://problem/4620686>
+ REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
+
+ * editing/deleting/delete-after-span-ws-001-expected.checksum:
+ * editing/deleting/delete-after-span-ws-001-expected.png:
+ * editing/deleting/delete-after-span-ws-002-expected.checksum:
+ * editing/deleting/delete-after-span-ws-002-expected.png:
+ * editing/deleting/delete-after-span-ws-003-expected.checksum:
+ * editing/deleting/delete-after-span-ws-003-expected.png:
+ * editing/deleting/delete-block-merge-contents-010-expected.checksum:
+ * editing/deleting/delete-block-merge-contents-010-expected.png:
+ * editing/deleting/merge-unrendered-space-expected.checksum:
+ * editing/deleting/merge-unrendered-space-expected.png:
+
2006-07-11 Tim Omernick <timo@apple.com>
Reviewed by Geoff.
-fa737256f176829ea9cd740df331f0f4
\ No newline at end of file
+db707667cfcac13812fe2d5c45f08c34
\ No newline at end of file
-fa737256f176829ea9cd740df331f0f4
\ No newline at end of file
+db707667cfcac13812fe2d5c45f08c34
\ No newline at end of file
-fa737256f176829ea9cd740df331f0f4
\ No newline at end of file
+db707667cfcac13812fe2d5c45f08c34
\ No newline at end of file
-811ab335e3a2365bca81e09645759b09
\ No newline at end of file
+0f40969b8062d08c9d8499295b0f5e9c
\ No newline at end of file
-330385e63988b427faaae197a4a81494
\ No newline at end of file
+c211a9ce650e8735f492839a38d55eb3
\ No newline at end of file
+2006-07-11 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by levi
+
+ <rdar://problem/4620686>
+ REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word
+
+ * bridge/mac/FrameMac.mm:
+ (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords
+ even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.
+
+
2006-07-11 Tim Omernick <timo@apple.com>
Reviewed by NOBODY (build fix)
FAE04190097596C9000540BE /* SVGImageLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = FAE0418E097596C9000540BE /* SVGImageLoader.h */; };
/* End PBXBuildFile section */
+/* Begin PBXBuildStyle section */
+ D098D1C70A6490E100D1917D /* Development */ = {
+ isa = PBXBuildStyle;
+ buildSettings = {
+ COPY_PHASE_STRIP = NO;
+ };
+ name = Development;
+ };
+ D098D1C80A6490E100D1917D /* Deployment */ = {
+ isa = PBXBuildStyle;
+ buildSettings = {
+ COPY_PHASE_STRIP = YES;
+ };
+ name = Deployment;
+ };
+/* End PBXBuildStyle section */
+
/* Begin PBXContainerItemProxy section */
DD041FF009D9E3250010AF2A /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
0867D690FE84028FC02AAC07 /* Project object */ = {
isa = PBXProject;
buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
+ buildSettings = {
+ };
+ buildStyles = (
+ D098D1C70A6490E100D1917D /* Development */,
+ D098D1C80A6490E100D1917D /* Deployment */,
+ );
hasScannedForEncodings = 1;
knownRegions = (
English,
VisiblePosition newStart(selection().start(), selection().affinity());
SelectionController newAdjacentWords(startOfWord(newStart, LeftWordIfOnBoundary), endOfWord(newStart, RightWordIfOnBoundary));
- if (oldAdjacentWords != newAdjacentWords) {
- // Mark misspellings in the portion that was previously unmarked because of
- // the proximity of the start of the selection. We only spell check words in
- // the vicinity of the start of the old selection because the spelling checker
- // is not fast enough to do a lot of spelling checking implicitly. This matches
- // AppKit. This function is really the only code that knows that rule. The
- // markMisspellings function is prepared to handler larger ranges.
-
- // When typing we check spelling elsewhere, so don't redo it here.
- if (closeTyping)
- markMisspellings(oldAdjacentWords);
-
- // This only erases a marker in the first word of the selection.
- // Perhaps peculiar, but it matches AppKit.
- document()->removeMarkers(newAdjacentWords.toRange().get(), DocumentMarker::Spelling);
- }
+ // When typing we check spelling elsewhere, so don't redo it here.
+ if (closeTyping && oldAdjacentWords != newAdjacentWords)
+ markMisspellings(oldAdjacentWords);
+
+ // This only erases a marker in the first word of the selection.
+ // Perhaps peculiar, but it matches AppKit.
+ document()->removeMarkers(newAdjacentWords.toRange().get(), DocumentMarker::Spelling);
} else
// When continuous spell checking is off, no markers appear after the selection changes.
document()->removeMarkers(DocumentMarker::Spelling);
git://git.webkit.org / WebKit-https.git / commitdiff
