git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6e3c49e)
Fix by Mitz Pettel, reviewed by Darin.
authorap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Jul 2006 16:21:36 +0000 (16:21 +0000)
committerap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Jul 2006 16:21:36 +0000 (16:21 +0000)
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10075
          REGRESSION: Reversed pop-up text in visually-ordered Hebrew pages

        Test: fast/forms/select-visual-hebrew.html

        * css/html4.css: Set "-webkit-rtl-ordering: logical" on select elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/fast/forms/select-visual-hebrew-expected.checksum [new file with mode: 0644] patch | blob
LayoutTests/fast/forms/select-visual-hebrew-expected.png [new file with mode: 0644] patch | blob
LayoutTests/fast/forms/select-visual-hebrew-expected.txt [new file with mode: 0644] patch | blob
LayoutTests/fast/forms/select-visual-hebrew.html [new file with mode: 0644] patch | blob
WebCore/css/html4.css patch | blob | history

diff --git a/LayoutTests/fast/forms/select-visual-hebrew-expected.checksum b/LayoutTests/fast/forms/select-visual-hebrew-expected.checksum
new file mode 100644 (file)
index 0000000..dadc77d
--- /dev/null
+++ b/LayoutTests/fast/forms/select-visual-hebrew-expected.checksum
@@ -0,0 +1 @@
+d7dee6a480b830b4fb66a7f853781604
\ No newline at end of file
diff --git a/LayoutTests/fast/forms/select-visual-hebrew-expected.png b/LayoutTests/fast/forms/select-visual-hebrew-expected.png
new file mode 100644 (file)
index 0000000..c8322eb
Binary files /dev/null and b/LayoutTests/fast/forms/select-visual-hebrew-expected.png differ
diff --git a/LayoutTests/fast/forms/select-visual-hebrew-expected.txt b/LayoutTests/fast/forms/select-visual-hebrew-expected.txt
new file mode 100644 (file)
index 0000000..4ce97d6
--- /dev/null
+++ b/LayoutTests/fast/forms/select-visual-hebrew-expected.txt
@@ -0,0 +1,21 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderBlock {P} at (0,0) size 784x18
+        RenderText {#text} at (0,0) size 619x18
+          text run at (0,0) width 619 LTR override: "This tests that native pop-ups are rendered in logical order even in visually-ordered Hebrew pages."
+      RenderBlock {HR} at (0,34) size 784x2 [border: (1px inset #000000)]
+      RenderBlock {P} at (0,52) size 784x18
+        RenderText {#text} at (0,0) size 391x18
+          text run at (0,0) width 348 LTR override: "Text on the pop-up and in the list should look like this: "
+          text run at (348,0) width 43 LTR override: "\x{5E8}\x{5D5}\x{5EA}\x{5E4}\x{5DB}"
+      RenderBlock (anonymous) at (0,86) size 784x22
+        RenderMenuList {SELECT} at (2,2) size 61x18
+          RenderBlock (anonymous) at (8,2) size 30x13
+            RenderText at (0,0) size 30x13
+              text run at (0,0) width 30 RTL: "\x{5DB}\x{5E4}\x{5EA}\x{5D5}\x{5E8}"
+        RenderText {#text} at (0,0) size 0x0
+        RenderText {#text} at (0,0) size 0x0
+        RenderText {#text} at (0,0) size 0x0
diff --git a/LayoutTests/fast/forms/select-visual-hebrew.html b/LayoutTests/fast/forms/select-visual-hebrew.html
new file mode 100644 (file)
index 0000000..a9446f5
--- /dev/null
+++ b/LayoutTests/fast/forms/select-visual-hebrew.html
@@ -0,0 +1,14 @@
+<html>
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-8">
+<title>-khtml-rtl-ordering</title>
+</head>
+<body>
+<p>
+This tests that native pop-ups are rendered in logical order even in visually-ordered Hebrew pages.
+</p>
+<hr>
+<p>Text on the pop-up and in the list should look like this: øåúôë</p>
+<select><option>ëôúåø</option></select>
+</body>
+</html>
diff --git a/WebCore/css/html4.css b/WebCore/css/html4.css
index 653ec90f361a41fbf376e400e4521a7bdc9c4cd1..14d4969238d0748d1fe91745c8c465b2f480fa4e 100644 (file)
--- a/WebCore/css/html4.css
+++ b/WebCore/css/html4.css
@@ -402,6 +402,7 @@ select {
     -webkit-appearance: menulist;
     box-sizing: border-box;
     -webkit-box-align: center;
+    -webkit-rtl-ordering: logical;
 }
 
 select[size],
Mirror of the WebKit open source project from svn.webkit.org.