REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails

https://bugs.webkit.org/show_bug.cgi?id=116516

Reviewed by Alexey Proskuryakov.

Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Match the ordering.
(resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 1f6e58ecfa77befeeb3812f41b8be536575fe930..818370305654d7a2a4fb4c4e9926ba279dac1ffd 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,16 @@
+2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=116516
+
+        Reviewed by Alexey Proskuryakov.
+
+        Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (createWebViewAndOffscreenWindow): Match the ordering.
+        (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
+
 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
 
         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit

diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
index 3b53a297ee809ee462f8070f140d4b1fadfdaf6f..026b2b9336a656ebdfa4a9854535ccb9c8caca68 100644 (file)
--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
@@ -544,8 +544,9 @@ WebView *createWebViewAndOffscreenWindow()
     [webView setAutomaticDashSubstitutionEnabled:NO];
     [webView setAutomaticTextReplacementEnabled:NO];
     [webView setAutomaticSpellingCorrectionEnabled:YES];
-    [webView setDefersCallbacks:NO];
     [webView setGrammarCheckingEnabled:YES];
+
+    [webView setDefersCallbacks:NO];
     [webView setInteractiveFormValidationEnabled:YES];
     [webView setValidationMessageTimerMagnification:-1];
     
@@ -1290,6 +1291,14 @@ static void resetWebViewToConsistentStateBeforeTesting()
         gTestRunner->removeChromeInputField();
     }
 
+    [webView setContinuousSpellCheckingEnabled:YES];
+    [webView setAutomaticQuoteSubstitutionEnabled:NO];
+    [webView setAutomaticLinkDetectionEnabled:NO];
+    [webView setAutomaticDashSubstitutionEnabled:NO];
+    [webView setAutomaticTextReplacementEnabled:NO];
+    [webView setAutomaticSpellingCorrectionEnabled:YES];
+    [webView setGrammarCheckingEnabled:YES];
+
     [WebView _setUsesTestModeFocusRingColor:YES];
     [WebView _resetOriginAccessWhitelists];
     [WebView _setAllowsRoundingHacks:NO];