REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Apr 2015 18:02:30 +0000 (18:02 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Apr 2015 18:02:30 +0000 (18:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=144150

Reviewed by Brian Burg.

Source/WebInspectorUI:

* UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
checking enabled to isCapturing().

Source/WebKit2:

* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::evaluateCommandOnLoad): Properly treat bools as literals
instead of strings by not using the string version of evaluateCommandOnLoad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp

index ac7c13e1d068d67ca6cfc78f2d881fa969ab184c..074c99f609f8e454a711884b75e0e53645136096 100644 (file)
@@ -1,3 +1,14 @@
+2015-04-24  Timothy Hatcher  <timothy@apple.com>
+
+        REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
+        https://bugs.webkit.org/show_bug.cgi?id=144150
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Protocol/InspectorFrontendAPI.js:
+        (InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
+        checking enabled to isCapturing().
+
 2015-04-23  Brian J. Burg  <burg@cs.washington.edu>
 
         Web Inspector: run a customizable bootstrap function after the UI has fully loaded
index c4c669652f1d20b401c3982207ca2852f54a39a2..fc7efcfd6a5ee1b52950d90174936863f55ade5a 100644 (file)
@@ -44,7 +44,7 @@ InspectorFrontendAPI = {
 
     setTimelineProfilingEnabled: function(enabled)
     {
-        if (WebInspector.timelineManager.isCapturing() !== enabled)
+        if (WebInspector.timelineManager.isCapturing() === enabled)
             return;
 
         if (enabled) {
index 153aa4f2298dc8b3818eaee0aa1006b6a6f222e4..4c166bf6a397cc21cc05fb634620185a2b992227 100644 (file)
@@ -1,3 +1,14 @@
+2015-04-24  Timothy Hatcher  <timothy@apple.com>
+
+        REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
+        https://bugs.webkit.org/show_bug.cgi?id=144150
+
+        Reviewed by Brian Burg.
+
+        * WebProcess/WebPage/WebInspectorUI.cpp:
+        (WebKit::WebInspectorUI::evaluateCommandOnLoad): Properly treat bools as literals
+        instead of strings by not using the string version of evaluateCommandOnLoad.
+
 2015-04-23  Anders Carlsson  <andersca@apple.com>
 
         Add headerdocs for WKWebsiteDataRecord and WKWebsiteDataStore
index ded3699bc425aecb4ea4aa3f92b4130050486d61..550df726dcd4a9443e5cd587ee2381c64cb2eeb3 100644 (file)
@@ -256,7 +256,7 @@ void WebInspectorUI::evaluateCommandOnLoad(const String& command, const String&
 
 void WebInspectorUI::evaluateCommandOnLoad(const String& command, bool argument)
 {
-    evaluateCommandOnLoad(command, ASCIILiteral(argument ? "true" : "false"));
+    evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])"));
 }
 
 void WebInspectorUI::evaluateExpressionOnLoad(const String& expression)