Fix for 4097842, changing 1st line of a url that wraps doesn't update the second...

	update line break info for the last dirty line so that when a clean line tries to figure out where it
	started, it will get an accurate position taking into account the updated string.  By doing this, the code
	will be able to properly distinguish between the old and new positions and not accidentally assume they are
	the same.

        Reviewed by darin

        * khtml/rendering/render_text.cpp:
        (RenderText::setTextWithOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 480ae7cb5cda48dc8bf65ee40a883a4de392defa..8819fa9e583d78ad362604cac6ac0f0ca1be0d01 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,16 @@
+2005-04-25  David Hyatt  <hyatt@apple.com>
+
+       Fix for 4097842, changing 1st line of a url that wraps doesn't update the second line.  Make sure to
+       update line break info for the last dirty line so that when a clean line tries to figure out where it
+       started, it will get an accurate position taking into account the updated string.  By doing this, the code
+       will be able to properly distinguish between the old and new positions and not accidentally assume they are
+       the same.
+       
+        Reviewed by darin
+
+        * khtml/rendering/render_text.cpp:
+        (RenderText::setTextWithOffset):
+
 2005-04-26  Darin Adler  <darin@apple.com>
 
         Reviewed by Maciej.

diff --git a/WebCore/khtml/rendering/render_text.cpp b/WebCore/khtml/rendering/render_text.cpp
index 778e5758df1c60abe2562861daf252d0a275129b..396b88ffe27c46b54084a44b01e9e96d10131031 100644 (file)
--- a/WebCore/khtml/rendering/render_text.cpp
+++ b/WebCore/khtml/rendering/render_text.cpp
@@ -1540,7 +1540,7 @@ void RenderText::setTextWithOffset(DOMStringImpl *text, uint offset, uint len, b
             firstRootBox = prev;
     }
     for (RootInlineBox* curr = firstRootBox; curr && curr != lastRootBox; curr = curr->nextRootBox()) {
-        if (!curr->isDirty() && curr->lineBreakObj() == this && curr->lineBreakPos() > end)
+        if (curr->lineBreakObj() == this && curr->lineBreakPos() > end)
             curr->setLineBreakPos(curr->lineBreakPos()+delta);
     }