Reviewed by Darin.
authorharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 May 2005 20:39:16 +0000 (20:39 +0000)
committerharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 May 2005 20:39:16 +0000 (20:39 +0000)
Prevent crash when going from no selection to selection with mispelling checks enabled.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::markMisspellings):
        Repair check for null searchRange.  Was inadvertently broken in recent checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQKHTMLPart.mm

index fef904f7b6bf47a0dd56fde4455cd195efd563c1..d6286609729c53d82c2916631146391224dfb10d 100644 (file)
@@ -1,3 +1,13 @@
+2005-05-23  David Harrison  <harrison@apple.com>
+
+        Reviewed by Darin.
+
+               Prevent crash when going from no selection to selection with mispelling checks enabled.
+               
+        * kwq/KWQKHTMLPart.mm:
+        (KWQKHTMLPart::markMisspellings):
+        Repair check for null searchRange.  Was inadvertently broken in recent checkin.
+
 2005-05-23  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Dave Hyatt.
index 408d5c56947942fda74f8ecf994bc096655b3469..30e6f5520239e67381bab8e4dd866ad8b0f8f951 100644 (file)
@@ -4000,7 +4000,7 @@ void KWQKHTMLPart::markMisspellings(const Selection &selection)
         return;
 
     SharedPtr<RangeImpl> searchRange(selection.toRange());
-    if (searchRange.get() || searchRange->isDetached())
+    if (searchRange.isNull() || searchRange->isDetached())
         return;
     
     // If we're not in an editable node, bail.