- patch from Adam Treat to implement frameLoadCompleted()
authorstaikos <staikos@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 May 2007 06:32:08 +0000 (06:32 +0000)
committerstaikos <staikos@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 May 2007 06:32:08 +0000 (06:32 +0000)
- build fix from George Staikos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitQt/ChangeLog
WebKitQt/WebCoreSupport/FrameLoaderClientQt.cpp

index 27f848caa701216b3d3f996d972f87ecb0f95fe7..fc5288ec6ca22d485fa8b1174fa04fa804acc789 100644 (file)
@@ -1,3 +1,14 @@
+2007-05-17  Adam Treat <adam@staikos.net>
+
+        Reviewed by George Staikos.
+
+        - Implement frameLoadCompleted
+        - Fix build (by George)
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore::FrameLoaderClientQt::frameLoadCompleted):
+        (WebCore::FrameLoaderClientQt::createFrame):
+
 2007-05-17  Adam Treat  <adam@staikos.net>
 
         Reviewed by George Staikos.
index 6f200b577f7a1253114383bbfc5fc04a4ed1f798..36c58c8fc4fe4ba292a9e7ad91fb472293471470 100644 (file)
@@ -37,6 +37,8 @@
 #include "Page.h"
 #include "ProgressTracker.h"
 #include "ResourceRequest.h"
+#include "HistoryItem.h"
+#include "HTMLFormElement.h"
 
 #include "qwebpage.h"
 #include "qwebframe.h"
@@ -523,7 +525,10 @@ String FrameLoaderClientQt::generatedMIMETypeForURLScheme(const String& URLSchem
 
 void FrameLoaderClientQt::frameLoadCompleted()
 {
-    notImplemented();
+    // Note: Can be called multiple times.
+    // Even if already complete, we might have set a previous item on a frame that
+    // didn't do any data loading on the past transaction. Make sure to clear these out.
+    m_frame->loader()->setPreviousHistoryItem(0);
 }
 
 
@@ -855,7 +860,7 @@ Frame* FrameLoaderClientQt::createFrame(const KURL& url, const String& name, HTM
     FrameLoadType childLoadType = FrameLoadTypeInternal;
 
     childFrame->loader()->load(frameData.url, frameData.referrer, childLoadType,
-                             String(), 0, 0, WTF::HashMap<String, String>());
+                             String(), 0, 0);
 
     // The frame's onload handler may have removed it from the document.
     if (!childFrame->tree()->parent())