Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* features.pri:
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* Api/qwebkitplatformplugin.h:
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/FullScreenVideoQt.h:
* WebCoreSupport/QtPlatformPlugin.cpp:
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
* examples/platformplugin/platformplugin.pro:
* examples/platformplugin/qwebkitplatformplugin.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadHtml5Video):
* tests/tests.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
+ https://bugs.webkit.org/show_bug.cgi?id=57974
+
+ We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
+
+ No new tests needed, just a config flag rename.
+
+ * features.pri:
+
2011-04-06 Tyler Close <tjclose@chromium.org>
Reviewed by Nate Chapin.
contains(DEFINES, USE_GSTREAMER=1) {
DEFINES -= ENABLE_VIDEO=0
DEFINES += ENABLE_VIDEO=1
- DEFINES -= ENABLE_QT_MULTIMEDIA=1
- DEFINES += ENABLE_QT_MULTIMEDIA=0
+ DEFINES -= WTF_USE_QT_MULTIMEDIA=1
+ DEFINES += WTF_USE_QT_MULTIMEDIA=0
} else:contains(MOBILITY_CONFIG, multimedia) {
DEFINES -= ENABLE_VIDEO=0
DEFINES += ENABLE_VIDEO=1
- DEFINES -= ENABLE_QT_MULTIMEDIA=0
- DEFINES += ENABLE_QT_MULTIMEDIA=1
+ DEFINES -= WTF_USE_QT_MULTIMEDIA=0
+ DEFINES += WTF_USE_QT_MULTIMEDIA=1
} else:contains(QT_CONFIG, phonon) {
DEFINES -= ENABLE_VIDEO=0
DEFINES += ENABLE_VIDEO=1
- DEFINES -= ENABLE_QT_MULTIMEDIA=1
- DEFINES += ENABLE_QT_MULTIMEDIA=0
+ DEFINES -= WTF_USE_QT_MULTIMEDIA=1
+ DEFINES += WTF_USE_QT_MULTIMEDIA=0
}
}
#include <QColor>
#include <QObject>
#include <QUrl>
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
#include <QMediaPlayer>
#endif
virtual unsigned hitTestPaddingForTouch(const PaddingDirection) const = 0;
};
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
class QWebFullScreenVideoHandler : public QObject {
Q_OBJECT
public:
+2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
+ https://bugs.webkit.org/show_bug.cgi?id=57974
+
+ We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
+
+ No new tests needed, just a config flag rename.
+
+ * Api/qwebkitplatformplugin.h:
+ * WebCoreSupport/ChromeClientQt.cpp:
+ * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+ (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
+ * WebCoreSupport/FullScreenVideoQt.cpp:
+ (WebCore::FullScreenVideoQt::FullScreenVideoQt):
+ (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
+ (WebCore::FullScreenVideoQt::enterFullScreenForNode):
+ (WebCore::FullScreenVideoQt::exitFullScreenForNode):
+ (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
+ (WebCore::FullScreenVideoQt::isValid):
+ * WebCoreSupport/FullScreenVideoQt.h:
+ * WebCoreSupport/QtPlatformPlugin.cpp:
+ * WebCoreSupport/QtPlatformPlugin.h:
+ * examples/platformplugin/WebPlugin.cpp:
+ (WebPlugin::supportsExtension):
+ (WebPlugin::createExtension):
+ * examples/platformplugin/WebPlugin.h:
+ * examples/platformplugin/platformplugin.pro:
+ * examples/platformplugin/qwebkitplatformplugin.h:
+ * tests/qwebpage/tst_qwebpage.cpp:
+ (tst_QWebPage::loadHtml5Video):
+ * tests/tests.pri:
+
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
#include "HTMLMediaElement.h"
#include "HTMLNames.h"
#include "HTMLVideoElement.h"
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
#include "MediaPlayerPrivateQt.h"
#endif
#endif
#include "qwebpage_p.h"
#include "qwebscriptworld.h"
-#if ENABLE(VIDEO) && ENABLE(QT_MULTIMEDIA)
+#if ENABLE(VIDEO) && USE(QT_MULTIMEDIA)
#include "HTMLVideoElement.h"
#include "MediaPlayerPrivateQt.h"
#endif
{
QUrl res;
-#if ENABLE(VIDEO) && ENABLE(QT_MULTIMEDIA)
+#if ENABLE(VIDEO) && USE(QT_MULTIMEDIA)
Frame* coreFrame = QWebFramePrivate::core(frame);
if (!coreFrame)
return res;
#include "FullScreenVideoQt.h"
#include "ChromeClientQt.h"
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
#include "FullScreenVideoWidget.h"
#include "MediaPlayerPrivateQt.h"
#endif
#include "PlatformVideoWindowPrivate.h"
#endif
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
#include <QGraphicsVideoItem>
#include <QMediaPlayer>
#endif
}
#endif
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
bool DefaultFullScreenVideoHandler::s_shouldForceFullScreenVideoPlayback = false;
DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler()
{
Q_ASSERT(m_chromeClient);
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
m_FullScreenVideoHandler = m_chromeClient->m_platformPlugin.createFullScreenVideoHandler();
if (!m_FullScreenVideoHandler)
m_FullScreenVideoHandler = new DefaultFullScreenVideoHandler;
FullScreenVideoQt::~FullScreenVideoQt()
{
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
delete m_FullScreenVideoHandler;
#endif
#if USE(GSTREAMER)
m_videoElement = static_cast<HTMLVideoElement*>(node);
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
HTMLVideoElement* videoElement = static_cast<HTMLVideoElement*>(node);
PlatformMedia platformMedia = videoElement->platformMedia();
{
Q_ASSERT(node);
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
HTMLVideoElement* videoElement = static_cast<HTMLVideoElement*>(node);
PlatformMedia platformMedia = videoElement->platformMedia();
m_videoElement->exitFullscreen();
}
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
MediaPlayerPrivateQt* FullScreenVideoQt::mediaPlayer()
{
Q_ASSERT(m_videoElement);
bool FullScreenVideoQt::requiresFullScreenForVideoPlayback()
{
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
return m_FullScreenVideoHandler ? m_FullScreenVideoHandler->requiresFullScreenForVideoPlayback() : false;
#endif
#if USE(GSTREAMER)
bool FullScreenVideoQt::isValid() const
{
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
return m_FullScreenVideoHandler;
#endif
#if USE(GSTREAMER)
class FullScreenVideoWidget;
class HTMLVideoElement;
class Node;
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
class MediaPlayerPrivateQt;
#endif
#endif
// We do not use ENABLE or USE because moc does not expand these macros.
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
class DefaultFullScreenVideoHandler : public QWebFullScreenVideoHandler {
Q_OBJECT
public:
bool isValid() const;
private:
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
MediaPlayerPrivateQt* mediaPlayer();
#endif
private:
ChromeClientQt* m_chromeClient;
HTMLVideoElement* m_videoElement;
-#if ENABLE(QT_MULTIMEDIA)
+#if USE(QT_MULTIMEDIA)
QWebFullScreenVideoHandler* m_FullScreenVideoHandler;
#endif
#if USE(GSTREAMER)
return p ? static_cast<QWebTouchModifier*>(p->createExtension(QWebKitPlatformPlugin::TouchInteraction)) : 0;
}
-#if ENABLE(VIDEO) && ENABLE(QT_MULTIMEDIA)
+#if ENABLE(VIDEO) && USE(QT_MULTIMEDIA)
QWebFullScreenVideoHandler* QtPlatformPlugin::createFullScreenVideoHandler()
{
QWebKitPlatformPlugin* p = plugin();
class QWebHapticFeedbackPlayer;
class QWebSelectData;
class QWebTouchModifier;
-#if ENABLE(VIDEO) && ENABLE(QT_MULTIMEDIA)
+#if ENABLE(VIDEO) && USE(QT_MULTIMEDIA)
class QWebFullScreenVideoHandler;
#endif
QWebNotificationPresenter* createNotificationPresenter();
QWebHapticFeedbackPlayer* createHapticFeedbackPlayer();
QWebTouchModifier* createTouchModifier();
-#if ENABLE(VIDEO) && ENABLE(QT_MULTIMEDIA)
+#if ENABLE(VIDEO) && USE(QT_MULTIMEDIA)
QWebFullScreenVideoHandler* createFullScreenVideoHandler();
#endif
resize(size().width(), visibleItemCount * gMaemoListItemSize);
}
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
FullScreenVideoWidget::FullScreenVideoWidget(QMediaPlayer* player)
: QVideoWidget()
, m_mediaPlayer(player)
#endif
case TouchInteraction:
return true;
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
case FullScreenVideoPlayer:
return true;
#endif
#endif
case TouchInteraction:
return new TouchModifier();
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
case FullScreenVideoPlayer:
return new FullScreenVideoHandler();
#endif
#include "WebNotificationPresenter.h"
#include <QDialog>
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
#include <QVideoWidget>
#endif
}
};
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
class FullScreenVideoWidget : public QVideoWidget {
Q_OBJECT
public:
MOBILITY += multimedia
DEFINES -= ENABLE_VIDEO=0
DEFINES += ENABLE_VIDEO=1
- DEFINES -= ENABLE_QT_MULTIMEDIA=0
- DEFINES += ENABLE_QT_MULTIMEDIA=1
+ DEFINES -= WTF_USE_QT_MULTIMEDIA=0
+ DEFINES += WTF_USE_QT_MULTIMEDIA=1
}
}
#include <QObject>
#include <QUrl>
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
#include <QMediaPlayer>
#endif
virtual unsigned hitTestPaddingForTouch(const PaddingDirection) const = 0;
};
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
class QWebFullScreenVideoHandler : public QObject {
Q_OBJECT
public:
void tst_QWebPage::loadHtml5Video()
{
-#if defined(ENABLE_QT_MULTIMEDIA) && ENABLE_QT_MULTIMEDIA
+#if defined(WTF_USE_QT_MULTIMEDIA) && WTF_USE_QT_MULTIMEDIA
QByteArray url("http://does.not/exist?a=1%2Cb=2");
m_view->setHtml("<p><video id ='video' src='" + url + "' autoplay/></p>");
QTest::qWait(2000);
load(mobilityconfig, true)
contains(MOBILITY_CONFIG, multimedia) {
# This define is used by tests depending on Qt Multimedia
- DEFINES -= ENABLE_QT_MULTIMEDIA=0
- DEFINES += ENABLE_QT_MULTIMEDIA=1
+ DEFINES -= WTF_USE_QT_MULTIMEDIA=0
+ DEFINES += WTF_USE_QT_MULTIMEDIA=1
}
SOURCES += $${TARGET}.cpp