Unreviewed follow-up to r216776.
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 20:37:46 +0000 (20:37 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 20:37:46 +0000 (20:37 +0000)
* Scripts/webkitpy/port/base.py:
(Port.path_to_crash_logs): Raise not implemented.
* Scripts/webkitpy/port/test.py:
(TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
* Scripts/webkitpy/port/win.py:
(WinPort.path_to_crash_logs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/base.py
Tools/Scripts/webkitpy/port/test.py
Tools/Scripts/webkitpy/port/win.py

index 55b9d2bbb5a0229603d515ddb436f88e383c881a..6408b883482c60c7a7ead9c7d7ec6b744a032e61 100644 (file)
@@ -1,3 +1,14 @@
+2017-05-12  Jonathan Bedard  <jbedard@apple.com>
+
+        Unreviewed follow-up to r216776.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.path_to_crash_logs): Raise not implemented.
+        * Scripts/webkitpy/port/test.py:
+        (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
+        * Scripts/webkitpy/port/win.py:
+        (WinPort.path_to_crash_logs): Ditto.
+
 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
 
         Bot watcher's dashboard shows results links twice sometimes
index d819ba20a3ff65a0950ba26ee0726486dc8e40dc..f4804804ced2e6e87b10f9dec455b1f616db3940 100644 (file)
@@ -1348,7 +1348,7 @@ class Port(object):
         return driver.Driver
 
     def path_to_crash_logs(self):
-        return self.results_directory()
+        raise NotImplementedError
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
         name_str = name or '<unknown process name>'
index 2168cfea6fdfc30437dbcc7d2583720e31039ca5..929a403aeb6f988705502c1da127afaa1907a278 100644 (file)
@@ -463,6 +463,9 @@ class TestPort(Port):
     def _driver_class(self):
         return TestDriver
 
+    def path_to_crash_logs(self):
+        return self.results_directory()
+
     def start_http_server(self, additional_dirs=None):
         pass
 
index 31dcec4b40e5754850d46022956bfe0a3a6bd30d..8769c26c6e75f977bd76694aea6a4f33f2af4f20 100644 (file)
@@ -369,6 +369,9 @@ class WinPort(ApplePort):
         self.restore_crash_log_saving()
         super(WinPort, self).clean_up_test_run()
 
+    def path_to_crash_logs(self):
+        return self.results_directory()
+
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True):
         # Note that we do slow-spin here and wait, since it appears the time
         # ReportCrash takes to actually write and flush the file varies when there are