Reviewed by Ken.

	- avoid messing with undo manager needlessly for ~1% HTML iBench speedup

        * WebCoreSupport.subproj/WebBridge.h:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge registerCommandForUndo:]): mark undo/redo item flag
        (-[WebBridge registerCommandForRedo:]): ditto
        (-[WebBridge clearUndoRedoOperations]): check flag before removing items,
	and clear it after removing them

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index dced1ca526ef10e9dd7ee125d5023d5245ec0474..9ce6f3de179755ec8edd33f59b709ed81621af29 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,16 @@
+2004-05-09  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Ken.
+
+       - avoid messing with undo manager needlessly for ~1% HTML iBench speedup
+
+        * WebCoreSupport.subproj/WebBridge.h:
+        * WebCoreSupport.subproj/WebBridge.m:
+        (-[WebBridge registerCommandForUndo:]): mark undo/redo item flag
+        (-[WebBridge registerCommandForRedo:]): ditto
+        (-[WebBridge clearUndoRedoOperations]): check flag before removing items,
+       and clear it after removing them
+
 2004-05-08  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Darin.

diff --git a/WebKit/WebCoreSupport.subproj/WebBridge.h b/WebKit/WebCoreSupport.subproj/WebBridge.h
index d0d10e2484ffc0fe1241f9efba7b4b01bd0605e6..c6dd7e7ddf9c58a47c7cf6477ca98072b6e71def 100644 (file)
--- a/WebKit/WebCoreSupport.subproj/WebBridge.h
+++ b/WebKit/WebCoreSupport.subproj/WebBridge.h
@@ -19,6 +19,7 @@
     BOOL _keyboardUIModeAccessed;
     BOOL _doingClientRedirect;
     BOOL _inNextKeyViewOutsideWebFrameViews;
+    BOOL _haveUndoRedoOperations;
 }
 
 - (id)initWithWebFrame:(WebFrame *)webFrame;

diff --git a/WebKit/WebCoreSupport.subproj/WebBridge.m b/WebKit/WebCoreSupport.subproj/WebBridge.m
index 63fea61c2ebfc4c58041deb8890657c6dcac325b..5a7382c73bb9958bf32b07911cdd6e32e6b5cfbb 100644 (file)
--- a/WebKit/WebCoreSupport.subproj/WebBridge.m
+++ b/WebKit/WebCoreSupport.subproj/WebBridge.m
@@ -1183,18 +1183,23 @@ static id <WebFormDelegate> formDelegate(WebBridge *self)
 {
     NSUndoManager *undoManager = [[_frame webView] undoManager];
     [undoManager registerUndoWithTarget:self selector:@selector(undoEditing:) object:arg];
+    _haveUndoRedoOperations = YES;
 }
 
 - (void)registerCommandForRedo:(id)arg
 {
     NSUndoManager *undoManager = [[_frame webView] undoManager];
     [undoManager registerUndoWithTarget:self selector:@selector(redoEditing:) object:arg];
+    _haveUndoRedoOperations = YES;
 }
 
 - (void)clearUndoRedoOperations
 {
-    NSUndoManager *undoManager = [[_frame webView] undoManager];
-    [undoManager removeAllActionsWithTarget:self];
+    if (_haveUndoRedoOperations) {
+       NSUndoManager *undoManager = [[_frame webView] undoManager];
+       [undoManager removeAllActionsWithTarget:self];
+       _haveUndoRedoOperations = NO;
+    }
 }
 
 - (void)editingKeyDown:(NSEvent *)event