Comment in RenderStyle is no longer accurate

https://bugs.webkit.org/show_bug.cgi?id=129956

Reviewed by Simon Fraser.

RenderStyle::createStyleInheritingFromPseudoStyle was moved from RenderImage. Before it
was moved, there was an image-specific comment in the function. However, that comment
is both irrelevant to RenderStyle, and incorrect as the function is necessary for
RenderQuotes as well.

No new tests are necessary because there is no behavior change.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@165324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 212acb6318a59aca60a054f7cb8d349c411a11eb..453f30fe35ab325dd6492dff799d355dd85f6c7f 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2014-03-07  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Comment in RenderStyle is no longer accurate
+        https://bugs.webkit.org/show_bug.cgi?id=129956
+
+        Reviewed by Simon Fraser.
+
+        RenderStyle::createStyleInheritingFromPseudoStyle was moved from RenderImage. Before it
+        was moved, there was an image-specific comment in the function. However, that comment
+        is both irrelevant to RenderStyle, and incorrect as the function is necessary for
+        RenderQuotes as well.
+
+        No new tests are necessary because there is no behavior change.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
+
 2014-03-07  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
 
         [WebRTC] Throw SYNTAX_ERROR when maxRetransmits and maxRetransmitTime are both set in RTCDataChannelInit

diff --git a/Source/WebCore/rendering/style/RenderStyle.cpp b/Source/WebCore/rendering/style/RenderStyle.cpp
index 3e0617dc63ab39c8d1b188fe38887d532c824532..7e5a1043c23f0bbc96163425cec440e6b69966db 100644 (file)
--- a/Source/WebCore/rendering/style/RenderStyle.cpp
+++ b/Source/WebCore/rendering/style/RenderStyle.cpp
@@ -111,9 +111,6 @@ PassRef<RenderStyle> RenderStyle::createStyleInheritingFromPseudoStyle(const Ren
 {
     ASSERT(pseudoStyle.styleType() == BEFORE || pseudoStyle.styleType() == AFTER);
 
-    // Images are special and must inherit the pseudoStyle so the width and height of
-    // the pseudo element doesn't change the size of the image. In all other cases we
-    // can just share the style.
     auto style = RenderStyle::create();
     style.get().inheritFrom(&pseudoStyle);
     return style;