Dont null-check the renderer before submitting, since a script can set it to display...
authorhyatt <hyatt@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Jan 2005 22:43:39 +0000 (22:43 +0000)
committerhyatt <hyatt@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Jan 2005 22:43:39 +0000 (22:43 +0000)
submission to occur.  Fixes bug #3477282.

        Reviewed by kdecker

        (DOM::HTMLInputElementImpl::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/html/html_formimpl.cpp

index 3b10efbedb8d89a0f577bfadf6255462f2ce762f..6a394fb587e70defcbe0dec8e012bec7e3205d3e 100644 (file)
@@ -1,3 +1,12 @@
+2005-01-19  David Hyatt  <hyatt@apple.com>
+
+       Dont null-check the renderer before submitting, since a script can set it to display:none and still expect the
+       submission to occur.  Fixes bug #3477282.
+       
+        Reviewed by kdecker
+
+        (DOM::HTMLInputElementImpl::defaultEventHandler):
+
 2005-01-18  Richard Williamson   <rjw@apple.com>
        
        Fixed several issues all arising from analysis of plugin detection code at ifilm.com:
index c44d69933183296cc63c04b7c3d7a13598c18922..27559f4f0528c2bf52888bcb38894cf7934c9b0b 100644 (file)
@@ -1981,7 +1981,7 @@ void HTMLInputElementImpl::defaultEventHandler(EventImpl *evt)
     if ((evt->id() == EventImpl::DOMACTIVATE_EVENT) &&
         (m_type == IMAGE || m_type == SUBMIT || m_type == RESET)){
 
-        if (!m_form || !m_render)
+        if (!m_form)
             return;
 
         if (m_type == RESET) {