Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Update DOMNode::toString to always use className rather than preferring nodeName.
* bindings/js/kjs_dom.cpp:
(KJS::DOMNode::toString): Match the format returned by valueOf.
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Updated test results for change from nodeName to className in DOMNode::toString.
* fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
* fast/dom/prototype-chain-expected.txt:
* fast/dom/replace-first-child-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/forms/input-appearance-preventDefault-expected.checksum:
* fast/forms/input-appearance-preventDefault-expected.png:
* fast/forms/input-appearance-preventDefault-expected.txt:
* fast/loader/loadInProgress-expected.txt:
* fast/tokenizer/external-script-document-write-expected.checksum:
* fast/tokenizer/external-script-document-write-expected.png:
* fast/tokenizer/external-script-document-write-expected.txt:
* traversal/stay-within-root-expected.checksum:
* traversal/stay-within-root-expected.png:
* traversal/stay-within-root-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-11-06 Mark Rowe <bdash@webkit.org>
+
+ Reviewed by Maciej.
+
+ http://bugs.webkit.org/show_bug.cgi?id=11526
+ Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
+
+ Updated test results for change from nodeName to className in DOMNode::toString.
+
+ * fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
+ * fast/dom/prototype-chain-expected.txt:
+ * fast/dom/replace-first-child-expected.txt:
+ * fast/events/mouseclick-target-and-positioning-expected.txt:
+ * fast/forms/input-appearance-preventDefault-expected.checksum:
+ * fast/forms/input-appearance-preventDefault-expected.png:
+ * fast/forms/input-appearance-preventDefault-expected.txt:
+ * fast/loader/loadInProgress-expected.txt:
+ * fast/tokenizer/external-script-document-write-expected.checksum:
+ * fast/tokenizer/external-script-document-write-expected.png:
+ * fast/tokenizer/external-script-document-write-expected.txt:
+ * traversal/stay-within-root-expected.checksum:
+ * traversal/stay-within-root-expected.png:
+ * traversal/stay-within-root-expected.txt:
+
2006-11-06 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej.
You should see 5 lines with "SUCCESS" below:
-SUCCESS (value: "[object META]")
+FAILURE: expected "[object META]", actual "[object HTMLMetaElement]"
SUCCESS (value: "foo")
[object HTMLDocument]
------ [object DIV] (8 prototypes) -----
+----- [object HTMLDivElement] (8 prototypes) -----
[object Object]
This tests for a bug in replaceChild where it would fail to replace an element if it was the first child of its container. See bug 6782 for details. If the test is successful you will see an object description below, and if it fails you will see "null".
-[object DIV]
+[object HTMLDivElement]
click inside the red box:
[]
-PASS: event target should be [object SPAN] and is
+PASS: event target should be [object HTMLElement] and is
PASS: event.pageX should be 175 and is
PASS: event.pageY should be 105 and is
PASS: event.clientX should be 175 and is
-a9fb25b7dcabbe0dcfd6df906d7a32df
\ No newline at end of file
+4fc2dfc07ffba17b0ba75af3f25c9fe1
\ No newline at end of file
RenderBlock {DIV} at (3,3) size 142x13
RenderText {#text} at (1,0) size 129x13
text run at (1,0) width 129: "No caret should be here"
-layer at (10,70) size 240x36
- RenderBlock (positioned) {DIV} at (10,70) size 240x36
+layer at (10,70) size 323x36
+ RenderBlock (positioned) {DIV} at (10,70) size 323x36
RenderBR {BR} at (0,0) size 0x18
- RenderText {#text} at (0,18) size 240x18
- text run at (0,18) width 240: "mousedown on target [object INPUT]"
+ RenderText {#text} at (0,18) size 323x18
+ text run at (0,18) width 323: "mousedown on target [object HTMLInputElement]"
-ALERT: Test passed: [object FORM]
+ALERT: Test passed: [object HTMLFormElement]
-51a6e47d52b6df9301877707d6d1f4ac
\ No newline at end of file
+7e57f97082d3ae6aba1a3443a8cca169
\ No newline at end of file
RenderBlock {HTML} at (0,0) size 800x34
RenderBody {BODY} at (8,8) size 784x18
RenderInline {SPAN} at (0,0) size 0x0
- RenderText {#text} at (0,0) size 239x18
- text run at (0,0) width 239: "This should be a span: [object SPAN]"
+ RenderText {#text} at (0,0) size 295x18
+ text run at (0,0) width 295: "This should be a span: [object HTMLElement]"
-6ac3a1ffc86df24c99698a832aa89249
\ No newline at end of file
+6be147d47c579f68ea789faf193a0ffe
\ No newline at end of file
text run at (0,0) width 320: "NodeIterator: testing nextNode() (5 should be null)"
RenderListItem {LI} at (40,18) size 744x18
RenderListMarker at (-20,0) size 16x18
- RenderText {#text} at (0,0) size 81x18
- text run at (0,0) width 81: "[object DIV]"
+ RenderText {#text} at (0,0) size 174x18
+ text run at (0,0) width 174: "[object HTMLDivElement]"
RenderListItem {LI} at (40,36) size 744x18
RenderListMarker at (-20,0) size 16x18
- RenderText {#text} at (0,0) size 81x18
- text run at (0,0) width 81: "[object DIV]"
+ RenderText {#text} at (0,0) size 174x18
+ text run at (0,0) width 174: "[object HTMLDivElement]"
RenderListItem {LI} at (40,54) size 744x18
RenderListMarker at (-20,0) size 16x18
- RenderText {#text} at (0,0) size 81x18
- text run at (0,0) width 81: "[object DIV]"
+ RenderText {#text} at (0,0) size 174x18
+ text run at (0,0) width 174: "[object HTMLDivElement]"
RenderListItem {LI} at (40,72) size 744x18
RenderListMarker at (-20,0) size 16x18
RenderText {#text} at (0,0) size 24x18
text run at (0,0) width 323: "TreeWalker: testing nextNode() (11 should be null)"
RenderListItem {LI} at (40,144) size 744x18
RenderListMarker at (-20,0) size 16x18
- RenderText {#text} at (0,0) size 81x18
- text run at (0,0) width 81: "[object DIV]"
+ RenderText {#text} at (0,0) size 174x18
+ text run at (0,0) width 174: "[object HTMLDivElement]"
RenderListItem {LI} at (40,162) size 744x18
RenderListMarker at (-28,0) size 24x18
- RenderText {#text} at (0,0) size 81x18
- text run at (0,0) width 81: "[object DIV]"
+ RenderText {#text} at (0,0) size 174x18
+ text run at (0,0) width 174: "[object HTMLDivElement]"
RenderListItem {LI} at (40,180) size 744x18
RenderListMarker at (-28,0) size 24x18
RenderText {#text} at (0,0) size 24x18
+2006-11-06 Mark Rowe <bdash@webkit.org>
+
+ Reviewed by Maciej.
+
+ http://bugs.webkit.org/show_bug.cgi?id=11526
+ Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
+
+ Update DOMNode::toString to always use className rather than preferring nodeName.
+
+ * bindings/js/kjs_dom.cpp:
+ (KJS::DOMNode::toString): Match the format returned by valueOf.
+
2006-11-06 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
return jsString(toString(exec));
}
-UString DOMNode::toString(ExecState* ) const
+UString DOMNode::toString(ExecState*) const
{
- if (!m_impl)
- return "null";
- return "[object " + (m_impl->isElementNode() ? UString(m_impl->nodeName()) : className()) + "]";
+ if (!m_impl)
+ return "null";
+ return "[object " + className() + "]";
}
JSValue* DOMNodeProtoFunc::callAsFunction(ExecState* exec, JSObject* thisObj, const List &args)