LayoutTests:
authoradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Jun 2007 21:29:05 +0000 (21:29 +0000)
committeradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Jun 2007 21:29:05 +0000 (21:29 +0000)
        Rolling out tests for <rdar://problem/5301322>.

        * fast/forms/input-readonly-select-all-expected.checksum: Removed.
        * fast/forms/input-readonly-select-all-expected.png: Removed.
        * fast/forms/input-readonly-select-all-expected.txt: Removed.
        * fast/forms/input-readonly-select-all.html: Removed..
        * fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
        * fast/forms/textarea-readonly-select-all-expected.png: Removed.
        * fast/forms/textarea-readonly-select-all-expected.txt: Removed.
        * fast/forms/textarea-readonly-select-all.html: Removed.

WebCore:

        Rolling out fix for <rdar://problem/5301322> since it broke layout tests.

        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/input-readonly-select-all-expected.checksum [deleted file]
LayoutTests/fast/forms/input-readonly-select-all-expected.png [deleted file]
LayoutTests/fast/forms/input-readonly-select-all-expected.txt [deleted file]
LayoutTests/fast/forms/input-readonly-select-all.html [deleted file]
LayoutTests/fast/forms/textarea-readonly-select-all-expected.checksum [deleted file]
LayoutTests/fast/forms/textarea-readonly-select-all-expected.png [deleted file]
LayoutTests/fast/forms/textarea-readonly-select-all-expected.txt [deleted file]
LayoutTests/fast/forms/textarea-readonly-select-all.html [deleted file]
WebCore/ChangeLog
WebCore/html/HTMLInputElement.h
WebCore/html/HTMLTextAreaElement.h

index 394dfac9cdd967e44e1ae50aee3b0d772fba559d..d76a26337f73a50b720bc915ffb95a5aeab5ac3f 100644 (file)
@@ -1,3 +1,16 @@
+2007-06-29  Adele Peterson  <adele@apple.com>
+
+        Rolling out tests for <rdar://problem/5301322>.
+
+        * fast/forms/input-readonly-select-all-expected.checksum: Removed.
+        * fast/forms/input-readonly-select-all-expected.png: Removed.
+        * fast/forms/input-readonly-select-all-expected.txt: Removed.
+        * fast/forms/input-readonly-select-all.html: Removed..
+        * fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
+        * fast/forms/textarea-readonly-select-all-expected.png: Removed.
+        * fast/forms/textarea-readonly-select-all-expected.txt: Removed.
+        * fast/forms/textarea-readonly-select-all.html: Removed.
+
 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Oliver Hunt.
diff --git a/LayoutTests/fast/forms/input-readonly-select-all-expected.checksum b/LayoutTests/fast/forms/input-readonly-select-all-expected.checksum
deleted file mode 100644 (file)
index a06e874..0000000
+++ /dev/null
@@ -1 +0,0 @@
-bad0bba0462b2eb28be7b9478d47d272
\ No newline at end of file
diff --git a/LayoutTests/fast/forms/input-readonly-select-all-expected.png b/LayoutTests/fast/forms/input-readonly-select-all-expected.png
deleted file mode 100644 (file)
index b0257b1..0000000
Binary files a/LayoutTests/fast/forms/input-readonly-select-all-expected.png and /dev/null differ
diff --git a/LayoutTests/fast/forms/input-readonly-select-all-expected.txt b/LayoutTests/fast/forms/input-readonly-select-all-expected.txt
deleted file mode 100644 (file)
index 764282b..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderText {#text} at (0,0) size 585x18
-        text run at (0,0) width 585: "This tests that select all works in a readonly text field, without selecting the surrounding text. "
-      RenderBR {BR} at (0,0) size 0x0
-      RenderTextControl {INPUT} at (2,20) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
-      RenderText {#text} at (0,0) size 0x0
-      RenderText {#text} at (0,0) size 0x0
-layer at (13,31) size 142x13 scrollWidth 153
-  RenderBlock {DIV} at (3,3) size 142x13
-    RenderText {#text} at (1,0) size 152x13
-      text run at (1,0) width 152: "This text should be selected"
-selection start: position 0 of child 0 {#text} of child 0 {DIV} of child 3 {INPUT} of child 1 {BODY} of child 0 {HTML} of document
-selection end:   position 28 of child 0 {#text} of child 0 {DIV} of child 3 {INPUT} of child 1 {BODY} of child 0 {HTML} of document
diff --git a/LayoutTests/fast/forms/input-readonly-select-all.html b/LayoutTests/fast/forms/input-readonly-select-all.html
deleted file mode 100644 (file)
index 3fbaa3d..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-<html>
-<head>
-    <script>
-        function test()
-        {
-            var tf = document.getElementById('tf');
-            tf.focus();
-            document.execCommand("SelectAll");
-        }
-    </script>
-</head>
-<body onload="test()">
-    This tests that select all works in a readonly text field, without selecting the surrounding text.
-    <br>
-    <input id="tf" readonly value="This text should be selected"></input>
-</body>
-</html>
diff --git a/LayoutTests/fast/forms/textarea-readonly-select-all-expected.checksum b/LayoutTests/fast/forms/textarea-readonly-select-all-expected.checksum
deleted file mode 100644 (file)
index e1c2678..0000000
+++ /dev/null
@@ -1 +0,0 @@
-6aeb3a077068317812e9ea79708491a8
\ No newline at end of file
diff --git a/LayoutTests/fast/forms/textarea-readonly-select-all-expected.png b/LayoutTests/fast/forms/textarea-readonly-select-all-expected.png
deleted file mode 100644 (file)
index a329d99..0000000
Binary files a/LayoutTests/fast/forms/textarea-readonly-select-all-expected.png and /dev/null differ
diff --git a/LayoutTests/fast/forms/textarea-readonly-select-all-expected.txt b/LayoutTests/fast/forms/textarea-readonly-select-all-expected.txt
deleted file mode 100644 (file)
index 2925ffd..0000000
+++ /dev/null
@@ -1,18 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderText {#text} at (0,0) size 579x18
-        text run at (0,0) width 579: "This tests that select all works in a readonly textarea, without selecting the surrounding text. "
-      RenderBR {BR} at (0,0) size 0x0
-      RenderTextControl {TEXTAREA} at (2,20) size 163x28 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
-      RenderText {#text} at (0,0) size 0x0
-      RenderText {#text} at (0,0) size 0x0
-      RenderText {#text} at (0,0) size 0x0
-layer at (11,29) size 161x26
-  RenderBlock {DIV} at (1,1) size 161x26
-    RenderText {#text} at (3,0) size 152x13
-      text run at (3,0) width 152: "This text should be selected"
-selection start: position 0 of child 0 {#text} of child 0 {DIV} of child 3 {TEXTAREA} of child 1 {BODY} of child 0 {HTML} of document
-selection end:   position 28 of child 0 {#text} of child 0 {DIV} of child 3 {TEXTAREA} of child 1 {BODY} of child 0 {HTML} of document
diff --git a/LayoutTests/fast/forms/textarea-readonly-select-all.html b/LayoutTests/fast/forms/textarea-readonly-select-all.html
deleted file mode 100644 (file)
index 8c71395..0000000
+++ /dev/null
@@ -1,18 +0,0 @@
-<html>
-<head>
-    <script>
-        function test()
-        {
-            var ta = document.getElementById('ta');
-            ta.focus();
-            document.execCommand("SelectAll");
-        }
-    </script>
-</head>
-<body onload="test()">
-    This tests that select all works in a readonly textarea, without selecting the surrounding text.
-    <br>
-    <textarea id="ta" readonly>This text should be selected</textarea>
-</body>
-</html>
-
index bbaa43836ef66424fb950551a188d77cb5b35d19..0ab890ae10a4a1e946702fc770b544874bd92a49 100644 (file)
@@ -1,3 +1,10 @@
+2007-06-29  Adele Peterson  <adele@apple.com>
+
+        Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
+
+        * html/HTMLInputElement.h:
+        * html/HTMLTextAreaElement.h:
+
 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Oliver Hunt.
index d844905285b8ce654ff646f933dcb134ecba9d22..aba26b0e420e34761d5608b87767f05832e3b591 100644 (file)
@@ -66,8 +66,7 @@ public:
     virtual void dispatchBlurEvent();
     virtual void updateFocusAppearance(bool restorePreviousSelection = false);
     virtual void aboutToUnload();
-    virtual bool canSelectAll() const { return isTextField(); }
-    virtual void selectAll() { select(); }
+
     virtual const AtomicString& name() const;
 
     bool autoComplete() const { return m_autocomplete; }
index 1d9d6d232dc8697bb338422366b981e6eb5c43ea..30c71977696a407e13ca9143ab27eb3ebbcb398c 100644 (file)
@@ -74,9 +74,7 @@ public:
     virtual bool isKeyboardFocusable(KeyboardEvent*) const;
     virtual void focus(bool restorePreviousSelection = true);
     virtual void updateFocusAppearance(bool restorePreviousSelection = true);
-    virtual bool canSelectAll() const { return true; }
-    virtual void selectAll() { select(); }
-    
+
     String value() const;
     void setValue(const String&);
     String defaultValue() const;