Fixed <rdar://problem/4008338> REGRESSION (125-178): opacity style not working,...

	There was a long standing bug in cssText().  Double value were always cast int!  So,
	opacity values values were incorrectly converted to text, i.e. 0.75 became 0.

	The problem was newly triggered because we parse the css for opacity *TWICE*.  This is a result of
	incorrectly "invalidating" the style attribute (from fix for 3790449).  The second parse was from
	the cssText() of the style.

        Reviewed by Hyatt.

        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSPrimitiveValueImpl::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index b10938dd50b769e83975fedef3188c5e613b5500..2873857822a4a963efb899f1daaf5a1df3342eb5 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,19 @@
+2005-02-21  Richard Williamson   <rjw@apple.com>
+
+       Fixed <rdar://problem/4008338> REGRESSION (125-178): opacity style not working, breaks fading images on okcupid.com
+
+       There was a long standing bug in cssText().  Double value were always cast int!  So,
+       opacity values values were incorrectly converted to text, i.e. 0.75 became 0.
+       
+       The problem was newly triggered because we parse the css for opacity *TWICE*.  This is a result of 
+       incorrectly "invalidating" the style attribute (from fix for 3790449).  The second parse was from
+       the cssText() of the style.
+
+        Reviewed by Hyatt.
+
+        * khtml/css/css_valueimpl.cpp:
+        (DOM::CSSPrimitiveValueImpl::cssText):
+
 2005-02-21  David Hyatt  <hyatt@apple.com>
 
        Fix for 4017204, apply the same fix to the base class nodeAtPoint that was already applied to RenderBlock.

diff --git a/WebCore/khtml/css/css_valueimpl.cpp b/WebCore/khtml/css/css_valueimpl.cpp
index b4a8a850f912f476b6e6cfc6336f2bd9d27125a5..a40ebc58bb8a06ea1e91434cbb8c08fafe62d998 100644 (file)
--- a/WebCore/khtml/css/css_valueimpl.cpp
+++ b/WebCore/khtml/css/css_valueimpl.cpp
@@ -824,7 +824,7 @@ DOM::DOMString CSSPrimitiveValueImpl::cssText() const
            // ###
            break;
        case CSSPrimitiveValue::CSS_NUMBER:
-           text = DOMString(QString::number( (int)m_value.num ));
+           text = DOMString(QString::number( m_value.num ));
            break;
        case CSSPrimitiveValue::CSS_PERCENTAGE:
            text = DOMString(QString::number( m_value.num ) + "%");