Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
authorwebkit@devinrousso.com <webkit@devinrousso.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Dec 2017 18:58:40 +0000 (18:58 +0000)
committerwebkit@devinrousso.com <webkit@devinrousso.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Dec 2017 18:58:40 +0000 (18:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=180466

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.applyFilter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleEditorFilterApplied):

* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.applyFilter):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionFilterApplied):

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.applyFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js
Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

index 06c029a58606d58e521e8d8b644e4a273c85e550..12287be23384e39ec492e0f667e3fb43c94cceb1 100644 (file)
@@ -1,3 +1,21 @@
+2017-12-06  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
+        https://bugs.webkit.org/show_bug.cgi?id=180466
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+        (WI.SpreadsheetCSSStyleDeclarationSection.prototype.applyFilter):
+        (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleEditorFilterApplied):
+
+        * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+        (WI.SpreadsheetRulesStyleDetailsPanel.prototype.applyFilter):
+        (WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionFilterApplied):
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.applyFilter):
+
 2017-12-06  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: Styles Redesign: display related pseudo-elements
 2017-12-06  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: Styles Redesign: display related pseudo-elements
index fe641eabba74f30cb0f296c70644be79dcdb5c74..d980bca72aa810251319f1709e1adb45486dc7c4 100644 (file)
@@ -196,7 +196,7 @@ WI.SpreadsheetCSSStyleDeclarationSection = class SpreadsheetCSSStyleDeclarationS
         if (!this.didInitialLayout)
             return;
 
         if (!this.didInitialLayout)
             return;
 
-        this._element.classList.remove(WI.CSSStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
+        this._element.classList.remove(WI.GeneralStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
 
         this._propertiesEditor.applyFilter(this._filterText);
     }
 
         this._propertiesEditor.applyFilter(this._filterText);
     }
@@ -426,27 +426,27 @@ WI.SpreadsheetCSSStyleDeclarationSection = class SpreadsheetCSSStyleDeclarationS
     {
         let matchesMedia = false;
         for (let mediaElement of this._mediaElements) {
     {
         let matchesMedia = false;
         for (let mediaElement of this._mediaElements) {
-            mediaElement.classList.remove(WI.CSSStyleDetailsSidebarPanel.FilterMatchSectionClassName);
+            mediaElement.classList.remove(WI.GeneralStyleDetailsSidebarPanel.FilterMatchSectionClassName);
 
             if (mediaElement.textContent.includes(this._filterText)) {
 
             if (mediaElement.textContent.includes(this._filterText)) {
-                mediaElement.classList.add(WI.CSSStyleDetailsSidebarPanel.FilterMatchSectionClassName);
+                mediaElement.classList.add(WI.GeneralStyleDetailsSidebarPanel.FilterMatchSectionClassName);
                 matchesMedia = true;
             }
         }
 
         let matchesSelector = false;
         for (let selectorElement of this._selectorElements) {
                 matchesMedia = true;
             }
         }
 
         let matchesSelector = false;
         for (let selectorElement of this._selectorElements) {
-            selectorElement.classList.remove(WI.CSSStyleDetailsSidebarPanel.FilterMatchSectionClassName);
+            selectorElement.classList.remove(WI.GeneralStyleDetailsSidebarPanel.FilterMatchSectionClassName);
 
             if (selectorElement.textContent.includes(this._filterText)) {
 
             if (selectorElement.textContent.includes(this._filterText)) {
-                selectorElement.classList.add(WI.CSSStyleDetailsSidebarPanel.FilterMatchSectionClassName);
+                selectorElement.classList.add(WI.GeneralStyleDetailsSidebarPanel.FilterMatchSectionClassName);
                 matchesSelector = true;
             }
         }
 
         let matches = event.data.matches || matchesMedia || matchesSelector;
         if (!matches)
                 matchesSelector = true;
             }
         }
 
         let matches = event.data.matches || matchesMedia || matchesSelector;
         if (!matches)
-            this._element.classList.add(WI.CSSStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
+            this._element.classList.add(WI.GeneralStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
 
         this.dispatchEventToListeners(WI.SpreadsheetCSSStyleDeclarationSection.Event.FilterApplied, {matches});
     }
 
         this.dispatchEventToListeners(WI.SpreadsheetCSSStyleDeclarationSection.Event.FilterApplied, {matches});
     }
index 1456f0bd3648801c786a98d2003289f1a8da231d..fa752bca3ad3c8682fa4942cc1b6c8b829901371 100644 (file)
@@ -240,7 +240,7 @@ WI.SpreadsheetRulesStyleDetailsPanel = class SpreadsheetRulesStyleDetailsPanel e
             this.element.classList.add("filter-non-matching");
 
         for (let header of this._headerMap.values())
             this.element.classList.add("filter-non-matching");
 
         for (let header of this._headerMap.values())
-            header.classList.remove(WI.CSSStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
+            header.classList.remove(WI.GeneralStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
 
         for (let section of this._sections)
             section.applyFilter(this._filterText);
 
         for (let section of this._sections)
             section.applyFilter(this._filterText);
@@ -264,7 +264,7 @@ WI.SpreadsheetRulesStyleDetailsPanel = class SpreadsheetRulesStyleDetailsPanel e
         else {
             let header = this._headerMap.get(event.target.style.node);
             if (header)
         else {
             let header = this._headerMap.get(event.target.style.node);
             if (header)
-                header.classList.add(WI.CSSStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
+                header.classList.add(WI.GeneralStyleDetailsSidebarPanel.NoFilterMatchInSectionClassName);
         }
     }
 
         }
     }
 
index a7dff531634556201da3a9d971f520fb894529c5..66e116ced2bccd11ece9d2506fd6564de2867dd6 100644 (file)
@@ -134,8 +134,8 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
         let matchesName = this._nameElement.textContent.includes(filterText);
         let matchesValue = this._valueElement.textContent.includes(filterText);
         let matches = matchesName || matchesValue;
         let matchesName = this._nameElement.textContent.includes(filterText);
         let matchesValue = this._valueElement.textContent.includes(filterText);
         let matches = matchesName || matchesValue;
-        this._contentElement.classList.toggle(WI.CSSStyleDetailsSidebarPanel.FilterMatchSectionClassName, matches);
-        this._contentElement.classList.toggle(WI.CSSStyleDetailsSidebarPanel.NoFilterMatchInPropertyClassName, !matches);
+        this._contentElement.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.FilterMatchSectionClassName, matches);
+        this._contentElement.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.NoFilterMatchInPropertyClassName, !matches);
         return matches;
     }
 
         return matches;
     }