[GTK][WK2] Logging of accessibility events is not disabled between tests
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Sep 2013 13:48:47 +0000 (13:48 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Sep 2013 13:48:47 +0000 (13:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=121957

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-27
Reviewed by Mario Sanchez Prada.

Tools:

Fixed an issue in AccessibilityNotificationHandler where the destructor
was not disconnecting accessibility event callbacks if logging was on.
The decision of disconnecting events can solely rely on the existence of
notification handlers because logging uses the global notification
handler.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
disconnection when logging is on.

LayoutTests:

Removed some accessibility tests from the expectations file that were
failing before this fix.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk-wk2/TestExpectations
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp

index efd940d546ea44ce139bd95393e17afe4eb5e419..a33495e5c0fd2a84129521888497cb41195a8f4a 100644 (file)
@@ -1,3 +1,15 @@
+2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
+
+        [GTK][WK2] Logging of accessibility events is not disabled between tests
+        https://bugs.webkit.org/show_bug.cgi?id=121957
+
+        Reviewed by Mario Sanchez Prada.
+
+        Removed some accessibility tests from the expectations file that were
+        failing before this fix.
+
+        * platform/gtk-wk2/TestExpectations:
+
 2013-09-27  Krzysztof Wolanski  <k.wolanski@samsung.com>
 
         [EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
index ea4cd6d7647d2cc2293f9f83bda31c3e05e07be5..2fa07e84b2068dd5c11be9cacb585c84f571a373 100644 (file)
@@ -258,19 +258,6 @@ webkit.org/b/58337 fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html
 webkit.org/b/72698 media/audio-garbage-collect.html [ Failure Pass ]
 
 # Tests showing flakiness in the bot
-webkit.org/b/121957 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/aria-toggle-button-role.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/button-accessible-name.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/caret-browsing-text-focus.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/entry-and-password.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/list-items-always-exposed.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/media-controls-panel-title.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/name-from-label.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/object-with-title.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/remapped-aria-crash.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/spans.html [ Failure Pass ]
-webkit.org/b/121957 platform/gtk/accessibility/table-hierarchy.html [ Failure Pass ]
 Bug(GTK) editing/pasteboard/smart-paste-004.html [ Failure Pass ]
 Bug(GTK) editing/selection/5057506.html [ Failure Pass ]
 Bug(GTK) editing/selection/click-in-margins-inside-editable-div.html [ Failure Pass ]
index ff16ca7a41b4bb00d16566584d139efb752134a9..7b9705b356b0e28592f149c100b6cbb532bcf355 100644 (file)
@@ -1,3 +1,20 @@
+2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
+
+        [GTK][WK2] Logging of accessibility events is not disabled between tests
+        https://bugs.webkit.org/show_bug.cgi?id=121957
+
+        Reviewed by Mario Sanchez Prada.
+
+        Fixed an issue in AccessibilityNotificationHandler where the destructor
+        was not disconnecting accessibility event callbacks if logging was on.
+        The decision of disconnecting events can solely rely on the existence of
+        notification handlers because logging uses the global notification
+        handler.
+
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
+        disconnection when logging is on.
+
 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
 
         Add general CMakeLists.txt for DRT
index dcbd9ee8118c6aed64b5f8aa5b7d2cc9d81aab60..080da151b89a692e2979768b1175aa6518247e3d 100644 (file)
@@ -244,8 +244,8 @@ void AccessibilityNotificationHandler::connectAccessibilityCallbacks()
 
 bool AccessibilityNotificationHandler::disconnectAccessibilityCallbacks()
 {
-    // Only disconnect if logging is off and there is no notification handler.
-    if (loggingAccessibilityEvents || !notificationHandlers.isEmpty() || globalNotificationHandler)
+    // Only disconnect if there is no notification handler.
+    if (!notificationHandlers.isEmpty() || globalNotificationHandler)
         return false;
 
     // AtkObject signals.