+2006-10-06 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Darin
+
+ Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal
+
+ * DefaultDelegates/WebDefaultContextMenuDelegate.m:
+ * History/WebHistoryItem.m:
+ * Loader/WebFrameLoader.h:
+ * Misc/WebCoreStatistics.m:
+ * Misc/WebElementDictionary.m:
+ * Plugins/WebNetscapePluginEmbeddedView.m:
+ * Plugins/WebPluginController.m:
+ * WebCoreSupport/WebViewFactory.m:
+ * WebView/WebArchiver.m:
+ * WebView/WebDataSource.m:
+ * WebView/WebFrame.m:
+ (-[WebFrame _isDescendantOfFrame:]):
+ (-[WebFrame _setShouldCreateRenderers:]):
+ (-[WebFrame _bodyBackgroundColor]):
+ (-[WebFrame _isFrameSet]):
+ (-[WebFrame _firstLayoutDone]):
+ (-[WebFrame _loadType]):
+ * WebView/WebFrameInternal.h:
+ * WebView/WebFramePrivate.h:
+ * WebView/WebHTMLRepresentation.m:
+ * WebView/WebScriptDebugDelegate.m:
+
2006-10-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
#import <WebKit/WebDataSourcePrivate.h>
#import <WebKit/WebDefaultUIDelegate.h>
#import <WebKit/WebDOMOperations.h>
-#import <WebKit/WebFramePrivate.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebHTMLViewPrivate.h>
#import <WebKit/WebLocalizableStrings.h>
#import <WebKit/WebNSPasteboardExtras.h>
#import <JavaScriptCore/Assertions.h>
#import <WebKit/WebFrameBridge.h>
-#import <WebKit/WebFramePrivate.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebFrameView.h>
#import <WebKit/WebHTMLViewInternal.h>
#import <WebKit/WebIconDatabase.h>
@class WebArchive;
@class WebDataSource;
+@class WebFormState;
+@class WebFrameBridge;
@class WebMainResourceLoader;
@class WebLoader;
@class WebResource;
#import <WebCore/WebCoreJavaScript.h>
#import <WebKit/WebFrameBridge.h>
-#import <WebKit/WebFramePrivate.h>
+#import <WebKit/WebFrameInternal.h>
@implementation WebCoreStatistics
#import "WebDOMOperations.h"
#import "WebFrame.h"
#import "WebFrameBridge.h"
+#import "WebFrameInternal.h"
#import "WebView.h"
#import "WebViewPrivate.h"
#import <WebKit/WebFrameBridge.h>
#import <WebKit/WebDataSource.h>
#import <WebKit/WebFrame.h>
-#import <WebKit/WebFramePrivate.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebFrameView.h>
#import <WebKit/WebNetscapePluginPackage.h>
#import <WebKit/WebNetscapePluginStream.h>
#import <WebKit/WebPluginController.h>
#import <WebKit/WebFrameBridge.h>
-#import <WebKit/WebFramePrivate.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebFrameView.h>
#import <WebKit/WebHTMLViewPrivate.h>
#import <WebKit/WebKitErrorsPrivate.h>
#import <JavaScriptCore/Assertions.h>
#import <WebKit/WebFrameBridge.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebViewInternal.h>
#import <WebKit/WebHTMLViewInternal.h>
#import <WebKit/WebLocalizableStrings.h>
#import "WebDOMOperationsPrivate.h"
#import "WebFrame.h"
#import "WebFrameBridge.h"
-#import "WebFramePrivate.h"
+#import "WebFrameInternal.h"
#import "WebResource.h"
@implementation WebArchiver
#import "WebDefaultResourceLoadDelegate.h"
#import "WebDocument.h"
#import "WebFrameBridge.h"
+#import "WebFrameInternal.h"
#import "WebFrameLoader.h"
#import "WebFrameLoadDelegate.h"
#import "WebHTMLRepresentation.h"
}
@end
-
static inline WebFrame *Frame(WebCoreFrameBridge *bridge)
{
return [(WebFrameBridge *)bridge webFrame];
@end
-@implementation WebFrame (WebPrivate)
+@implementation WebFrame (WebInternal)
- (NSURLRequest *)_webDataRequestForData:(NSData *)data MIMEType:(NSString *)MIMEType textEncodingName: (NSString *)encodingName baseURL:(NSURL *)URL unreachableURL:(NSURL *)unreachableURL
{
return Frame([[self _bridge] childFrameNamed:name]);
}
-// FIXME: this exists only as a convenience for Safari, consider moving there
-- (BOOL)_isDescendantOfFrame:(WebFrame *)ancestor
-{
- return [[self _bridge] isDescendantOfFrame:[ancestor _bridge]];
-}
-
-- (BOOL)_isFrameSet
-{
- return [_private->bridge isFrameSet];
-}
-
- (void)_detachChildren
{
// FIXME: is it really necessary to do this in reverse order any more?
[self release];
}
-- (WebFrameLoadType)_loadType
-{
- return [_private->frameLoader loadType];
-}
-
- (void)_makeDocumentView
{
NSView <WebDocumentView> *documentView = [_private->webFrameView _makeDocumentViewForDataSource:[_private->frameLoader dataSource]];
return Frame([[self _bridge] previousFrameWithWrap:wrapFlag]);
}
-- (void)_setShouldCreateRenderers:(BOOL)f
-{
- [_private->bridge setShouldCreateRenderers:f];
-}
-
- (BOOL)_shouldCreateRenderers
{
return [_private->bridge shouldCreateRenderers];
return num;
}
-- (NSColor *)_bodyBackgroundColor
-{
- return [_private->bridge bodyBackgroundColor];
-}
-
- (void)_reloadForPluginChanges
{
for (WebFrame *frame = self; frame; frame = [frame _traverseNextFrameStayWithin:self]) {
}
}
-- (BOOL)_firstLayoutDone
-{
- return [_private->frameLoader firstLayoutDone];
-}
-
-@end
-
-@implementation WebFrame (WebInternal)
-
- (void)_didReceiveServerRedirectForProvisionalLoadForFrame
{
[[[self webView] _frameLoadDelegateForwarder] webView:[self webView]
@end
+@implementation WebFrame (WebPrivate)
+
+// FIXME: this exists only as a convenience for Safari, consider moving there
+- (BOOL)_isDescendantOfFrame:(WebFrame *)ancestor
+{
+ return [[self _bridge] isDescendantOfFrame:[ancestor _bridge]];
+}
+
+- (void)_setShouldCreateRenderers:(BOOL)f
+{
+ [_private->bridge setShouldCreateRenderers:f];
+}
+
+- (NSColor *)_bodyBackgroundColor
+{
+ return [_private->bridge bodyBackgroundColor];
+}
+
+- (BOOL)_isFrameSet
+{
+ return [_private->bridge isFrameSet];
+}
+
+- (BOOL)_firstLayoutDone
+{
+ return [_private->frameLoader firstLayoutDone];
+}
+
+- (WebFrameLoadType)_loadType
+{
+ return [_private->frameLoader loadType];
+}
+
+@end
+
@implementation WebFormState : NSObject
- (id)initWithForm:(DOMElement *)form values:(NSDictionary *)values sourceFrame:(WebFrame *)sourceFrame
// This header contains WebFrame declarations that can be used anywhere in WebKit, but are neither SPI nor API.
#import <WebKit/WebFramePrivate.h>
+#import "WebPolicyDelegatePrivate.h"
@class WebDocumentLoadState;
@class WebInspector;
@class WebFrameLoader;
+@class WebFrameView;
+@class WebFrameBridge;
+@class WebFormState;
// One day we might want to expand the use of this kind of class such that we'd receive one
// over the bridge, and possibly hand it on through to the FormsDelegate.
- (WebDocumentLoadState *)_createDocumentLoadStateWithRequest:(NSURLRequest *)request;
- (void)_didReceiveServerRedirectForProvisionalLoadForFrame;
+- (NSURLRequest *)_webDataRequestForData:(NSData *)data MIMEType:(NSString *)MIMEType textEncodingName:(NSString *)encodingName baseURL:(NSURL *)URL unreachableURL:(NSURL *)unreachableURL;
+
+- (void)_detachFromParent;
+- (void)_detachChildren;
+- (void)_closeOldDataSources;
+- (void)_commitProvisionalLoad:(NSDictionary *)pageCache;
+- (void)_checkLoadCompleteForThisFrame;
+- (void)_handledOnloadEvents;
+- (void)_checkLoadComplete;
+- (WebFrameBridge *)_bridge;
+
+- (void)_goToItem:(WebHistoryItem *)item withLoadType:(WebFrameLoadType)type;
+- (void)_loadURL:(NSURL *)URL referrer:(NSString *)referrer loadType:(WebFrameLoadType)loadType target:(NSString *)target triggeringEvent:(NSEvent *)event form:(DOMElement *)form formValues:(NSDictionary *)values;
+- (void)_loadURL:(NSURL *)URL referrer:(NSString *)referrer intoChild:(WebFrame *)childFrame;
+- (void)_postWithURL:(NSURL *)URL referrer:(NSString *)referrer target:(NSString *)target data:(NSArray *)postData contentType:(NSString *)contentType triggeringEvent:(NSEvent *)event form:(DOMElement *)form formValues:(NSDictionary *)values;
+
+- (void)_loadRequest:(NSURLRequest *)request inFrameNamed:(NSString *)frameName;
+
+- (void)_clientRedirectedTo:(NSURL *)URL delay:(NSTimeInterval)seconds fireDate:(NSDate *)date lockHistory:(BOOL)lockHistory isJavaScriptFormAction:(BOOL)isJavaScriptFormAction;
+- (void)_clientRedirectCancelledOrFinished:(BOOL)cancelWithLoadInProgress;
+
+- (void)_defersCallbacksChanged;
+
+- (void)_viewWillMoveToHostWindow:(NSWindow *)hostWindow;
+- (void)_viewDidMoveToHostWindow;
+
+- (void)_addChild:(WebFrame *)child;
+
+- (NSDictionary *)_actionInformationForNavigationType:(WebNavigationType)navigationType event:(NSEvent *)event originalURL:(NSURL *)URL;
+
+- (WebHistoryItem *)_itemForSavingDocState;
+- (WebHistoryItem *)_itemForRestoringDocState;
+
+- (void)_saveDocumentAndScrollState;
+
+- (void)_setTitle:(NSString *)title;
+
+- (void)_receivedMainResourceError:(NSError *)error;
+
++ (CFAbsoluteTime)_timeOfLastCompletedLoad;
+- (BOOL)_canCachePage;
+- (void)_purgePageCache;
+
+- (void)_opened;
+// used to decide to use loadType=Same
+- (BOOL)_shouldTreatURLAsSameAsCurrent:(NSURL *)URL;
+
+- (WebFrame *)_nextFrameWithWrap:(BOOL)wrapFlag;
+- (WebFrame *)_previousFrameWithWrap:(BOOL)wrapFlag;
+
+
+- (BOOL)_shouldCreateRenderers;
+
+- (int)_numPendingOrLoadingRequests:(BOOL)recurse;
+
+- (void)_reloadForPluginChanges;
+
+- (void)_attachScriptDebugger;
+- (void)_detachScriptDebugger;
+
+- (void)_recursive_pauseNullEventsForAllNetscapePlugins;
+- (void)_recursive_resumeNullEventsForAllNetscapePlugins;
+
- (void)_restoreScrollPositionAndViewState;
@end
// But it also contains a bunch of internal stuff that should be moved to WebFrameInternal.h
#import <WebKit/WebFrame.h>
-#import <WebKit/WebPolicyDelegatePrivate.h>
-
-@class DOMDocument;
-@class DOMElement;
-@class DOMNode;
-@class NSMutableURLRequest;
-@class NSURLRequest;
-@class WebArchive;
-@class WebFrameBridge;
-@class WebFormState;
-@class WebFrameBridge;
-@class WebFrameView;
-@class WebHistoryItem;
-@class WebPolicyDecisionListener;
-@class WebScriptDebugger;
-@class WebView;
// Keys for accessing the values in the page cache dictionary.
extern NSString *WebPageCacheEntryDateKey;
} WebFrameLoadType;
@interface WebFrame (WebPrivate)
-
-// Other private methods
-- (NSURLRequest *)_webDataRequestForData:(NSData *)data MIMEType:(NSString *)MIMEType textEncodingName:(NSString *)encodingName baseURL:(NSURL *)URL unreachableURL:(NSURL *)unreachableURL;
-
-- (void)_detachFromParent;
-- (void)_detachChildren;
-- (void)_closeOldDataSources;
-- (void)_commitProvisionalLoad:(NSDictionary *)pageCache;
-- (void)_checkLoadCompleteForThisFrame;
-- (void)_handledOnloadEvents;
-- (void)_checkLoadComplete;
-- (WebFrameBridge *)_bridge;
-- (WebFrameLoadType)_loadType;
-
-- (void)_goToItem:(WebHistoryItem *)item withLoadType:(WebFrameLoadType)type;
-- (void)_loadURL:(NSURL *)URL referrer:(NSString *)referrer loadType:(WebFrameLoadType)loadType target:(NSString *)target triggeringEvent:(NSEvent *)event form:(DOMElement *)form formValues:(NSDictionary *)values;
-- (void)_loadURL:(NSURL *)URL referrer:(NSString *)referrer intoChild:(WebFrame *)childFrame;
-- (void)_postWithURL:(NSURL *)URL referrer:(NSString *)referrer target:(NSString *)target data:(NSArray *)postData contentType:(NSString *)contentType triggeringEvent:(NSEvent *)event form:(DOMElement *)form formValues:(NSDictionary *)values;
-
-- (void)_loadRequest:(NSURLRequest *)request inFrameNamed:(NSString *)frameName;
-
-- (void)_clientRedirectedTo:(NSURL *)URL delay:(NSTimeInterval)seconds fireDate:(NSDate *)date lockHistory:(BOOL)lockHistory isJavaScriptFormAction:(BOOL)isJavaScriptFormAction;
-- (void)_clientRedirectCancelledOrFinished:(BOOL)cancelWithLoadInProgress;
-
-- (void)_defersCallbacksChanged;
-
-- (void)_viewWillMoveToHostWindow:(NSWindow *)hostWindow;
-- (void)_viewDidMoveToHostWindow;
-
-- (void)_addChild:(WebFrame *)child;
-
-- (NSDictionary *)_actionInformationForNavigationType:(WebNavigationType)navigationType event:(NSEvent *)event originalURL:(NSURL *)URL;
-
-- (WebHistoryItem *)_itemForSavingDocState;
-- (WebHistoryItem *)_itemForRestoringDocState;
-
-- (void)_saveDocumentAndScrollState;
-
-- (void)_setTitle:(NSString *)title;
-
-- (void)_receivedMainResourceError:(NSError *)error;
-
-+ (CFAbsoluteTime)_timeOfLastCompletedLoad;
-- (BOOL)_canCachePage;
-- (void)_purgePageCache;
-
-- (void)_opened;
-// used to decide to use loadType=Same
-- (BOOL)_shouldTreatURLAsSameAsCurrent:(NSURL *)URL;
-
-- (WebFrame *)_nextFrameWithWrap:(BOOL)wrapFlag;
-- (WebFrame *)_previousFrameWithWrap:(BOOL)wrapFlag;
-
+- (BOOL)_isDescendantOfFrame:(WebFrame *)frame;
- (void)_setShouldCreateRenderers:(BOOL)f;
-- (BOOL)_shouldCreateRenderers;
-
-- (int)_numPendingOrLoadingRequests:(BOOL)recurse;
-
- (NSColor *)_bodyBackgroundColor;
-
-- (void)_reloadForPluginChanges;
-
-- (BOOL)_isDescendantOfFrame:(WebFrame *)frame;
- (BOOL)_isFrameSet;
-
-- (void)_attachScriptDebugger;
-- (void)_detachScriptDebugger;
-
-- (void)_recursive_pauseNullEventsForAllNetscapePlugins;
-- (void)_recursive_resumeNullEventsForAllNetscapePlugins;
-
- (BOOL)_firstLayoutDone;
-
+- (WebFrameLoadType)_loadType;
@end
#import "WebDataSourceInternal.h"
#import "WebDocumentPrivate.h"
#import "WebFrameBridge.h"
-#import "WebFramePrivate.h"
+#import "WebFrameInternal.h"
#import "WebKitNSStringExtras.h"
#import "WebKitStatisticsPrivate.h"
#import "WebNSObjectExtras.h"
#import "WebDataSourceInternal.h"
#import <WebKit/WebFrameBridge.h>
+#import <WebKit/WebFrameInternal.h>
#import <WebKit/WebViewInternal.h>
#import <WebCore/WebCoreScriptDebugger.h>