https://bugs.webkit.org/show_bug.cgi?id=81893
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 14:35:51 +0000 (14:35 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 14:35:51 +0000 (14:35 +0000)
Remove custom bindings form ScriptProfileNode.idl of attribute type Array.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-22
Reviewed by Kentaro Hara.

Replace [CustomGetter] Array with sequence<ScriptProfileNode>.
To remove the custom bindings code.

Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.

* bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore::JSScriptProfileNode::callUID):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore):
* inspector/ScriptProfileNode.idl: Replaced Array with sequence<ScriptProfileNode>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp
Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp
Source/WebCore/inspector/ScriptProfileNode.idl

index b48cfc35e8835d3d171400258cd2ab2293b8f62b..13854c5993eb72d9a94483e6af748bc5e1c1a562 100644 (file)
@@ -1,3 +1,21 @@
+2012-03-22  Vineet Chaudhary  <rgf748@motorola.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81893
+        Remove custom bindings form ScriptProfileNode.idl of attribute type Array.
+
+        Reviewed by Kentaro Hara.
+
+        Replace [CustomGetter] Array with sequence<ScriptProfileNode>.
+        To remove the custom bindings code.
+
+        Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.
+
+        * bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
+        (WebCore::JSScriptProfileNode::callUID):
+        * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
+        (WebCore):
+        * inspector/ScriptProfileNode.idl: Replaced Array with sequence<ScriptProfileNode>.
+
 2012-03-22  Andrey Kosyakov  <caseq@chromium.org>
 
         Web Inspector: only update timeline overview categories strips when these are visible
index 8cf75bdd18937f6d088b6e5347b4203e0e5baeb7..c0893aac7f197e6052395d5ce42333912f89a1c0 100644 (file)
 
 #include "JSScriptProfileNode.h"
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-#include <profiler/ProfileNode.h>
-#endif
-
-#include <runtime/JSArray.h>
-
 using namespace JSC;
 
 namespace WebCore {
@@ -46,20 +40,6 @@ JSValue JSScriptProfileNode::callUID(ExecState*) const
     return result;
 }
 
-typedef Vector<RefPtr<ProfileNode> > ProfileNodesList;
-
-JSValue JSScriptProfileNode::children(ExecState* exec) const
-{
-    const ProfileNodesList& children = impl()->children();
-    MarkedArgumentBuffer list;
-
-    ProfileNodesList::const_iterator end = children.end();
-    for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
-        list.append(toJS(exec, globalObject(), iter->get()));
-
-    return constructArray(exec, globalObject(), list);
-}
-
 #endif
 
 } // namespace WebCore
index fedfffe86420b0619d11e930153d37a61fa25e5c..c13400efe2fb32697ad23d936e38389724456d78 100644 (file)
 
 namespace WebCore {
 
-v8::Handle<v8::Value> V8ScriptProfileNode::childrenAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
-    INC_STATS("DOM.ScriptProfileNode.childrenAccessorGetter");
-    ScriptProfileNode* imp = V8ScriptProfileNode::toNative(info.Holder());
-    const ProfileNodesList& children = imp->children();
-    v8::Handle<v8::Array> result = v8::Array::New(children.size());
-    int index = 0;
-    ProfileNodesList::const_iterator end = children.end();
-    for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
-        result->Set(v8::Integer::New(index++), toV8(iter->get()));
-    return result;
-}
-
 v8::Handle<v8::Value> V8ScriptProfileNode::callUIDAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
 {
     INC_STATS("DOM.ScriptProfileNode.callUIDAccessorGetter");
index 008d3b3b3f280056ad44117569d08b0f33c9c91b..43f795fe3681fa477b56dc6b08f2d4e9ee6f5b43 100644 (file)
@@ -37,7 +37,7 @@ module core {
         readonly attribute double totalTime;
         readonly attribute double selfTime;
         readonly attribute unsigned long numberOfCalls;
-        readonly attribute [CustomGetter] Array children;
+        readonly attribute sequence<ScriptProfileNode> children;
         readonly attribute boolean visible;
         readonly attribute [CustomGetter] unsigned long callUID;
     };