WebKit:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Apr 2004 20:05:38 +0000 (20:05 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Apr 2004 20:05:38 +0000 (20:05 +0000)
        - fixed these bugs:
        <rdar://problem/3636570>: "API: [WebPreferences tabsToLinks] should be public API"
        <rdar://problem/3610597>: "API: could turn "stealth browsing" preference into API"

        Reviewed by Darin.

        I just moved the declarations and implementations from one place to another.
        (No clients in WebKit needed their #imports updated.) This confused cvs diff quite a bit.

        * WebView.subproj/WebPreferences.h:
        * WebView.subproj/WebPreferences.m:
        (-[WebPreferences setTabsToLinks:]):
        (-[WebPreferences tabsToLinks]):
        (-[WebPreferences setPrivateBrowsingEnabled:]):
        (-[WebPreferences privateBrowsingEnabled]):
        (-[WebPreferences _pageCacheSize]):
        (-[WebPreferences _objectCacheSize]):
        (-[WebPreferences _backForwardCacheExpirationInterval]):
        * WebView.subproj/WebPreferencesPrivate.h:

WebBrowser:

        - fixed up #imports for WebPreferencesPrivate

        Reviewed by Darin.

        * AppController.m:
        removed #import <WebKit/WebPreferencesPrivate.h>
        * BrowserWindowController.m:
        replaced #import <WebKit/WebPreferencesPrivate.h> with #import <WebKit/WebPreferences.h>
        * DownloadProgressEntry.m:
        ditto
        * FormCompletionController.m:
        ditto
        * Preferences.subproj/AdvancedPreferences.m:
        removed #import <WebKit/WebPreferencesPrivate.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView.subproj/WebPreferences.h
WebKit/WebView.subproj/WebPreferences.m
WebKit/WebView.subproj/WebPreferencesPrivate.h

index 55170cb0b4d7825581f2acfbc166d608202cf4da..aa7dceb5ea3102b466999eefe24d067e76bfffe9 100644 (file)
@@ -1,3 +1,25 @@
+2004-04-28  John Sullivan  <sullivan@apple.com>
+
+        - fixed these bugs:
+        <rdar://problem/3636570>: "API: [WebPreferences tabsToLinks] should be public API"        
+        <rdar://problem/3610597>: "API: could turn "stealth browsing" preference into API"
+
+        Reviewed by Darin.
+        
+        I just moved the declarations and implementations from one place to another.
+        (No clients in WebKit needed their #imports updated.) This confused cvs diff quite a bit.
+
+        * WebView.subproj/WebPreferences.h:
+        * WebView.subproj/WebPreferences.m:
+        (-[WebPreferences setTabsToLinks:]):
+        (-[WebPreferences tabsToLinks]):
+        (-[WebPreferences setPrivateBrowsingEnabled:]):
+        (-[WebPreferences privateBrowsingEnabled]):
+        (-[WebPreferences _pageCacheSize]):
+        (-[WebPreferences _objectCacheSize]):
+        (-[WebPreferences _backForwardCacheExpirationInterval]):
+        * WebView.subproj/WebPreferencesPrivate.h:
+
 2004-04-27  David Hyatt  <hyatt@apple.com>
 
        Cut the time spent on an operation inside widthForNextCharacter from 17% of the function time down to less than 
index 3f5f18e4f55fd8d5f78ff9bccfdb083ee83d31b8..b31a9efd0a4696455d0e717655527f04720365ee 100644 (file)
@@ -289,4 +289,31 @@ extern NSString *WebPreferencesChangedNotification;
 */
 - (BOOL)shouldPrintBackgrounds;
 
+/*!
+    @method setPrivateBrowsingEnabled:
+    @param flag 
+    @abstract If private browsing is enabled, WebKit will not store information
+    about sites the user visits.
+ */
+- (void)setPrivateBrowsingEnabled:(BOOL)flag;
+
+/*!
+    @method privateBrowsingEnabled
+ */
+- (BOOL)privateBrowsingEnabled;
+
+/*!
+    @method setTabsToLinks:
+    @param flag 
+    @abstract If tabsToLinks is YES, the tab key will focus links and form controls. 
+    The option key temporarily reverses this preference.
+*/
+- (void)setTabsToLinks:(BOOL)flag;
+
+/*!
+    @method tabsToLinks
+*/
+- (BOOL)tabsToLinks;
+
+
 @end
index 9c648406f55990e220c6cc464693b9dcdc2b9904..a5cf23314424d83a1b2018f68c088d95ac27cdec 100644 (file)
@@ -546,43 +546,43 @@ NS_ENDHANDLER
     return _private->autosaves;
 }
 
-@end
-
-@implementation WebPreferences (WebPrivate)
-
-- (int)_pageCacheSize
+- (void)setTabsToLinks:(BOOL)flag
 {
-    return [[NSUserDefaults standardUserDefaults] integerForKey:WebKitPageCacheSizePreferenceKey];
+    [self _setBoolValue: flag forKey: WebKitTabToLinksPreferenceKey];
 }
 
-- (int)_objectCacheSize
+- (BOOL)tabsToLinks
 {
-    return [[NSUserDefaults standardUserDefaults] integerForKey:WebKitObjectCacheSizePreferenceKey];
+    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitTabToLinksPreferenceKey];
 }
 
-- (NSTimeInterval)_backForwardCacheExpirationInterval
+- (void)setPrivateBrowsingEnabled:(BOOL)flag
 {
-    return (NSTimeInterval)[[NSUserDefaults standardUserDefaults] floatForKey:WebKitBackForwardCacheExpirationIntervalKey];
+    [self _setBoolValue:flag forKey:WebKitPrivateBrowsingEnabledPreferenceKey];
 }
 
-- (void)setTabsToLinks:(BOOL)flag
+- (BOOL)privateBrowsingEnabled
 {
-    [self _setBoolValue: flag forKey: WebKitTabToLinksPreferenceKey];
+    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitPrivateBrowsingEnabledPreferenceKey];
 }
 
-- (BOOL)tabsToLinks
+@end
+
+@implementation WebPreferences (WebPrivate)
+
+- (int)_pageCacheSize
 {
-    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitTabToLinksPreferenceKey];
+    return [[NSUserDefaults standardUserDefaults] integerForKey:WebKitPageCacheSizePreferenceKey];
 }
 
-- (void)setPrivateBrowsingEnabled:(BOOL)flag
+- (int)_objectCacheSize
 {
-    [self _setBoolValue:flag forKey:WebKitPrivateBrowsingEnabledPreferenceKey];
+    return [[NSUserDefaults standardUserDefaults] integerForKey:WebKitObjectCacheSizePreferenceKey];
 }
 
-- (BOOL)privateBrowsingEnabled
+- (NSTimeInterval)_backForwardCacheExpirationInterval
 {
-    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitPrivateBrowsingEnabledPreferenceKey];
+    return (NSTimeInterval)[[NSUserDefaults standardUserDefaults] floatForKey:WebKitBackForwardCacheExpirationIntervalKey];
 }
 
 static NSMutableDictionary *webPreferencesInstances = nil;
index 27d37b9dd70c028b896a8ccd1cd98dd4688d0107..ab20c43dd6d5fe7f5b15fd7a81a6a5e6e34a96a3 100644 (file)
 - (NSTimeInterval)_backForwardCacheExpirationInterval;
 
 + (void)_setIBCreatorID:(NSString *)string;
-
-/*!
-    @method setPrivateBrowsingEnabled:
-    @param flag 
-    @abstract If private browsing is enabled, WebKit will not store information
-    about sites the user visits.
-*/
-- (void)setPrivateBrowsingEnabled:(BOOL)flag;
-
-/*!
-    @method privateBrowsingEnabled
- */
-- (BOOL)privateBrowsingEnabled;
-
-/*!
-    @method setTabsToLinks:
-    @param flag 
-    @abstract If tabsToLinks is YES, the tab key will focus links and form controls. 
-    The option key temporarily reverses this preference.
-*/
-- (void)setTabsToLinks:(BOOL)flag;
-
-/*!
-    @method tabsToLinks
-*/
-- (BOOL)tabsToLinks;
-
 @end