Reviewed by Darin.
authoradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 May 2007 21:16:38 +0000 (21:16 +0000)
committeradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 14 May 2007 21:16:38 +0000 (21:16 +0000)
        Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload

        * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/mac/PopupMenuMac.mm

index 81c22cb9a4bc5361f2cc52f0d7b9f1e668e69b87..60e45a4477468f7e758905420858647c048867eb 100644 (file)
@@ -1,3 +1,11 @@
+2007-05-14  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload
+
+        * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.
+
 2007-05-14  Adele Peterson  <adele@apple.com>
 
         Reviewed by Darin.
index d76e0ac59648dddbe7ebb5d93e7cb515fe18897e..67a2669d580134e18685d40dad7636dba249ae99 100644 (file)
@@ -153,6 +153,7 @@ void PopupMenu::show(const IntRect& r, FrameView* v, int index)
     frame->willPopupMenu(menu);
     wkPopupMenu(menu, location, roundf(NSWidth(r)), dummyView.get(), index, font);
 
+    [m_popup.get() dismissPopUp];
     [dummyView.get() removeFromSuperview];
 
     if (client()) {