+2006-06-29 Mitz Pettel <opendarwin.org@mitzpettel.com>
+
+ Reviewed by Darin.
+
+ - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
+ Assertion failure when changing an RTL table cell to display:none
+
+ * fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
+ * fast/table/rtl-cell-display-none-assert-expected.png: Added.
+ * fast/table/rtl-cell-display-none-assert-expected.txt: Added.
+ * fast/table/rtl-cell-display-none-assert.html: Added.
+
2006-06-29 Beth Dakin <bdakin@apple.com>
Reviewed by Hyatt.
--- /dev/null
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x36
+ RenderText {#text} at (0,0) size 172x18
+ text run at (0,0) width 172: "This is a regression test for "
+ RenderInline {I} at (0,0) size 781x36
+ RenderInline {A} at (0,0) size 348x18 [color=#0000EE]
+ RenderText {#text} at (172,0) size 348x18
+ text run at (172,0) width 348: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9652"
+ RenderText {#text} at (520,0) size 781x36
+ text run at (520,0) width 4: " "
+ text run at (524,0) width 257: "Assertion failure when changing an RTL"
+ text run at (0,18) width 158: "table cell to display:none"
+ RenderText {#text} at (158,18) size 4x18
+ text run at (158,18) width 4: "."
+ RenderBlock {HR} at (0,52) size 784x2 [border: (1px inset #000000)]
+ RenderBlock {P} at (0,70) size 784x18
+ RenderText {#text} at (0,0) size 257x18
+ text run at (0,0) width 257: "No assertion failure means TEST PASS."
+ RenderTable {TABLE} at (0,104) size 50x26 [border: (1px solid #008000)]
+ RenderTableSection {TBODY} at (1,1) size 48x24
+ RenderTableRow {TR} at (0,2) size 48x20
+ RenderTableCell {TD} at (2,2) size 44x20 [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (1,1) size 42x18
+ text run at (1,1) width 42: "Lorem"
--- /dev/null
+<html>
+<head>
+ <title></title>
+ <script type="text/javascript">
+ function test()
+ {
+ document.body.offsetTop;
+ document.getElementById('t').style.display='none';
+ }
+ </script>
+</head>
+<body onload="test()">
+ <p>
+ This is a regression test for
+ <i><a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=9652">http://bugzilla.opendarwin.org/show_bug.cgi?id=9652</a>
+ Assertion failure when changing an RTL table cell to display:none</i>.
+ </p>
+ <hr>
+ <p>
+ No assertion failure means TEST PASS.
+ </p>
+ <table dir="rtl" style="border: 1px solid green;">
+ <tr>
+ <td>Lorem</td>
+ <td id="t">ipsum</td>
+ </tr>
+ </table>
+</body>
+</html>
+2006-06-29 Mitz Pettel <opendarwin.org@mitzpettel.com>
+
+ Reviewed by Darin.
+
+ - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
+ Assertion failure when changing an RTL table cell to display:none
+
+ Test: fast/table/rtl-cell-display-none-assert.html
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::layoutRows): Corrected the index used as
+ the last index in the columnPos vector.
+
2006-06-29 Darin Adler <darin@apple.com>
Reviewed by Anders.
int nEffCols = table()->numEffCols();
for (int r = 0; r < totalRows; r++) {
- Row *row = grid[r].row;
- int totalCols = row->size();
-
// Set the row's x/y position and width/height.
if (grid[r].rowRenderer) {
grid[r].rowRenderer->setPos(0, rowPos[r]);
if (style()->direction() == RTL) {
cell->setPos(
- table()->columnPos[(int)totalCols] -
+ table()->columnPos[nEffCols] -
table()->columnPos[table()->colToEffCol(cell->col()+cell->colSpan())] +
leftOffset,
rowPos[rindx]);