2007-10-22 Alp Toker <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=15611
        [GTK] Text selection behaviour different in Debug and Release builds

        http://bugs.webkit.org/show_bug.cgi?id=15578
        [GTK] Text editor caret does not blink

        Never allow control to reach the end of non-void functions.

        Return more sensible values, or in some cases, nulls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3971d32c42abc07ba4a1666efd144ae73ea3bf73..c11dc289545c58c093893b3cfa19ddfe4b7e8776 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,22 @@
+2007-10-22  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15611
+        [GTK] Text selection behaviour different in Debug and Release builds
+
+        http://bugs.webkit.org/show_bug.cgi?id=15578
+        [GTK] Text editor caret does not blink
+
+        Never allow control to reach the end of non-void functions.
+
+        Return more sensible values, or in some cases, nulls.
+
+        * page/gtk/EventHandlerGtk.cpp:
+        (WebCore::isKeyboardOptionTab):
+        (WebCore::EventHandler::tabsToAllControls):
+        (WebCore::EventHandler::eventActivatedView):
+
 2007-10-22  Holger Freyther  <zecke@selfish.org>
 
         Reviewed by Simon Hausmann <hausmann@kde.org>.

diff --git a/WebCore/page/gtk/EventHandlerGtk.cpp b/WebCore/page/gtk/EventHandlerGtk.cpp
index d2dedcf834a7e3e4fd840e4bbbbcf79b2c38e084..ab01471c0637ee5aff9ed804bbb092becfc2b71a 100644 (file)
--- a/WebCore/page/gtk/EventHandlerGtk.cpp
+++ b/WebCore/page/gtk/EventHandlerGtk.cpp
@@ -44,9 +44,17 @@ namespace WebCore {
 
 using namespace EventNames;
 
+static bool isKeyboardOptionTab(KeyboardEvent* event)
+{
+    return event
+        && (event->type() == keydownEvent || event->type() == keypressEvent)
+        && event->altKey()
+        && event->keyIdentifier() == "U+0009";
+}
+
 bool EventHandler::tabsToAllControls(KeyboardEvent* event) const
 {
-    return true;
+    return isKeyboardOptionTab(event);
 }
 
 void EventHandler::focusDocumentView()
@@ -78,7 +86,11 @@ bool EventHandler::passMouseDownEventToWidget(Widget* widget)
 
 bool EventHandler::eventActivatedView(const PlatformMouseEvent&) const
 {
+    //GTK+ activation is not necessarily tied to mouse events, so it may
+    //not make sense to implement this
+
     notImplemented();
+    return false;
 }
 
 bool EventHandler::passWheelEventToWidget(PlatformWheelEvent&, Widget* widget)

diff --git a/WebKit/gtk/Api/webkitgtksettings.cpp b/WebKit/gtk/Api/webkitgtksettings.cpp
index 9a85f6d8bdb36a735a2e0ea9951979cd07eb4980..041b3534f2774c49bdef7006df704731c8863eba 100644 (file)
--- a/WebKit/gtk/Api/webkitgtksettings.cpp
+++ b/WebKit/gtk/Api/webkitgtksettings.cpp
@@ -45,6 +45,7 @@ void webkit_web_settings_free(WebKitSettings* setting)
 
 WebKitSettings* webkit_web_settings_get_global(void)
 {
+    return 0;
 }
 
 void webkit_web_settings_set_global (WebKitSettings* setting)
@@ -55,8 +56,9 @@ void webkit_web_settings_set_font_family(WebKitSettings*, WebKitFontFamily famil
 {
 }
 
-gchar* webkit_web_settings_get_font_family(WebKitSettings*, WebKitFontFamily family)
+const gchar* webkit_web_settings_get_font_family(WebKitSettings*, WebKitFontFamily family)
 {
+    return 0;
 }
 
 void webkit_web_settings_set_user_style_sheet_location(WebKitSettings*, gchar*)

diff --git a/WebKit/gtk/Api/webkitgtksettings.h b/WebKit/gtk/Api/webkitgtksettings.h
index fbcf370fb3435cb3d5ac638fbd8bed7a754b7d5c..2c672d7498a4700e91eb2bc62dd5b37b9582ec1b 100644 (file)
--- a/WebKit/gtk/Api/webkitgtksettings.h
+++ b/WebKit/gtk/Api/webkitgtksettings.h
@@ -101,7 +101,7 @@ webkit_web_settings_set_global (WebKitSettings* setting);
 void
 webkit_web_settings_set_font_family(WebKitSettings*, WebKitFontFamily family, gchar *family_name);
 
-gchar*
+const gchar*
 webkit_web_settings_get_font_family(WebKitSettings*, WebKitFontFamily family);
 
 void

diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 1c32801866e8737bfcf02e553ec4bd6ead94d912..20cbdc4db7dbc320329a06ad5244db671e21caac 100644 (file)
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,24 @@
+2007-10-22  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15611
+        [GTK] Text selection behaviour different in Debug and Release builds
+
+        http://bugs.webkit.org/show_bug.cgi?id=15578
+        [GTK] Text editor caret does not blink
+
+        Never allow control to reach the end of non-void functions.
+
+        Return more sensible values, or in some cases, nulls.
+
+        * Api/webkitgtksettings.cpp:
+        * Api/webkitgtksettings.h:
+        * WebCoreSupport/DragClientGtk.cpp:
+        (WebKit::DragClient::actionMaskForDrag):
+        (WebKit::DragClient::dragSourceActionMaskForPoint):
+        (WebKit::DragClient::createDragImageForLink):
+
 2007-10-20  Mark Rowe  <mrowe@apple.com>
 
         Reviewed by Alp.

diff --git a/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp b/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
index 1d9762bf42d1a8a7c32210cbfd8b837108118482..4d65ba8a908266c821cddb919741c0353e046e17 100644 (file)
--- a/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
+++ b/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
@@ -1,6 +1,7 @@
 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Holger Hans Peter Freyther
+ * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -48,11 +49,13 @@ void DragClient::willPerformDragSourceAction(DragSourceAction, const IntPoint&,
 DragDestinationAction DragClient::actionMaskForDrag(DragData*)
 {
     notImplemented();
+    return DragDestinationActionAny;
 }
 
 DragSourceAction DragClient::dragSourceActionMaskForPoint(const IntPoint&)
 {
     notImplemented();
+    return DragSourceActionAny;
 }
 
 void DragClient::startDrag(DragImageRef, const IntPoint&, const IntPoint&, Clipboard*, Frame*, bool)
@@ -63,6 +66,7 @@ void DragClient::startDrag(DragImageRef, const IntPoint&, const IntPoint&, Clipb
 DragImageRef DragClient::createDragImageForLink(KURL&, const String& label, Frame*)
 {
     notImplemented();
+    return 0;
 }
 
 void DragClient::dragControllerDestroyed()