2010-12-23 Ilya Tikhonovsky <loislo@chromium.org>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Dec 2010 09:20:42 +0000 (09:20 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Dec 2010 09:20:42 +0000 (09:20 +0000)
        Reviewed by Eric Seidel.

        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).

        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
        I just discovered that we have two additional GC runs per each WebViewHost.
        Test_shell had no such calls.
        These gc runs eat 15% of cpu time.

        https://bugs.webkit.org/show_bug.cgi?id=51479

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::~WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/chromium/WebViewHost.cpp

index 65aaa70f78386e40b7770bd6339e9bfc07b37cb5..a59313cddf36ff6d89122c37092dfc8157f71a19 100644 (file)
@@ -1,3 +1,19 @@
+2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
+
+        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
+        I just discovered that we have two additional GC runs per each WebViewHost.
+        Test_shell had no such calls.
+        These gc runs eat 15% of cpu time.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51479
+
+        * DumpRenderTree/chromium/WebViewHost.cpp:
+        (WebViewHost::~WebViewHost):
+
 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
 
         Reviewed by Ojan Vafai.
index e3c8c28742ad5292e9dcf6477a51f2c7de1ef66f..d880879c9ae6f94b55a03338fb6394ed827ae63b 100644 (file)
@@ -1133,10 +1133,6 @@ WebViewHost::~WebViewHost()
         loadURLForFrame(GURL("about:blank"), WebString());
     }
 
-    // Call GC twice to clean up garbage.
-    m_shell->callJSGC();
-    m_shell->callJSGC();
-
     webWidget()->close();
 
     if (m_inModalLoop)