Reviewed by Kevin McCullough
authorbeidson <beidson@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Sep 2006 00:53:48 +0000 (00:53 +0000)
committerbeidson <beidson@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Sep 2006 00:53:48 +0000 (00:53 +0000)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
        Opening a PDF in a new tab/window creates a documentless-frame
        and we deref the document without checking its validity

        * page/Frame.cpp:
        (WebCore::Frame::iconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/Frame.cpp

index 69dc03bf2b712ab10eacfb5ece64ea1c90a2e657..7fbb61fa362cd94b489f1d1377429f157e0e4b3b 100644 (file)
@@ -1,3 +1,14 @@
+2006-09-19  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Kevin McCullough
+
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
+        Opening a PDF in a new tab/window creates a documentless-frame
+        and we deref the document without checking its validity
+
+        * page/Frame.cpp:
+        (WebCore::Frame::iconURL):
+
 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by harrison
index 99b3dffee0bcead8b71a09cf10e2a4f5f2468734..af1fc25bb4241d0df0132a2cf3f20c7a0030e9b0 100644 (file)
@@ -231,7 +231,7 @@ KURL Frame::iconURL()
         return "";
         
     // If we have an iconURL from a Link element, return that
-    if (!document()->iconURL().isEmpty())
+    if (document() && !document()->iconURL().isEmpty())
         return KURL(document()->iconURL().deprecatedString());
         
     // Don't return a favicon iconURL unless we're http or https