LayoutTests:

        Reviewed by Adam.

        - Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        * fast/forms/HTMLOptionElement_label05-expected.checksum:
        * fast/forms/HTMLOptionElement_label05-expected.png:
        * fast/forms/HTMLOptionElement_label05-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/forms/option-strip-whitespace-expected.txt:
        * fast/forms/password-doubleclick-selection-expected.txt: Added.
        * fast/forms/password-doubleclick-selection.html: Added.
        * fast/forms/select-change-popup-to-listbox-expected.checksum:
        * fast/forms/select-change-popup-to-listbox-expected.png:
        * fast/forms/select-change-popup-to-listbox-expected.txt:
        * fast/text/updateNewFont-expected.checksum:
        * fast/text/updateNewFont-expected.png:
        * fast/text/updateNewFont-expected.txt:

WebCore:

        Reviewed by Adam.

        - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
        by using "-webkit-appearance:none".

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 50b7047f3215d376bab3e59c1df3b945a7deb866..5065437cf7312d87151e213f0a5377712e56f50e 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,27 @@
+2006-10-02  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Adam.
+
+        - Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
+
+        * fast/forms/HTMLOptionElement_label05-expected.checksum:
+        * fast/forms/HTMLOptionElement_label05-expected.png:
+        * fast/forms/HTMLOptionElement_label05-expected.txt:
+        * fast/forms/form-element-geometry-expected.checksum:
+        * fast/forms/form-element-geometry-expected.png:
+        * fast/forms/form-element-geometry-expected.txt:
+        * fast/forms/option-strip-whitespace-expected.checksum:
+        * fast/forms/option-strip-whitespace-expected.png:
+        * fast/forms/option-strip-whitespace-expected.txt:
+        * fast/forms/password-doubleclick-selection-expected.txt: Added.
+        * fast/forms/password-doubleclick-selection.html: Added.
+        * fast/forms/select-change-popup-to-listbox-expected.checksum:
+        * fast/forms/select-change-popup-to-listbox-expected.png:
+        * fast/forms/select-change-popup-to-listbox-expected.txt:
+        * fast/text/updateNewFont-expected.checksum:
+        * fast/text/updateNewFont-expected.png:
+        * fast/text/updateNewFont-expected.txt:
+
 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
 
         Rubber stamped by Alexey.

diff --git a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.checksum b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.checksum
index 2bb1d153ad06456bcfa5c9c452675718f582d201..105845b08287c490e0567d3adbb3d0e41eb13b82 100644 (file)
--- a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.checksum
+++ b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.checksum
@@ -1 +1 @@
-4e5bf2bb603a97f4173e63946bf94d11
\ No newline at end of file
+a28ffbb51a1966d1c0125a7c4b2833c4
\ No newline at end of file

diff --git a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.png b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.png
index 0e854eeb4907bcb9a9584b73d9bdd3f77c2f2432..a499bb7ad2928f135b90d26a509ca0b58685af8f 100644 (file)
Binary files a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.png and b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.png differ

diff --git a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.txt b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.txt
index 48221d0a43c3334d221a1eab38acc5ea427d3220..c80f8eef593609da2025f9832e43507f4c00fdab 100644 (file)
--- a/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.txt
+++ b/LayoutTests/fast/forms/HTMLOptionElement_label05-expected.txt
@@ -6,5 +6,5 @@ layer at (0,0) size 800x600
       RenderText {#text} at (0,0) size 668x18
         text run at (0,0) width 668: "In the list box below, the text \"This text should appear\" should be shown as the first entry into the list box."
       RenderBR {BR} at (668,14) size 0x0
-      DeprecatedRenderSelect {SELECT} at (2,20) size 144x72
+      RenderListBox {SELECT} at (2,20) size 144x72 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
       RenderText {#text} at (0,0) size 0x0

diff --git a/LayoutTests/fast/forms/form-element-geometry-expected.checksum b/LayoutTests/fast/forms/form-element-geometry-expected.checksum
index 7b2139ab8e3227acb03405db0d2b9ec8c62dec34..fa1df9954f1e4ee27d8f5455873431f181ac67c6 100644 (file)
--- a/LayoutTests/fast/forms/form-element-geometry-expected.checksum
+++ b/LayoutTests/fast/forms/form-element-geometry-expected.checksum
@@ -1 +1 @@
-a8d1c2f6e6f0500f6481f30518f36a19
\ No newline at end of file
+523f7c9b530ea3ef2bf6eb442b6d79e0
\ No newline at end of file

diff --git a/LayoutTests/fast/forms/form-element-geometry-expected.png b/LayoutTests/fast/forms/form-element-geometry-expected.png
index a65b97564cbfa0291a232851bd4853f5c76ec183..9da630c1fd7d43b2400f0b20819dabd518070950 100644 (file)
Binary files a/LayoutTests/fast/forms/form-element-geometry-expected.png and b/LayoutTests/fast/forms/form-element-geometry-expected.png differ

diff --git a/LayoutTests/fast/forms/form-element-geometry-expected.txt b/LayoutTests/fast/forms/form-element-geometry-expected.txt
index 38b42e3101b6d146e8df821eb9483ddd0e73d639..010025f6f426afeb763caed664cae563c23252b9 100644 (file)
--- a/LayoutTests/fast/forms/form-element-geometry-expected.txt
+++ b/LayoutTests/fast/forms/form-element-geometry-expected.txt
@@ -97,7 +97,7 @@ layer at (0,0) size 785x627
                 RenderTextField {INPUT} at (2,2) size 78x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
             RenderTableCell {TD} at (88,2) size 40x64 [r=0 c=1 rs=1 cs=1]
               RenderBlock {DIV} at (1,1) size 38x62 [border: (2px solid #0000FF)]
-                DeprecatedRenderSelect {SELECT} at (2,2) size 34x58
+                RenderListBox {SELECT} at (2,2) size 34x58 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
             RenderTableCell {TD} at (130,2) size 243x24 [r=0 c=2 rs=1 cs=1]
               RenderBlock {DIV} at (1,1) size 241x22 [border: (2px solid #0000FF)]
                 RenderFileUploadControl {INPUT} at (2,2) size 237x18

diff --git a/LayoutTests/fast/forms/option-strip-whitespace-expected.checksum b/LayoutTests/fast/forms/option-strip-whitespace-expected.checksum
index 59bb687533cc82c041d38a87f32bdd9e12f33988..a0d48193348b57f5e0d701c6e014a5e588bc21a5 100644 (file)
--- a/LayoutTests/fast/forms/option-strip-whitespace-expected.checksum
+++ b/LayoutTests/fast/forms/option-strip-whitespace-expected.checksum
@@ -1 +1 @@
-a26974ff1cb0e2dc0d75248939318443
\ No newline at end of file
+3b5d1b87b0bff73ccf37e6b2b84a7aa5
\ No newline at end of file

diff --git a/LayoutTests/fast/forms/option-strip-whitespace-expected.png b/LayoutTests/fast/forms/option-strip-whitespace-expected.png
index a7f3f68897e271bec353dfe41ff156ac0ceb2649..c859e52207e79bde6c6625b45fa060f2d557f607 100644 (file)
Binary files a/LayoutTests/fast/forms/option-strip-whitespace-expected.png and b/LayoutTests/fast/forms/option-strip-whitespace-expected.png differ

diff --git a/LayoutTests/fast/forms/option-strip-whitespace-expected.txt b/LayoutTests/fast/forms/option-strip-whitespace-expected.txt
index 80dc242bc56a829785380d4a2960829dd5222766..976fd079ae536977aa8e65ab63d4383f630e616e 100644 (file)
--- a/LayoutTests/fast/forms/option-strip-whitespace-expected.txt
+++ b/LayoutTests/fast/forms/option-strip-whitespace-expected.txt
@@ -9,12 +9,12 @@ layer at (0,0) size 800x600
       RenderBlock (anonymous) at (0,34) size 784x262
         RenderText {#text} at (0,41) size 71x18
           text run at (0,41) width 71: "Five Tabs: "
-        DeprecatedRenderSelect {SELECT} at (73,2) size 67x58
+        RenderListBox {SELECT} at (73,2) size 67x58 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
         RenderBR {BR} at (142,55) size 0x0
         RenderBR {BR} at (0,62) size 0x18
         RenderText {#text} at (0,121) size 84x18
           text run at (0,121) width 84: "Five Spaces: "
-        DeprecatedRenderSelect {SELECT} at (86,82) size 67x58
+        RenderListBox {SELECT} at (86,82) size 67x58 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
         RenderBR {BR} at (155,135) size 0x0
         RenderBR {BR} at (0,142) size 0x18
         RenderText {#text} at (0,161) size 298x18

diff --git a/LayoutTests/fast/forms/password-doubleclick-selection-expected.txt b/LayoutTests/fast/forms/password-doubleclick-selection-expected.txt
new file mode 100644 (file)
index 0000000..a2c62c4
--- /dev/null
+++ b/LayoutTests/fast/forms/password-doubleclick-selection-expected.txt
@@ -0,0 +1,8 @@
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 5 of #text > DIV to 5 of #text > DIV affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV to 5 of #text > DIV toDOMRange:range from 0 of #text > DIV to 11 of #text > DIV affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+ This tests that double clicking in a password field will not expose word boundaries.
+
+Test Passed.
+

diff --git a/LayoutTests/fast/forms/password-doubleclick-selection.html b/LayoutTests/fast/forms/password-doubleclick-selection.html
new file mode 100644 (file)
index 0000000..147c63a
--- /dev/null
+++ b/LayoutTests/fast/forms/password-doubleclick-selection.html
@@ -0,0 +1,28 @@
+<html>
+<head>
+    <script>
+    function test() {
+        var pass = document.getElementById('tf');
+        var res = document.getElementById('res');
+
+        if (window.layoutTestController) {
+            layoutTestController.dumpAsText();
+            eventSender.mouseMoveTo(45, 25);
+            eventSender.mouseDown();
+            eventSender.mouseUp();
+            eventSender.mouseDown();
+            eventSender.mouseUp();
+            if (pass.selectionStart == 0 && pass.selectionEnd == 11)
+                res.innerHTML = "Test Passed.";
+            else
+                res.innerHTML = "Test Failed.  SelectionStart index = " + pass.selectionStart + ".  SelectionEnd index = " + pass.selectionEnd + ".";
+        }
+    }
+    </script>
+</head>
+<body onload="test()">
+    <input type="password" value="123 456 789" id="tf"></input>
+    This tests that double clicking in a password field will not expose word boundaries.<br>
+    <br><div id="res"></div>
+</body>
+</html>

diff --git a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.checksum b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.checksum
index a05f3dc9fa9c8627efa2affbe3b9656776d503bb..ef347a8972da7b4544ff3b39ef4295334e8e9c02 100644 (file)
--- a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.checksum
+++ b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.checksum
@@ -1 +1 @@
-def7c5619e192ec85dc9bd307dc08f9a
\ No newline at end of file
+34ba05e2dd0fccccacef71e3dc6cc004
\ No newline at end of file

diff --git a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.png b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.png
index d2b3632854b91babe87658d41348313fc2cb6c2b..945c4c7f9d459198ad54a02c726c129663e235a3 100644 (file)
Binary files a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.png and b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.png differ

diff --git a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.txt b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.txt
index 356cb9aa6fddbdb2bdd3f2b26640e5a860582e14..de5dbc519c840692398eaa1eccf4f8592b04ebfb 100644 (file)
--- a/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.txt
+++ b/LayoutTests/fast/forms/select-change-popup-to-listbox-expected.txt
@@ -6,5 +6,5 @@ layer at (0,0) size 800x600
       RenderText {#text} at (0,0) size 449x18
         text run at (0,0) width 449: "This tests that you can dynamically change a popup menu to a list box. "
       RenderBR {BR} at (449,14) size 0x0
-      DeprecatedRenderSelect {SELECT} at (2,20) size 183x72
+      RenderListBox {SELECT} at (2,20) size 183x72 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
       RenderText {#text} at (0,0) size 0x0

diff --git a/LayoutTests/fast/text/updateNewFont-expected.checksum b/LayoutTests/fast/text/updateNewFont-expected.checksum
index 7b9ac8d9a8e7b5a9b182560085a8da25620fbc78..94cc4a6df8d6f7da48ca60fee7fe762417535141 100644 (file)
--- a/LayoutTests/fast/text/updateNewFont-expected.checksum
+++ b/LayoutTests/fast/text/updateNewFont-expected.checksum
@@ -1 +1 @@
-a99b87e29c6e9bf1b8e56eb2fc65b4a7
\ No newline at end of file
+ed271e1e1f56ec84a029a840065338c3
\ No newline at end of file

diff --git a/LayoutTests/fast/text/updateNewFont-expected.png b/LayoutTests/fast/text/updateNewFont-expected.png
index a98d8f31d2ae9ed56556ea25124e7d010211d6d1..8708d5dc23485fddc812ec99d32c70edd39ed9cc 100644 (file)
Binary files a/LayoutTests/fast/text/updateNewFont-expected.png and b/LayoutTests/fast/text/updateNewFont-expected.png differ

diff --git a/LayoutTests/fast/text/updateNewFont-expected.txt b/LayoutTests/fast/text/updateNewFont-expected.txt
index 8619da8acbcfc904191149869eda87dc55714a96..6adb298fc4633ca21eb7a6e8ed2564fa23b2c33d 100644 (file)
--- a/LayoutTests/fast/text/updateNewFont-expected.txt
+++ b/LayoutTests/fast/text/updateNewFont-expected.txt
@@ -3,7 +3,7 @@ layer at (0,0) size 800x600
 layer at (0,0) size 800x126
   RenderBlock {HTML} at (0,0) size 800x126
     RenderBody {BODY} at (8,8) size 784x110
-      DeprecatedRenderSelect {SELECT} at (0,0) size 34x110
+      RenderListBox {SELECT} at (0,0) size 34x110 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index aadb8514062f18bc2838c91a90321d5165f63a6c..87ca2aaf34ec97e896e9e9739f70192e28399b4d 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2006-10-02  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Adam.
+
+        - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
+
+        There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
+        by using "-webkit-appearance:none".
+
+        * css/html4.css:
+
 2006-10-02  David Harrison  <harrison@apple.com>
 
         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was

diff --git a/WebCore/css/html4.css b/WebCore/css/html4.css
index e5a2fb5dafe9003e7fe1fc0ec1fb5d9b23a34cd2..ade9d19c6748ba3e0f8baaa31aaafbc94d1c4e5d 100644 (file)
--- a/WebCore/css/html4.css
+++ b/WebCore/css/html4.css
@@ -424,21 +424,25 @@ select {
 select[size],
 select[multiple],
 select[size][multiple] {
-    /* FIXME: When converting the list box implementation, remove these. */
+    /* FIXME: If we need to switch back to the old listbox implementation, switch the commented style blocks here */
+
+    /* Old listbox appearance */
+    /*
     -webkit-appearance: none;
     -webkit-box-align: initial;
     box-sizing: initial;
     color: initial;
     border: initial;
     background-color: initial;
-    /*
+    */
+
+    /* New listbox appearance */
     -webkit-appearance: listbox;
     -webkit-box-align: start;
     box-sizing: initial;
     border: 1px inset gray;
     -webkit-border-radius: initial;
     white-space: initial;
-    */
 }
  
 select[size="0"],