[Win] Correct IME Regression after r141479
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Feb 2014 20:38:48 +0000 (20:38 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Feb 2014 20:38:48 +0000 (20:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=128323
<rdar://problem/15952986>

Reviewed by Tim Horton.

* WebView.cpp:
(WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used
to select the resetIME case. Corrected for behavior of new cancel method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/win/ChangeLog
Source/WebKit/win/WebView.cpp

index ff9c45530fe5588cf8134034a78fdc26f7bd7fd2..952a8e143ee8aa7625ad00bee18f6c4b635d424b 100644 (file)
@@ -1,3 +1,15 @@
+2014-02-06  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] Correct IME Regression after r141479
+        https://bugs.webkit.org/show_bug.cgi?id=128323
+        <rdar://problem/15952986>
+
+        Reviewed by Tim Horton.
+
+        * WebView.cpp:
+        (WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used
+        to select the resetIME case. Corrected for behavior of new cancel method.
+
 2014-02-04  Andreas Kling  <akling@apple.com>
 
         Remove <iframe seamless> support.
index f9fff2bd6a5f745405dc919b18c9a5a57a9c3c01..08507a23d8e43113768aea09743da48d51c3ad1c 100644 (file)
@@ -5563,7 +5563,7 @@ void WebView::resetIME(Frame* targetFrame)
 void WebView::updateSelectionForIME()
 {
     Frame& targetFrame = m_page->focusController().focusedOrMainFrame();
-    if (!targetFrame.editor().cancelCompositionIfSelectionIsInvalid())
+    if (targetFrame.editor().cancelCompositionIfSelectionIsInvalid())
         resetIME(&targetFrame);
 }