REGRESSION (r142549): Remove web intents code
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Feb 2013 04:22:34 +0000 (04:22 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Feb 2013 04:22:34 +0000 (04:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109532

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
Reviewed by Nico Weber.

Remove remaning code related to web intents.

No new tests, no change on behavior.

* UseJSC.cmake:
* bindings/js/JSIntentConstructor.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/UseJSC.cmake
Source/WebCore/bindings/js/JSIntentConstructor.cpp [deleted file]

index 3c3c65dfed3b63a0be538b0b6a8af4441d976b5d..c26535704448d076e4d1d3212f9493b94ac89d26 100644 (file)
@@ -1,3 +1,17 @@
+2013-02-11  KwangYong Choi  <ky0.choi@samsung.com>
+
+        REGRESSION (r142549): Remove web intents code
+        https://bugs.webkit.org/show_bug.cgi?id=109532
+
+        Reviewed by Nico Weber.
+
+        Remove remaning code related to web intents.
+
+        No new tests, no change on behavior.
+
+        * UseJSC.cmake:
+        * bindings/js/JSIntentConstructor.cpp: Removed.
+
 2013-02-11  Kenneth Russell  <kbr@google.com>
 
         Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
 2013-02-11  Kenneth Russell  <kbr@google.com>
 
         Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
index 6d8c9a48ec0f09e5d3aaeaeddd625a1aa7509dee..83b8b9f6df9830fe4617b2372ed7fdeccaace609 100644 (file)
@@ -273,12 +273,6 @@ if (ENABLE_WEB_AUDIO)
     )
 endif ()
 
     )
 endif ()
 
-if (ENABLE_WEB_INTENTS)
-    list(APPEND WebCore_SOURCES
-        bindings/js/JSIntentConstructor.cpp
-    )
-endif ()
-
 list(APPEND SCRIPTS_BINDINGS
     ${WEBCORE_DIR}/bindings/scripts/CodeGenerator.pm
     ${WEBCORE_DIR}/bindings/scripts/CodeGeneratorJS.pm
 list(APPEND SCRIPTS_BINDINGS
     ${WEBCORE_DIR}/bindings/scripts/CodeGenerator.pm
     ${WEBCORE_DIR}/bindings/scripts/CodeGeneratorJS.pm
diff --git a/Source/WebCore/bindings/js/JSIntentConstructor.cpp b/Source/WebCore/bindings/js/JSIntentConstructor.cpp
deleted file mode 100644 (file)
index 9e76368..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
-/*
-    Copyright (C) 2012 Intel Corporation
-
-    This library is free software; you can redistribute it and/or
-    modify it under the terms of the GNU Library General Public
-    License as published by the Free Software Foundation; either
-    version 2 of the License, or (at your option) any later version.
-
-    This library is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-    Library General Public License for more details.
-
-    You should have received a copy of the GNU Library General Public License
-    along with this library; see the file COPYING.LIB.  If not, write to
-    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
-    Boston, MA 02110-1301, USA.
-*/
-
-#include "config.h"
-#include "Intent.h"
-
-#include "Dictionary.h"
-#include "ExceptionCode.h"
-#include "JSCJSValue.h"
-#include "JSDOMBinding.h"
-#include "JSIntent.h"
-#include "JSMessagePortCustom.h"
-#include <runtime/Error.h>
-#include <wtf/ArrayBuffer.h>
-
-using namespace JSC;
-
-namespace WebCore {
-
-EncodedJSValue JSC_HOST_CALL JSIntentConstructor::constructJSIntent(ExecState* exec)
-{
-    JSIntentConstructor* castedThis = jsCast<JSIntentConstructor*>(exec->callee());
-
-    if (exec->argumentCount() < 1)
-        return throwVMError(exec, createNotEnoughArgumentsError(exec));
-
-    if (exec->argumentCount() == 1) {
-        // Use the dictionary constructor. This block will return if the
-        // argument isn't a valid Dictionary.
-        JSValue optionsValue = exec->argument(0);
-        if (!optionsValue.isObject()) {
-            setDOMException(exec, SYNTAX_ERR);
-            return JSValue::encode(jsUndefined());
-        }
-        Dictionary options(exec, optionsValue);
-        if (exec->hadException())
-            return JSValue::encode(jsUndefined());
-
-        ExceptionCode ec = 0;
-        RefPtr<Intent> impl = Intent::create(exec, options, ec);
-        if (ec) {
-            setDOMException(exec, ec);
-            return JSValue::encode(jsUndefined());
-        }
-        return JSValue::encode(asObject(toJS(exec, castedThis->globalObject(), impl.get())));
-    }
-
-    const String action(MAYBE_MISSING_PARAMETER(exec, 0, DefaultIsUndefined).isEmpty() ? String() : MAYBE_MISSING_PARAMETER(exec, 0, DefaultIsUndefined).toWTFString(exec));
-    if (exec->hadException())
-        return JSValue::encode(jsUndefined());
-
-    const String type(MAYBE_MISSING_PARAMETER(exec, 1, DefaultIsUndefined).isEmpty() ? String() : MAYBE_MISSING_PARAMETER(exec, 1, DefaultIsUndefined).toWTFString(exec));
-    if (exec->hadException())
-        return JSValue::encode(jsUndefined());
-
-    MessagePortArray messagePortArrayTransferList;
-    ArrayBufferArray arrayBufferArrayTransferList;
-    if (exec->argumentCount() > 3) {
-        fillMessagePortArray(exec, exec->argument(3), messagePortArrayTransferList, arrayBufferArrayTransferList);
-        if (exec->hadException())
-            return JSValue::encode(jsUndefined());
-    }
-    RefPtr<SerializedScriptValue> data = SerializedScriptValue::create(exec, exec->argument(2), &messagePortArrayTransferList, &arrayBufferArrayTransferList);
-    if (exec->hadException())
-        return JSValue::encode(jsUndefined());
-
-    ExceptionCode ec = 0;
-    RefPtr<Intent> impl = Intent::create(action, type, data, messagePortArrayTransferList, ec);
-    if (ec) {
-        setDOMException(exec, ec);
-        return JSValue::encode(jsUndefined());
-    }
-    return JSValue::encode(asObject(toJS(exec, castedThis->globalObject(), impl.get())));
-}
-
-} // namespace WebCore