Make changes to the Mac WebKit2 Skipped file trigger Windows builds
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Nov 2010 18:13:50 +0000 (18:13 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Nov 2010 18:13:50 +0000 (18:13 +0000)
We use that file on Windows!

Fixes <http://webkit.org/b/49643> Changes to
LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't

Reviewed by Steve Falkenburg.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added the mac-wk2 directory and make it
trigger builds on SnowLeopard and Windows.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build): Added a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/common/config/build.py
WebKitTools/Scripts/webkitpy/common/config/build_unittest.py

index f8c3f61..f0aac78 100644 (file)
@@ -1,3 +1,21 @@
+2010-11-17  Adam Roben  <aroben@apple.com>
+
+        Make changes to the Mac WebKit2 Skipped file trigger Windows builds
+
+        We use that file on Windows!
+
+        Fixes <http://webkit.org/b/49643> Changes to
+        LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
+
+        Reviewed by Steve Falkenburg.
+
+        * Scripts/webkitpy/common/config/build.py:
+        (_should_file_trigger_build): Added the mac-wk2 directory and make it
+        trigger builds on SnowLeopard and Windows.
+
+        * Scripts/webkitpy/common/config/build_unittest.py:
+        (ShouldBuildTest.test_should_build): Added a test.
+
 2010-11-17  Satish Sampath  <satish@chromium.org>
 
         Reviewed by Jeremy Orlow.
index d938c8e..b5833ab 100644 (file)
@@ -75,6 +75,7 @@ def _should_file_trigger_build(target_platform, file):
         ("mac", ["chromium-mac", "mac"]),
         ("mac-leopard", ["mac-leopard"]),
         ("mac-snowleopard", ["mac-snowleopard"]),
+        ("mac-wk2", ["mac-snowleopard", "win"]),
         ("objc", ["mac"]),
         ("qt", ["qt"]),
         ("skia", ["chromium"]),
index aa24758..c93c91e 100644 (file)
@@ -36,6 +36,7 @@ class ShouldBuildTest(unittest.TestCase):
         (["LayoutTests/platform/chromium-linux/foo"], ["chromium-linux"]),
         (["LayoutTests/platform/mac-leopard/foo"], ["mac-leopard"]),
         (["LayoutTests/platform/mac-snowleopard/foo"], ["mac-snowleopard", "win"]),
+        (["LayoutTests/platform/mac-wk2/Skipped"], ["mac-snowleopard", "win"]),
         (["LayoutTests/platform/mac/foo"], ["mac-leopard", "mac-snowleopard", "win"]),
         (["LayoutTests/platform/win-xp/foo"], ["win"]),
         (["LayoutTests/platform/win-wk2/foo"], ["win"]),