Fix roll-chromium-deps and hi.
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Apr 2013 07:45:34 +0000 (07:45 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Apr 2013 07:45:34 +0000 (07:45 +0000)
* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
(RollChromiumDEPS.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/tool/bot/irc_command.py

index 7cfed394646fbac624f6884bd1b75a18cf0f4d8c..a4110804df758c9545985fa857ab9ee47a3fb1c6 100644 (file)
@@ -1,3 +1,11 @@
+2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Fix roll-chromium-deps and hi.
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        (Hi.execute):
+        (RollChromiumDEPS.execute):
+
 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
 
         Remove webkitpy code to roll Chromium DEPS
index 38455379539dc5aa0a66dbf28a7f0e3bd98397a5..dd22fa256e3abf91e4fe08b51b79c01053bee56c 100644 (file)
@@ -114,6 +114,8 @@ class Hi(IRCCommand):
     help_string = "Retrieves a random quip from Bugzilla."
 
     def execute(self, nick, args, tool, sheriff):
+        if len(args) and args[0] == 'webkitbot!':
+            return "%s: hi %s!" % (nick, nick)
         quips = tool.bugs.quips()
         quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
         return random.choice(quips)
@@ -133,11 +135,9 @@ class RollChromiumDEPS(IRCCommand):
     help_string = "Rolls WebKit's Chromium DEPS to the given revision???"
 
     def execute(self, nick, args, tool, sheriff):
-        revision = self._parse_args(args)
-        if not revision:
+        if not len(args):
             return self.usage(nick)
-
-        tool.irc().post("%s: Thank You." % nick)
+        return "%s: Thank You." % nick
 
 
 class Rollout(IRCCommand):