2007-11-24 Alp Toker <alp@atoker.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 25 Nov 2007 03:39:55 +0000 (03:39 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 25 Nov 2007 03:39:55 +0000 (03:39 +0000)
        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=16125
        [GTK] Up key doesn't work properly when content is editable

        Add a missing 'break' to avoid falling through to the next case when
        handling VK_UP keystrokes. This was noticed when working on editing
        support in the GTK+ port.

        I've checked the other cases for similar typos and they seem fine.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeypress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/gtk/ChangeLog
WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp

index 6a9470101f9e5b55a997b7ea2c1c2c0ad913254e..8e0ac44243a284c8583c080820fc9e8bb6e48ab7 100644 (file)
@@ -1,3 +1,19 @@
+2007-11-24  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16125
+        [GTK] Up key doesn't work properly when content is editable
+
+        Add a missing 'break' to avoid falling through to the next case when
+        handling VK_UP keystrokes. This was noticed when working on editing
+        support in the GTK+ port.
+
+        I've checked the other cases for similar typos and they seem fine.
+
+        * WebCoreSupport/EditorClientGtk.cpp:
+        (WebKit::EditorClient::handleKeypress):
+
 2007-11-24  Xan Lopez  <xan@gnome.org>
 
         Reviewed by Alp Toker.
index 79d6c3a66625d37518b8af363eca74c86413a7f8..93c45b54562b0a687887abcfa913854aa0cfb958 100644 (file)
@@ -257,6 +257,7 @@ void EditorClient::handleKeypress(KeyboardEvent* event)
                         SelectionController::BACKWARD,
                         kevent->ctrlKey() ? ParagraphGranularity : LineGranularity,
                         true);
+                break;
             case VK_DOWN:
                 frame->selectionController()->modify(kevent->shiftKey() ? SelectionController::EXTEND : SelectionController::MOVE,
                         SelectionController::FORWARD,