2011-02-20 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] don't let lines/diffblocks be mouse focusable
        https://bugs.webkit.org/show_bug.cgi?id=54851

        Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
        is committed. In the interim, it won't break anything.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index e5a7075dfbc5f1cf7dcee550e0a99d6fdc0f279b..433cbfe9026e0d6312747bdfe22663060b8c42a7 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,15 @@
+2011-02-20  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [codereviewtool] don't let lines/diffblocks be mouse focusable
+        https://bugs.webkit.org/show_bug.cgi?id=54851
+
+        Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
+        is committed. In the interim, it won't break anything.
+
+        * code-review.js:
+
 2011-02-20  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 843ab75790dd2737ed52365afe597a0097362fd4..c3fb45c70cdba1c89a2cc21c0dc14f34794dda20 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -1358,6 +1358,8 @@ var CODE_REVIEW_UNITTEST;
     // -1 makes the element focusable without actually putting in in the tab order.
     node.attr('tabindex', -1);
     node.focus();
+    // Remove the tabindex on blur to avoid having the node be mouse-focusable.
+    node.bind('blur', function() { node.removeAttr('tabindex'); });
     $(document).scrollTop(node.position().top - window.innerHeight / 2);
   }